WordPress commits: wp-trunk branch

git: fc434a0
svn: r47260
1 of 3404
Author
K. Adam White <[email protected]> 2020-02-11 03:20:05 +0000
REST API: Match REST API routes on namespace before performing regex checks.
Rule out groups of API endpoints by simple namespace string comparison to reduce the number of regex checks necessary when matching a route.

Props TimothyBlynJacobs.
Fixes #48530.
No action taken yet
git: 3125c21
svn: r47259
2 of 3404
Author
azaozz <[email protected]> 2020-02-11 03:18:02 +0000
Media: Improve wording for error message on failed post-processing of uploaded images.
Props eclev91, desrosj, antpb, azaozz.
Fixes #49280.
No action taken yet
git: d06637f
svn: r47258
3 of 3404
Author
K. Adam White <[email protected]> 2020-02-11 01:58:08 +0000
REST API: List all core theme feature support details in /themes endpoint response.
Fully list which first-party core theme features are supported in the /themes endpoint response. This brings the REST API themes controller's response more in line with the output of get_theme_support().

Props adamboro, apieschel, koke, spacedmonkey, TimothyBlynJacobs.
See #49037.
No action taken yet
git: b364e2a
svn: r47257
4 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-11 01:45:01 +0000
Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background.
Props bahia0019.
Fixes #49237.
No action taken yet
git: d9c6c5e
svn: r47256
5 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-11 01:19:55 +0000
Administration: Move `.has-row-actions` class in Recent Comments dashboard widget next to `.dashboard-comment-wrap`, for consistency.
Follow-up to [47255].

See #42938.
No action taken yet
git: 196fc7a
svn: r47255
6 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-11 01:15:31 +0000
Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen.
Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938.
No action taken yet
git: 8650885
svn: r47254
7 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-11 00:39:11 +0000
Site Health: Improve the wording for PHP update recommendations.
Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov.
Fixes #48716.
No action taken yet
git: 49d8c4e
svn: r47253
8 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-11 00:18:28 +0000
Docs: Improve documentation for `tests/phpunit/includes/spy-rest-server.php`.
Props andizer.
Fixes #47567.
No action taken yet
git: 22ca3c5
svn: r47252
9 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-11 00:05:01 +0000
Comments: Improve the appearance of the Status box on Edit Comment screen.
This makes the box more consistent with the Publish meta box in classic editor.

Props birgire, nfmohit, melchoyce, afercia.
Fixes #43587.
No action taken yet
git: 45cb25d
svn: r47251
10 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 23:45:50 +0000
Media: In `media_sideload_image()`, store the original attachment URL in the `_source_url` post meta value.
Props dshanske, joemcgill, antpb.
Fixes #48164.
No action taken yet
git: f558f5f
svn: r47250
11 of 3404
Author
Jorge Costa <[email protected]> 2020-02-10 22:31:13 +0000
Block Editor: Update WordPress Packages; Remove navigation block; Add social links block
The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0
The navigation block inclusion was reverted.
The social links block was included.

Props gziolo, youknowriad, mcsf, noisysocks.
Fixes #49397.
No action taken yet
git: de5d82f
svn: r47249
12 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 22:01:49 +0000
Docs: Improve documentation for the `$attr` parameter of `wp_get_attachment_image()`.
Props juanfra, Mte90, DrewAPicture, joemcgill, SergeyBiryukov.
Fixes #36661.
No action taken yet
git: 0c07311
svn: r47248
13 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 21:36:53 +0000
Coding Standards: Fix JSHint issues in [47246].
See #44264.
No action taken yet
git: 7a7c3c6
svn: r47247
14 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 21:13:08 +0000
Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.
With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.
No action taken yet
git: a6a02ea
svn: r47246
15 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 20:17:58 +0000
Privacy: Give progress indication for export and erasure.
This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data.

Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire.
Fixes #44264.
No action taken yet
git: c0c2fd3
svn: r47245
16 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 19:55:51 +0000
Privacy: Rename `wp_get_user_request_data()` to `wp_get_user_request()` for clarity; deprecate the old function.
The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property.

Follow-up to [44606].

Props garrett-eclipse.
Fixes #46302.
No action taken yet
git: d4475d5
svn: r47244
17 of 3404
Author
Ian Belanger <[email protected]> 2020-02-10 19:23:38 +0000
Bundled Themes: Twenty Twenty post navigation links outside of the container.
Fixes a bug where the in-page pagination does not align within the inner container.

Props ataurr, audrasjb, mukesh27.
Fixes #48979.
No action taken yet
git: a604bba
svn: r47243
18 of 3404
Author
Ian Belanger <[email protected]> 2020-02-10 19:10:21 +0000
Bundled Themes: Twenty Twenty add WhatsApp to the social icon menu.
This adds WhatsApp as an option in the social icon menu.

Props rryyaanndd, audrasjb.
Fixes #49098.
No action taken yet
git: f160d6a
svn: r47242
19 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 19:05:17 +0000
Twenty Nineteen: Add the missing `inc/helper-functions.php` file.
Follow-up to [47214].

Props kjellr, jffng.
Fixes #45984.
No action taken yet
git: d56903d
svn: r47241
20 of 3404
Author
Ian Belanger <[email protected]> 2020-02-10 18:23:29 +0000
Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile.
Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.

Props JarretC.
Fixes #49254.
No action taken yet
git: 437ac63
svn: r47240
21 of 3404
Author
Jorge Costa <[email protected]> 2020-02-10 17:50:36 +0000
Block Editor: Backport inclusion of new editor settings to the core.
This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107, and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/.

Props: youknowriad, ryelle.
Fixes #49389.
No action taken yet
git: e739911
svn: r47239
22 of 3404
Author
Timothy Jacobs <[email protected]> 2020-02-10 16:06:58 +0000
REST API: Add support for the REDIRECT_HTTP_AUTHORIZATION header.
Previously the REST API did not account for server configurations where the Authorization header must be added using ModRewrite. This caused major DUX issues when trying to use custom authentication mechanisms.

Fixes #47077.
Props dshanske, cklosows.
No action taken yet
git: 2c79528
svn: r47238
23 of 3404
Author
Andrew Duthie <[email protected]> 2020-02-10 15:15:07 +0000
Script Loader: Add polyfill for window.URL, window.DOMRect.
Pending block editor revisions for WordPress 5.4 will make use of `window.URL` and `window.DOMRect`. These are not available in Internet Explorer (or pre-Chromium Edge for `DOMRect`) and must be polyfilled to avoid script errors.

The changes make use of the existing polyfill pattern, and existing `polyfill-library` dependency. The dependency is bumped to the latest version, since the previous version did not include the `DOMRect` polyfill.

Props jorgefilipecosta.
Fixes #49360.
No action taken yet
git: 5b0be97
svn: r47237
24 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 05:42:52 +0000
Privacy: Include session tokens in Personal Data Export.
Session tokens contain an IP address and user agent.

Props garrett-eclipse, nickylimjj, lakenh, xkon, rconde.
Fixes #45889.
No action taken yet
git: 8fef1b2
svn: r47236
25 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 05:30:03 +0000
Privacy: Include `community-events-location` user meta value in Personal Data Export.
The value is used by the WordPress Events and News widget to show relevant WP community events.

The location information may include an IP address, location description, and latitude/longitude coordinates.

Props garrett-eclipse, coreymckrill, xkon.
Fixes #43921.
No action taken yet
git: d321144
svn: r47235
26 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 05:14:18 +0000
Site Health: Move the warning about `WP_DEBUG_LOG` being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory.
Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon.
Fixes #47985.
No action taken yet
git: acb845d
svn: r47234
27 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 04:56:01 +0000
Administration: Standardize "found in Trash" messages.
Props Presskopp, audrasjb.
Fixes #38669.
No action taken yet
git: 023d4b2
svn: r47233
28 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 04:10:09 +0000
Administration: Capitalize `Trash` consistently in various messages and comments.
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317.
No action taken yet
git: 5302cd6
svn: r47232
29 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 03:48:45 +0000
Login and Registration: Clarify the message on "Lost Password" screen.
Props pbiron, Presskopp.
Fixes #49346.
No action taken yet
git: 924b49c
svn: r47231
30 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 03:32:57 +0000
Docs: Add documentation for globals in `wp-settings.php`.
Props chinteshprajapati.
Fixes #46253.
No action taken yet
git: c80af90
svn: r47230
31 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 03:28:20 +0000
Docs: Add descriptions for some globals:
* `$wp_version`
* `$wp_local_package`
* `$required_php_version`
* `$required_mysql_version`

See #48303.
No action taken yet
git: 6fd606d
svn: r47229
32 of 3404
Author
Andrew Ozz <[email protected]> 2020-02-10 02:52:12 +0000
Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image.
Fixes #49262.
No action taken yet
git: b39db8c
svn: r47228
33 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 02:27:23 +0000
Editor: Add unique classes to `.post-attributes-label-wrapper` paragraphs for easier JS or CSS targeting.
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408.
No action taken yet
git: dabec45
svn: r47227
34 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 02:10:52 +0000
Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins.
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.

See #meta4706 for the corresponding WordPress.org API change.

Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994. See #21307.
No action taken yet
git: 37a83d5
svn: r47226
35 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-10 01:50:33 +0000
Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure.
Props markjaquith, valentinbora.
Fixes #48490.
No action taken yet
git: 89dfd40
svn: r47225
36 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-09 21:20:25 +0000
Build/Test Tools: Expose port 3306 of MySQL container.
This only defines the container port to allow `docker-compose` to choose an ephemeral host port.

Props ocean90, peterwilsoncc.
Fixes #48281.
No action taken yet
git: 98e5dd5
svn: r47224
37 of 3404
Author
Timothy Jacobs <[email protected]> 2020-02-09 20:52:06 +0000
REST API: Introduce selective link embedding.
Previously the _embed flag would embed all embeddable links in a response even if only a subset of the links were necessary. Now, a list of link relations can be passed in the _embed parameter to restrict the list of embedded objects.

Props rheinardkorf, adamsilverstein, jnylen0, cklosows, chrisvanpatten, TimothyBlynJacobs.
Fixes #39696.
No action taken yet
git: c647007
svn: r47223
38 of 3404
Author
Aaron Jorbin <[email protected]> 2020-02-09 20:42:26 +0000
General: Fix HTML for get_calendar()
The <tfoot> element was allowed to precede the <tbody> element in HTML 5. However, that was changed in HTML 5.1 and <tfoot> must now follow <tbody>.

This removes the tfooot and instead uses a nav element for navigation between months.

Fixes: #39763
Props: isabel_brison, Harry Milatz, audrasjb, abhijitrakas, SergeyBiryukov
No action taken yet
git: 1d7cdbe
svn: r47222
39 of 3404
Author
Joe Dolson <[email protected]> 2020-02-09 19:39:54 +0000
Editor: Fix incorrect usage of ID attributes on custom fields.
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. 

Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964.
No action taken yet
git: 3fb063f
svn: r47221
40 of 3404
Author
Joe Dolson <[email protected]> 2020-02-09 18:24:41 +0000
Toolbar: Load toolbar in `wp_body_open` when available.
For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook `wp_body_open` (5.2) fixes a long-standing source order problem.

Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes #47053.
No action taken yet
git: 8cbfdba
svn: r47220
41 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-09 17:06:55 +0000
Coding Standards: Correct the `get_plugin_page_hook()` check in `wp-admin/admin.php`.
The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected.

Follow-up to [47218].

See #48455, #49222.
No action taken yet
git: 130751c
svn: r47219
42 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-09 16:52:28 +0000
Coding Standards: Use Yoda conditions where appropriate.
See #49222.
No action taken yet
git: 40ffe0e
svn: r47218
43 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-09 16:51:22 +0000
Coding Standards: Use Yoda conditions in some `wp-admin` files.
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.
No action taken yet
git: 43fb407
svn: r47217
44 of 3404
Author
Andrea Fercia <[email protected]> 2020-02-09 16:30:41 +0000
Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order.
Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.

Propos syhc, audrasjb, afercia.
See #37188.
Fixes #48403.
No action taken yet
git: 734bf72
svn: r47216
45 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-09 04:53:29 +0000
Embeds: Add support for TikTok.
Props audrasjb, jblz, peterwilsoncc, felipeloureirosantos.
Fixes #49083.
No action taken yet
git: ca37df8
svn: r47215
46 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-08 20:08:31 +0000
Site Health: Only get MySQL server information in tests where it's actually needed.
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.

Props xkon, Otto42, Clorith.
See #47606.
No action taken yet
git: 95f3bdb
svn: r47214
47 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-08 12:59:44 +0000
Twenty Nineteen: Improve code organization in `template-functions.php` by moving helper functions into their own file.
These functions are moved to `inc/helper-functions.php`:

* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`

Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.

Props akshayar, allancole, grapplerulrich.
Fixes #45984.
No action taken yet
git: 1f8531c
svn: r47213
48 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-08 12:47:33 +0000
Menus: When adding a label for special pages in `wp_setup_nav_menu_item()`, check if `get_post_states()` is available, to avoid fatal errors on front end.
Fixes #49374.
No action taken yet
git: 2aecc8f
svn: r47212
49 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-08 05:29:54 +0000
Tests: Add a basic test for `wp()` function.
Props pbearne, donmhico.
Fixes #48844.
No action taken yet
git: 11eb80e
svn: r47211
50 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-07 23:44:22 +0000
Menus: Use `get_post_states()` to denote special pages on the added menu item accordions.
Front Page, Posts Page, or Privacy Policy Page should now be marked as such on the added menu items.

Props garrett-eclipse.
Fixes #49374.
No action taken yet
git: dce15b9
svn: r47210
51 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-07 23:28:22 +0000
Docs: Improve description for the `$editor_id` parameter of `wp_editor()` and `_WP_Editors::editor()`.
The restictions mentioned for the parameter value should be consistenct.

Props pbiron, SergeyBiryukov.
Fixes #49384.
No action taken yet
git: 23c2257
svn: r47209
52 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-07 21:36:59 +0000
Accessibility: Menus: Make tab panels in `Add menu items` section more accessible for keyboard users.
Props audrasjb, afercia.
Fixes #49211.
No action taken yet
git: 6c7f322
svn: r47208
53 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-07 21:09:39 +0000
Accessibility: Customize: Improve focus styles for color picker and media upload button in Customizer.
Props audrasjb, timhavinga, afercia, karmatosed.
Fixes #48694.
No action taken yet
git: f8b2ff1
svn: r47207
54 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-07 19:14:29 +0000
Coding Standards: Adjust coding standards to always omit parentheses for `include`/`require` statements.
These are language constructs, not function calls, so the parentheses are unnecessary.

This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream.

Follow-up to [47198].

Props desrosj, jrf, GaryJ.
Fixes #49376.
No action taken yet
git: 2ce61ea
svn: r47206
55 of 3404
Author
John Blackbourn <[email protected]> 2020-02-07 17:51:09 +0000
Posts, Post Types: Add a parameter to the `post_locked_dialog` action which contains a reference to the user who holds the lock.
Fixes #48443
No action taken yet
git: c7caac7
svn: r47205
56 of 3404
Author
John Blackbourn <[email protected]> 2020-02-07 17:46:51 +0000
Taxonomy: Clarify the docs for the return values of the `term_exists()` function.
Props dotancohen, sathyapulse

Fixes #43345
No action taken yet
git: 1feff0d
svn: r47204
57 of 3404
Author
John Blackbourn <[email protected]> 2020-02-07 17:40:29 +0000
Script Loader: Fix a docblock so it points to the correct page on the developer reference.
Props joyously, pbiron

Fixes #48503
No action taken yet
git: 7efcf03
svn: r47203
58 of 3404
Author
John Blackbourn <[email protected]> 2020-02-07 17:31:52 +0000
Posts, Post Types: Introduce a filter which allows the addition of `__trashed` suffixes on post slugs to be skipped.
Fixes #46433
No action taken yet
git: 112649e
svn: r47202
59 of 3404
Author
Andrew Ozz <[email protected]> 2020-02-07 05:11:45 +0000
Media: Add link to the original image in the image properties if it was scaled or rotated after uploading.
Fixes #49290.
No action taken yet
git: f91e983
svn: r47201
60 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-06 21:49:13 +0000
Tests: Revert the `dirname( __FILE__ )` replacement in `wp-tests-config-sample.php` for now, to avoid breaking unit tests created with WP-CLI `scaffold` command.
Follow-up to [47198].

Props kaggdesign, danielbachhuber, bwmarkle.
Fixes #48082, #49377.
No action taken yet
git: 3096571
svn: r47200
61 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-06 21:40:05 +0000
Tests: Change a few remaining `include_once` statements to `require_once`, for consistency.
See #48082.
No action taken yet
git: 8640eaa
svn: r47199
62 of 3404
Author
Jorge Costa <[email protected]> 2020-02-06 21:01:16 +0000
Block Editor: Update WordPress Packages.
The following package versions were changed:
@wordpress/a11y: 2.6.0 -> 2.7.0
@wordpress/annotations: 1.10.0 -> 1.11.0
@wordpress/api-fetch: 3.9.0 -> 3.10.0
@wordpress/autop: 2.5.1 -> 2.6.0
@wordpress/blob: 2.6.0 -> 2.7.0
@wordpress/block-directory: 1.3.0 -> 1.4.0
@wordpress/block-editor: 3.5.0 -> 3.6.0
@wordpress/block-library: 2.12.0 -> 2.13.0
@wordpress/block-serialization-default-parser: 3.4.1 -> 3.5.0
@wordpress/blocks: 6.10.0 -> 6.11.0
@wordpress/components: 9.0.0 -> 9.1.0
@wordpress/compose: 3.10.0 -> 3.11.0
@wordpress/core-data: 2.10.0 -> 2.11.0
@wordpress/custom-templated-path-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/data: 4.12.0 -> 4.13.0
@wordpress/data-controls: 1.6.0 -> 1.7.0
@wordpress/date: 3.7.0 -> 3.8.0
@wordpress/dependency-extraction-webpack-plugin: 2.1.0 -> 2.2.0
@wordpress/deprecated: 2.6.1 -> 2.7.0
@wordpress/dom: 2.7.0 -> 2.8.0
@wordpress/dom-ready: 2.6.0 -> 2.7.0
@wordpress/e2e-test-utils: 4.1.0 -> 4.2.0
@wordpress/edit-post: 3.11.0 -> 3.12.0
@wordpress/editor: 9.10.0 -> 9.11.0
@wordpress/element: 2.10.0 -> 2.11.0
@wordpress/escape-html: 1.6.0 -> 1.7.0
@wordpress/format-library: 1.12.0 -> 1.13.0
@wordpress/hooks: 2.6.0 -> 2.7.0
@wordpress/html-entities: 2.5.0 -> 2.6.0
@wordpress/i18n: 3.8.0 -> 3.9.0
@wordpress/is-shallow-equal: 1.7.0 -> 1.8.0
@wordpress/keyboard-shortcuts: 0.2.0 -> 1.0.0
@wordpress/keycodes: 2.8.0 -> 2.9.0
@wordpress/library-export-default-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/list-reusable-blocks: 1.11.0 -> 1.12.0
@wordpress/media-utils: 1.5.0 -> 1.6.0
@wordpress/notices: 1.11.0 -> 1.12.0
@wordpress/nux: 3.10.0 -> 3.11.0
@wordpress/plugins: 2.10.0 -> 2.11.0
@wordpress/priority-queue: 1.4.0 -> 1.5.0
@wordpress/redux-routine: 3.6.2 -> 3.7.0
@wordpress/rich-text: 3.10.0 -> 3.11.0
@wordpress/scripts: 6.2.0 -> 7.0.0
@wordpress/server-side-render: 1.6.0 -> 1.7.0
@wordpress/shortcode: 2.5.0 -> 2.6.0
@wordpress/token-list: 1.8.0 -> 1.9.0
@wordpress/url: 2.9.0 -> 2.10.0
@wordpress/viewport: 2.11.0 -> 2.12.0
@wordpress/wordcount: 2.6.2 -> 2.7.0
Added these new packages:
@wordpress/warning
@wordpress/primitives
@wordpress/icons
Re-added keyboard-shortcuts to script loader removed by mistake on revision 47198.

Props gziolo, itsjonq, youknowriad, mcsf, andraganescu.
Fixes #49358.
No action taken yet
git: e72fff9
svn: r47198
63 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-06 06:31:22 +0000
Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
No action taken yet
git: b02e49c
svn: r47197
64 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-06 05:51:58 +0000
Coding Standards: Move `WP_Object_Cache` to `wp-includes/class-wp-object-cache.php`.
This ensures the file containing the `WP_Object_Cache` class conforms to the coding standards.

For backward compatibility, the new file is included from `wp-includes/cache.php`.

Fixes #49373. See #49222.
No action taken yet
git: 011962f
svn: r47196
65 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 22:38:11 +0000
Posts, Post Types: Add default `menu_icon` values for built-in post types.
This allows the icons to be retrieved via `get_post_type_object()`.

Props m.usama.masood, michael.ecklund, SergeyBiryukov.
Fixes #38844.
No action taken yet
git: 56e4630
svn: r47195
66 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 22:05:50 +0000
Tests: In `Tests_dbDelta`, only force MyISAM database engine on MySQL versions older than 5.7.
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.

Follow-up to [47193], which addressed the issue in `Tests_dbDelta::setUp()`, but missed other tests.

Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367.
No action taken yet
git: 3d43f46
svn: r47194
67 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 19:07:33 +0000
Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image".
This makes it more consistent with other UI elements in the block editor.

Props mcsf.
Fixes #49371.
No action taken yet
git: ddf2d5a
svn: r47193
68 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 18:19:11 +0000
Tests: In `Tests_dbDelta::setUp()`, only force MyISAM database engine on MySQL versions older than 5.7.
Since MySQL 5.7, InnoDB engine supports `FULLTEXT` indexes, so forcing MyISAM is unnecessary.

Props xkon, joonasvanhatapio, SergeyBiryukov.
Fixes #49367.
No action taken yet
git: 90a8a6a
svn: r47192
69 of 3404
Author
Ian Belanger <[email protected]> 2020-02-05 15:00:40 +0000
Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla).
Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.

Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970.
No action taken yet
git: 616e4ff
svn: r47191
70 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 08:08:37 +0000
Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block.
Props audrasjb, jeroenrotty.
Fixes #48120.
No action taken yet
git: 5a5c192
svn: r47190
71 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 07:41:08 +0000
Menus: Introduce `wp_nav_menu_item_custom_fields` action that fires just before the move buttons of a nav menu item in the menu editor.
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056. See #38904, #18584.
No action taken yet
git: f838035
svn: r47189
72 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 07:23:25 +0000
Docs: Correct type for `$item` and $args` parameters in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` to match the parent `Walker_Nav_Menu` class.
Follow-up to [38559], [45537].

See #24587, #48303.
No action taken yet
git: 95b89c5
svn: r47188
73 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 06:41:13 +0000
Site Health: Improve focus style for accordion items on Site Health screens.
The new style is more consistent with other elements like `.wp-core-ui` buttons.

Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578.
No action taken yet
git: 658ff7a
svn: r47187
74 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 06:31:05 +0000
Docs: Add a `@since` note for [47186].
See #48558.
No action taken yet
git: e4d8eac
svn: r47186
75 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 06:24:16 +0000
Taxonomy: In `register_taxonomy()`, return the registered taxonomy object on success, for consistency with `register_post_type()`.
Props krynes, SergeyBiryukov.
Fixes #48558.
No action taken yet
git: 6c00aba
svn: r47185
76 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 05:01:55 +0000
Coding Standards: Fix WPCS issue in [47184].
See #49344.
No action taken yet
git: 629b9a7
svn: r47184
77 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 04:28:13 +0000
Tests: Allow `dbDelta()` tests to (mostly) run on MySQL 8.0.11+.
* MySQL 8.0.11 changed the `GeometryCollection` data type name to `GeomCollection`, with the latter being the preferred name.
* MySQL 8.0.17 removed support for the display width attribute for integer data types. Previously, default display width of 20 digits was used: `BIGINT(20)`.

The affected tests now check the MySQL server version and use the appropriate data types.

This leaves one unresolved failure on MySQL 8.0.17+ to be addressed in the future, caused by the same `BIGINT` display width discrepancy coming from `wp_get_db_schema()`.

Props kaggdesign, ottok, jeremyfelt, SergeyBiryukov.
Fixes #44384, #49344. See #49364.
No action taken yet
git: b34f289
svn: r47183
78 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 03:28:33 +0000
Tests: Allow `wpdb::set_sql_mode()` tests to run on MySQL 8.0.11+.
MySQL 8.0.11 removed support for the `NO_AUTO_CREATE_USER` SQL mode, which was used in as an example of a mode compatible with WordPress.

`NO_AUTO_VALUE_ON_ZERO` is now used in the affected tests instead, which is supported on both MySQL 5.7.x and 8.0.x.

Props kaggdesign, jeremyfelt, afragen.
Fixes #44586. See #49344.
No action taken yet
git: 1fa5058
svn: r47182
79 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 03:12:14 +0000
Docs: Clarify that `is_page_template()` accepts a template filename, not the `Template Name` file header.
Props mkaz.
Fixes #49362.
No action taken yet
git: 5e8563e
svn: r47181
80 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-05 01:31:38 +0000
Posts, Post Types: Fail gracefully when checking whether a single post with an unregistered post status should be displayed in `WP_Query::get_posts()`.
If the post status is not registered, assume it's not public, but still allow access to users with edit permissions (same as for a protected post status, e.g. `draft`), so that they could recover orphaned content.

Add unit tests.

Follow-up to [47178].

Props roytanck, SergeyBiryukov.
Fixes #48653.
No action taken yet
git: 5ada288
svn: r47180
81 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 23:00:53 +0000
Posts, Post Types: Revert [47179] pending test failures investigation.
See #48653.
No action taken yet
git: 9e5c22a
svn: r47179
82 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 22:20:25 +0000
Posts, Post Types: Fail gracefully when checking whether the post should be displayed in `WP_Query::get_posts()` against unregistered post status.
If the post status is not registered, assume it's not public.

Follow-up to [47178].

Props roytanck.
See #48653.
No action taken yet
git: 6f15251
svn: r47178
83 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 22:13:15 +0000
Posts, Post Types: Fail gracefully when checking mapped cap against unregistered post status.
With `map_meta_cap` enabled for a post type, the `read_post` capability for posts with a public status is supposed to be mapped to the post type's `read` capability.

When a post is left in the database after the post status is no longer present, and WP does a `read_post` check against it, a PHP notice was thrown, and the cap check always failed.

As a more graceful fallback, the cap is now mapped onto `edit_others_posts`, which allows highly privileged users to be able to access orphaned content.

A `_doing_it_wrong()` notice is also added, so that developers and site administrators are aware that the cap mapping is failing in the absence of the registered post status.

Follow-up to [34091], which introduced a similar approach to checking mapped caps against an unregistered post type.

Props roytanck, SergeyBiryukov.
Fixes #48653.
No action taken yet
git: 0bfacbe
svn: r47177
84 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 21:40:27 +0000
Coding Standards: Fix WPCS issues in [47175].
See #49361.
No action taken yet
git: 4bcf9be
svn: r47176
85 of 3404
Author
Jorge Costa <[email protected]> 2020-02-04 20:14:50 +0000
Block Editor: Include navigation block server logic.
Core did not include the navigation block PHP files.
This commit fixes the issue referred, and now the navigation block is executed on the frontend. The block still does not work as expected and throws an error during frontend execution. That problem is going to be fixed on the next WordPress package update.
This commit adds the file as it is on the npm package used.

Props gziolo.
Fixes #49348.
No action taken yet
git: 664e5a7
svn: r47175
86 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 19:41:41 +0000
Users: Pass the `$reassign` parameter to the `remove_user_from_blog` action.
Props Tivus.
Fixes #49361.
No action taken yet
git: 8f3f181
svn: r47174
87 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 19:38:12 +0000
Docs: Improve description for `add_user_to_blog()` and `remove_user_from_blog()` parameters.
See #48303.
No action taken yet
git: 2c8da49
svn: r47173
88 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 19:34:27 +0000
Users: In `remove_user_from_blog()`:
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.

See #49361.
No action taken yet
git: e876090
svn: r47172
89 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 16:41:46 +0000
TinyMCE: Remove duplicate keys and strings from `langs/wp-langs-en.js`.
Props david.binda.
Fixes #49359.
No action taken yet
git: b26b0cc
svn: r47171
90 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-04 01:12:53 +0000
Database: Add `ANSI` to the list of incompatible SQL modes.
Starting with MySQL 5.7.5, the `ANSI` mode implies `ONLY_FULL_GROUP_BY`, which is already listed in `wpdb` as incompatible per [27072].

When `ANSI` is enabled on MySQL 5.7.5+, `ONLY_FULL_GROUP_BY` remains enabled even after being "unset" by `wpdb::set_sql_mode()`.

To prevent this, the `ANSI` mode should also be listed as incompatible. It is not enabled on default MySQL installations.

Props jnylen0.
Fixes #48377.
No action taken yet
git: ec83cd0
svn: r47170
91 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-03 00:17:38 +0000
Docs: Improve documentation for `WP_Dependencies`, `WP_Scripts`, and `WP_Styles` methods.
See #48303.
No action taken yet
git: dd48b7f
svn: r47169
92 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-03 00:12:22 +0000
Canonical: When removing trailing punctuation from query string arguments, match the whole query var name.
Props daveslaughter.
Fixes #49347.
No action taken yet
git: 84f4d42
svn: r47168
93 of 3404
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2020-02-02 19:17:07 +0000
Build: Copy block metadata files for dynamic blocks.
For dynamic blocks, there are several blocks whose metadata needs to be loaded in PHP. The attributes that are loaded via PHP are not exposed to the ReactNative components when Gutenberg loads the index.js files in the Mobile Apps. To support one master set of metadata that can be used to register in the PHP files and the Javascript files; with this patch, the block.json files are copied over with their corresponding PHP files.

Props chipsnyder and azaozz.

Fixes #49196.
No action taken yet
git: 3f050fc
svn: r47167
94 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 15:48:37 +0000
Plugins: Remove obsolete `plugin_slugs` transient from `WP_Plugins_List_Table::prepare_items()`.
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].

The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.

Props aftabmuni.
Fixes #49340.
No action taken yet
git: 7802901
svn: r47166
95 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 05:39:29 +0000
REST API: Merge "not allowed to create new terms" permission error message with an existing string.
Follow-up to [39309], [39313].

See #38857.
No action taken yet
git: 4e6674c
svn: r47165
96 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 05:32:35 +0000
Docs: Fix typo in a comment with `WP_DEBUG_DISPLAY` description.
See #48303.
No action taken yet
git: 706daca
svn: r47164
97 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 04:13:25 +0000
Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
The original script was deprecated in [30338] and removed in [32677].

Props Presskopp, ketuchetan.
Fixes #39448.
No action taken yet
git: 63a53c7
svn: r47163
98 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 04:07:50 +0000
Tests: Adjust XML-RPC unit tests for [47160].
Follow-up to [47162].

See #40096.
No action taken yet
git: d5572e9
svn: r47162
99 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 03:30:37 +0000
Tests: Adjust XML-RPC unit tests for [47160].
See #40096.
No action taken yet
git: 73e7519
svn: r47161
100 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 03:25:57 +0000
Docs: Add more specific description for `WP_Http::processResponse()` return value.
Props marekdedic, takeshifurusato.
Fixes #48351.
No action taken yet
git: fd3083e
svn: r47160
101 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 03:06:31 +0000
Post Thumbnails: Make sure `get_post_thumbnail_id()` returns an integer, to match the documented return value.
This makes the function more consistent with `get_the_ID()` or `wp_get_post_parent_id()`, both returning an integer.

Props 0v3rth3d4wn.
Fixes #40096.
No action taken yet
git: 139fe26
svn: r47159
102 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-02 02:40:50 +0000
Docs: Improve inline comments in `wp-admin/options.php` per the documentation standards.
See #48303.
No action taken yet
git: 84f0321
svn: r47158
103 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 22:40:06 +0000
Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.
Props tdlewis77, williampatton.
Fixes #42941.
No action taken yet
git: 5e11891
svn: r47157
104 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 21:59:14 +0000
Docs: Correct DocBlock formatting for `register_setting()`.
Document the full list of whitelisted option key names.

See #48303.
No action taken yet
git: 54c6311
svn: r47156
105 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 21:36:44 +0000
Accessibility: Text Changes: Use sentence case for the word `Error` in various error messages, instead of all caps.
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.

Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656, #43037, #42945.
No action taken yet
git: 097f272
svn: r47155
106 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 21:11:08 +0000
Tests: Update the expected message in `test_with_draft_post()`.
Follow-up to [47154].

See #42945.
No action taken yet
git: b3da2c9
svn: r47154
107 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 20:53:14 +0000
Text Changes: Capitalize error messages consistently.
Props Presskopp.
Fixes #42945.
No action taken yet
git: db8a038
svn: r47153
108 of 3404
Author
Sergey Biryukov <sergeybir[email protected]> 2020-02-01 20:30:20 +0000
Text Changes: Add missing periods to some error messages, for consistency.
Props Presskopp.
Fixes #42735.
No action taken yet
git: 9e8a729
svn: r47152
109 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 20:27:28 +0000
Text Changes: Add missing periods to comment status update notices, for consistency.
Props Presskopp.
See #42735.
No action taken yet
git: 3b2ba4c
svn: r47151
110 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 17:36:35 +0000
Networks and Sites: Reduce `max-width` for user and site search inputs on Dashboard screen in Network Admin.
This ensures that the inputs don't push the buttons to the next line.

Props williampatton, bordoni.
Fixes #49043.
No action taken yet
git: d4b892f
svn: r47150
111 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 04:15:15 +0000
Docs: Document the addition of `$json_report_pathname` parameter to the `wp_privacy_personal_data_export_file_created` action.
Follow-up to [47146].

Props xkon.
Fixes #49029.
No action taken yet
git: 637b6f5
svn: r47149
112 of 3404
Author
Sergey Biryukov <[email protected]> 2020-02-01 00:37:14 +0000
Site Health: Rename `WP_Site_Health::initialize()` introduced in [47063] to `::get_instance()`, for clarity and consistency with other core classes.
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.

Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606.
No action taken yet
git: f0b830e
svn: r47148
113 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 03:41:06 +0000
Privacy: Clarify bulk action labels for personal data export and removal requests.
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674.
No action taken yet
git: df755ff
svn: r47147
114 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 03:24:00 +0000
Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide.
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.

Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov.
Fixes #44621. See #47327.
No action taken yet
git: b894d86
svn: r47146
115 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 01:34:17 +0000
Privacy: Introduce a JSON file into the personal data export.
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.

Props xkon.
Fixes #49029. See #46424.
No action taken yet
git: 13a9ab7
svn: r47145
116 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 01:15:32 +0000
Site Health: Add support for required WordPress and PHP versions to themes.
Follow-up to [45546] for plugins.

Props flixos90, afragen.
Fixes #44592. See #40934, #meta3718.
No action taken yet
git: 7192a8f
svn: r47144
117 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 00:56:29 +0000
Privacy: Remove user's email address from personal data export filename.
Use `wp_unique_filename()` to avoid potential collisions instead.

Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav.
Fixes #44197.
No action taken yet
git: 8b5b3bb
svn: r47143
118 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 00:26:37 +0000
Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens.
Props kinjaldalwadi, donmhico.
Fixes #49235.
No action taken yet
git: ac6409a
svn: r47142
119 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 00:20:47 +0000
HTTP API: Add some basic tests for `wp_remote_fopen()`.
Props pbearne, donmhico.
Fixes #48845.
No action taken yet
git: 8ba94ec
svn: r47141
120 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 00:14:07 +0000
Tests: Rename `wpValidateBoolean.php` for consistency with other files.
See #30238.
No action taken yet
git: 7d90de1
svn: r47140
121 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-31 00:07:50 +0000
Twenty Nineteen: Remove duplicate `font-size` property.
The theme does not use a `px` fallback for `rem` units anywhere else.

Follow-up to [47053] for Twenty Twenty.

See #49015.
No action taken yet
git: df1c777
svn: r47139
122 of 3404
Author
Ian Belanger <[email protected]> 2020-01-30 21:53:48 +0000
Fixes PHPCS Introduced in [47135].
There was extra whitespace in the previous commit, this removes it.

See #48552
No action taken yet
git: 547a08e
svn: r47138
123 of 3404
Author
K. Adam White <[email protected]> 2020-01-30 20:20:30 +0000
REST API: Reuse previously-generated embedded objects when building collection response.
Store each generated embedded object in a temporary cache when querying for linked resources so that repeated links to the same resource do not trigger repeated queries or processing.

Props TimothyBlynJacobs.
Fixes #48838.
No action taken yet
git: 10a5077
svn: r47136
124 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-30 20:02:46 +0000
Twenty Nineteen: Standardize the Required PHP and Tested Up To headers.
* Remove `WordPress` from `Requires at least` headers.
* Ensure the `Requires at least` and `Requires PHP` headers are present in the `style.css` file.

Follow-up to [46676], which updated `style-rtl.css`, but not `style.scss` or `style.css`.

See #48517.
No action taken yet
git: b651a3c
svn: r47135
125 of 3404
Author
Ian Belanger <[email protected]> 2020-01-30 19:19:37 +0000
Bundled Themes: Twenty Twenty add theme support for responsive embeds.
Adds the call to `responsive-embed` theme support in order to fix issues with facebook embeds not being responsive at certain screen widths.

Props williampatton, nielslange.
Fixes #48552.
No action taken yet
git: a271f98
svn: r47134
126 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-30 19:15:19 +0000
Themes: Replace `&mdash;` with `&ndash;` as a separator between Monday and Friday in theme starter content.
The `ndash` standardly is the "through" indicator for showing inclusive dates and numbers, while the `mdash` is an interruptor and used as an aside.

Props mikejdent, garrett-eclipse.
Fixes #48286.
No action taken yet
git: 363c862
svn: r47133
127 of 3404
Author
Ian Belanger <[email protected]> 2020-01-30 18:26:22 +0000
Bundled Themes: Twenty Twenty content font CSS selector is too important.
This makes the font family selector for `entry-content` less specific and thus easier to override.

Props alexandreb3, larrach, audrasjb.
Fixes #49318.
No action taken yet
git: b30baca
svn: r47124
128 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-29 02:17:41 +0000
Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events.
If an upcoming event spans over several days, this information is now properly reflected in the widget.

Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov.
Fixes #47798.
No action taken yet
git: 7e521e6
svn: r47123
129 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-29 00:54:21 +0000
Docs: Fix typos in `wp-admin/includes/class-pclzip.php`.
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.

Props passoniate, ottok.
Fixes #49163. See #38464.
No action taken yet
git: cfc3b57
svn: r47122
130 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-29 00:43:23 +0000
Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
No action taken yet
git: bd2cd57
svn: r47121
131 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-29 00:36:17 +0000
Docs: Improve DocBlocks in `phpunit/includes/object-cache.php` per the documentation standards.
See #48303.
No action taken yet
git: c9663d7
svn: r47120
132 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-29 00:35:39 +0000
Docs: Improve comments in `js/_enqueues/wp/revisions.js` per the documentation standards.
Props passoniate.
Fixes #49177.
No action taken yet
git: 6bdc961
svn: r47119
133 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-29 00:33:45 +0000
Docs: Improve comments in some `wp-admin` files per the documentation standards.
Follow-up to [47084].

Props passoniate, apedog.
Fixes #49223, #49227.
No action taken yet
git: 48110fa
svn: r47118
134 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-28 00:51:42 +0000
Coding Standards: Disable WPCS warnings for `date_default_timezone_set()` and `current_time( 'timestamp' )` calls in Date/Time tests.
These calls are intentional and required for the tests.

See #49222.
No action taken yet
git: c1abc82
svn: r47117
135 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-27 14:42:37 +0000
Docs: Fix typo in a comment in `js/media/models/attachment.js`.
Props wptoolsdev.
Fixes #49303.
No action taken yet
git: 1160c97
svn: r47116
136 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-27 14:32:00 +0000
Customize: Fix typo in `CustomHeader.prototype.initialize()` DocBlock in `src/js/_enqueues/wp/custom-header.js`.
Props ankitmaru.
Fixes #49301.
No action taken yet
git: 50aa7f9
svn: r47115
137 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-27 14:28:12 +0000
Coding Standards: Use strict comparison in `wp-admin/user/admin.php`.
Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency.

Props rimadoshi.
Fixes #49300.
No action taken yet
git: d5e20d8
svn: r47114
138 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-27 04:31:48 +0000
Comments: Add `In reply to: %s` parent comment link to new comment email notifications.
This information was previously available on the Moderate Comment screen in the admin, but was missing from moderation emails.

Props imath, danieltj, andraganescu, galbaras, SergeyBiryukov.
Fixes #43805. See #43429.
No action taken yet
git: 191f798
svn: r47113
139 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-27 01:04:08 +0000
Docs: Remove extra trailing spaces from `wp_add_privacy_policy_content()` DocBlock to fix WPCS issues, apply minor formatting changes for consistency.
Follow-up to [47112].

See #49282.
No action taken yet
git: 9224e14
svn: r47112
140 of 3404
Author
Andrew Ozz <[email protected]> 2020-01-26 23:00:54 +0000
Privacy: Cleanup `.wp-policy-help` CSS remnants and add back-compat when hiding the tutorial content before copying.
Props garrett-eclipse.
Fixes #49282.
No action taken yet
git: ffb9ef6
svn: r47111
141 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-26 22:27:08 +0000
Comments: Add `In reply to %s.` prefix to child comments in comments feed.
The prefix includes a link to the parent comment and the name of its author.

Props zodiac1978, imath, SergeyBiryukov.
Fixes #43429.
No action taken yet
git: 3e3b98a
svn: r47110
142 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-25 22:04:08 +0000
Twenty Twenty: Remove unnecessary escaping of `get_the_title()` in `comments.php`.
For users with the `unfiltered_html` capability, titles can contain legitimate markup.

The title is filtered on saving, so the content in the database is considered safe.

Props kjellr, joyously, peterwilsoncc.
Fixes #49190.
No action taken yet
git: 8e6c884
svn: r47109
143 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-24 17:18:37 +0000
Docs: Improve documentation for `add_user_to_blog()`, `add_existing_user_to_blog()`, and `add_new_user_to_blog()`.
See #48303.
No action taken yet
git: 67f246b
svn: r47108
144 of 3404
Author
Andrea Fercia <[email protected]> 2020-01-23 12:57:41 +0000
Toolbar: Remove leftover `@since` notations after [46678].
See #19647.
No action taken yet
git: e730334
svn: r47107
145 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-23 00:25:38 +0000
Cache API: Remove `WP_Object_Cache::__destruct()` and `wpdb::__destruct()`.
Originally added in [4686], these constructor/destructor pairings were designed to prevent the objects from being destroyed before shutdown, when output buffers are flushed.

A deeper investigation reveals that this approach didn't quite work as expected and was later made redundant by introducing `wp_ob_end_flush_all()` in [5462].

Props wonderboymusic, nacin, Mte90, SergeyBiryukov.
Fixes #21402.
No action taken yet
git: 1c006d7
svn: r47106
146 of 3404
Author
Jorge Costa <[email protected]> 2020-01-22 22:04:35 +0000
Block Editor: Update WordPress Packages.
The following package versions were changed:
@wordpress/a11y: 2.5.1 -> 2.6.0
@wordpress/annotations: 1.9.0 -> 1.10.0
@wordpress/api-fetch: 3.8.0 -> 3.9.0
@wordpress/blob: 2.5.1 -> 2.6.0
@wordpress/block-directory: 1.2.0 -> 1.3.0
@wordpress/block-editor: 3.4.0 -> 3.5.0
@wordpress/block-library: 2.11.0 -> 2.12.0
@wordpress/blocks: 6.9.0 -> 6.10.0
@wordpress/components: 8.5.0 -> 9.0.0
@wordpress/compose: 3.9.0 -> 3.10.0
@wordpress/core-data: 2.9.0 -> 2.10.0
@wordpress/data: 4.11.0 -> 4.12.0
@wordpress/data-controls: 1.5.0 -> 1.6.0
@wordpress/dom: 2.6.0 -> 2.7.0
@wordpress/dom-ready: 2.5.1 -> 2.6.0
@wordpress/e2e-test-utils: 4.0.0 -> 4.1.0
@wordpress/edit-post: 3.10.0 -> 3.11.0
@wordpress/editor: 9.9.0 -> 9.10.0
@wordpress/format-library: 1.11.0 -> 1.12.0
@wordpress/i18n: 3.7.0 -> 3.8.0
@wordpress/is-shallow-equal: 1.6.1 -> 1.7.0
@wordpress/keycodes: 2.7.0 -> 2.8.0
@wordpress/list-reusable-blocks: 1.10.0 -> 1.11.0
@wordpress/media-utils: 1.4.0 -> 1.5.0
@wordpress/notices: 1.10.0 -> 1.11.0
@wordpress/nux: 3.9.0 -> 3.10.0
@wordpress/plugins: 2.9.0 -> 2.10.0
@wordpress/priority-queue: 1.3.1 -> 1.4.0
@wordpress/rich-text: 3.9.0 -> 3.10.0
@wordpress/scripts: 6.1.1 -> 6.2.0
@wordpress/server-side-render: 1.5.0 -> 1.6.0
@wordpress/viewport: 2.10.0 -> 2.11.0
The following package was added:
@wordpress/keyboard-shortcuts

Props gziolo.
Fixes #49204.
No action taken yet
git: 05a2cd6
svn: r47105
147 of 3404
Author
Ian Dunn <[email protected]> 2020-01-22 20:51:26 +0000
Multisite: Add `$context` parameter to `switch_blog` action.
The action is fired by both `switch_to_blog()` and `restore_current_blog()`, and previously it was difficult for callback functions to determine which function had fired it.

Props SergeyBiryukov, johnbillion, jeremyfelt.
Fixes #49265.
No action taken yet
git: e134804
svn: r47104
148 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-22 00:55:13 +0000
Docs: Expand `@return` value description for `wp_loginout()`, `wp_register()`, `get_calendar()`.
See #48303.
No action taken yet
git: dbe67c4
svn: r47103
149 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-22 00:39:32 +0000
Docs: Expand `@return` description for `the_terms()`.
See #48303.
No action taken yet
git: 8295b56
svn: r47102
150 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-22 00:31:17 +0000
Docs: Correct `@return` value for `parent_dropdown()`.
Follow-up to [47100].

See #48303.
No action taken yet
git: 5db9ef7
svn: r47101
151 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-22 00:23:09 +0000
Docs: Adjust documentation for some `pre_*` filters for consistency.
See #48303.
No action taken yet
git: 8133a24
svn: r47100
152 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-22 00:20:21 +0000
Docs: Adjust `@return` value of `parent_dropdown()` for consistency with other dropdown functions.
See #48303.
No action taken yet
git: 80e4ef4
svn: r47099
153 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-22 00:17:24 +0000
Docs: Correct `@return` value for `update_core()` and `Core_Upgrader::upgrade()`.
See #48303.
No action taken yet
git: af39b30
svn: r47098
154 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-21 23:46:36 +0000
Date/Time: In `wp_maybe_decline_date()`, add support for a range of days, e.g. `February 21–23`.
A potential use case is displaying multi-day events in the WordPress Events and News dashboard widget.

See #47798, #48934.
No action taken yet
git: 1bf8b94
svn: r47097
155 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-21 20:11:11 +0000
Docs: Expand `@return` value description for `wp_nav_menu()`.
See #48303.
No action taken yet
git: 7939118
svn: r47096
156 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-21 15:39:17 +0000
Docs: Correct DocBlock formatting for filters accepting the `$parsed_args` parameter.
Follow-up to [45667].

See #48303.
No action taken yet
git: 8753725
svn: r47095
157 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-21 14:51:00 +0000
I18N: Merge duplicate "you must be logged in to comment" strings.
Props ramiy.
Fixes #49251.
No action taken yet
git: ad2261b
svn: r47094
158 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-21 02:19:04 +0000
I18N: Synchronize MediaElement.js translation strings with the currently bundled version.
Some strings were previously removed in [43345] and accidentally reintroduced in [44163].

Props ramiy.
Fixes #49249. See #42139, #37453.
No action taken yet
git: 9b5ac0f
svn: r47093
159 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-20 15:41:50 +0000
I18N: Add missing placeholders to some translators comments in `wp-admin`.
Props ramiy.
Fixes #49248.
No action taken yet
git: 4940282
svn: r47092
160 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-20 15:08:45 +0000
I18N: Correct translator comment in `wp-admin/options-permalink.php`.
Props ramiy.
Fixes #49247.
No action taken yet
git: 26f27a2
svn: r47091
161 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-20 14:42:12 +0000
I18N: Merge duplicate `%1$s is not of type %2$s` strings in `rest_validate_value_from_schema()`.
Props ramiy.
Fixes #49244.
No action taken yet
git: 8738b08
svn: r47090
162 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-20 14:25:13 +0000
I18N: Remove unnecessary HTML from "Active:" strings in `wp-admin/themes.php`.
Follow-up to [45435].

Props ramiy.
Fixes #49243.
No action taken yet
git: 5f937b4
svn: r47089
163 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-20 14:06:57 +0000
I18N: Correct translator comments in `WP_Users_List_Table::get_views()` to provide information about each placeholder.
Props ramiy.
Fixes #49242.
No action taken yet
git: a8f4ed6
svn: r47088
164 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-20 03:12:12 +0000
Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/.
See #48303.
No action taken yet
git: 88836de
svn: r47087
165 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-19 13:39:21 +0000
Docs: Correct description for `shortcode_atts_{$shortcode}` filter.
Props glebkema.
Fixes #49225.
No action taken yet
git: 480b5c8
svn: r47086
166 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-18 02:30:24 +0000
Mail: Remove angle brackets from password reset URL in emails sent by `retrieve_password()` and `wp_new_user_notification()`.
The brackets were originally added in [16285] per W3C recommendation in https://www.w3.org/Addressing/URL/5.1_Wrappers.html to avoid wrapping the URL across multiple lines in plain text in older email clients.

This doesn't seem like a common issue in modern email clients, and the current implementation causes more issues than it solves. Since the URL is on a line by itself, it should not require any delimiters.

The URL in recovery mode email introduced in [44973] doesn't have angle brackets, so it's time to retire them in password reset email too if they're not used consistently.

Props donmhico, Otto42, sproutchris, iandunn, dd32, DaveWP196, sebastian.pisula, tommix, sablednah, julian.kimmig, Rahe, clayisland, arenddeboer, nicole2292, nagoke, squarecandy, eatingrules, SergeyBiryukov.
Fixes #21095, #23578, #44589.
No action taken yet
git: 5d8f784
svn: r47085
167 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-18 01:13:12 +0000
Networks and Sites: Clarify the recommendation to remove the `www` prefix from the site domain before creating a network.
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.

Props kharisblank, tobifjellner, ramiy.
Fixes #49214.
No action taken yet
git: 89dc54e
svn: r47084
168 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-18 00:52:28 +0000
Docs: Improve comments in some `wp-admin` files per the documentation standards.
Props passoniate.
Fixes #49215, #49216.
No action taken yet
git: bd59d22
svn: r47083
169 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-18 00:24:57 +0000
Coding Standards: Remove unnecessary `// phpcs:ignore` instances in `WP_Debug_Data`.
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.

Additionally, remove one short ternary instance, not allowed per the coding standards.

See #49222.
No action taken yet
git: b02161c
svn: r47082
170 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-17 13:55:22 +0000
Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets.
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195.
No action taken yet
git: 8660569
svn: r47081
171 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-17 02:50:39 +0000
Date/Time: Add some basic tests for `current_time()`.
Props pbearne, talldanwp, SergeyBiryukov.
Fixes #34378.
No action taken yet
git: 0ead760
svn: r47080
172 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-17 02:02:41 +0000
Tests: Replace `date()` with `gmdate()` in `WP_Test_REST_Posts_Controller` tests.
Follow-up to [45424], [46252].

See #46438, #44491, #39953.
No action taken yet
git: a2978ba
svn: r47079
173 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-17 01:14:24 +0000
Tests: Update the `wp_maybe_decline_date()` tests for [47078].
See #48934.
No action taken yet
git: 5bef137
svn: r47078
174 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-17 01:10:57 +0000
Date/Time: Pass the date format to `wp_maybe_decline_date()`.
This ensures that the function has enough context to determine the necessity of replacing the month name with the correct form in locales that require it.

Props SergeyBiryukov, Rarst.
Fixes #48934.
No action taken yet
git: 93b2d5e
svn: r47077
175 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-17 01:08:28 +0000
Tests: Revert [47076], this should have been committed with the related changes to the function.
No action taken yet
git: abfca60
svn: r47076
176 of 3404
Author
SergeyBiryukov <[email protected]49c9-b593-d223f7449a82> 2020-01-17 00:54:02 +0000
Tests: Move `wp_maybe_decline_date()` tests to the `date` directory.
See #48934.
No action taken yet
git: 900b3fd
svn: r47075
177 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-16 03:42:38 +0000
Accessibility: Login and Registration: Add a `role="main"` landmark to the container div in `wp-signup.php`.
Props SteelWagstaff, audrasjb.
Fixes #48657.
No action taken yet
git: 6baa60a
svn: r47074
178 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-16 00:32:56 +0000
Login and Registration: Remove duplicate `<label>` tag from `show_blog_form()` in `wp-signup.php`.
Props vaishalipanchal, audrasjb.
Fixes #49174.
No action taken yet
git: cf0a453
svn: r47073
179 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-16 00:26:08 +0000
Date/Time: Use `wp_date()` to display the correct time of the next DST transition in Timezone setting on General Settings screen.
Props Rarst, autotutorial.
Fixes #49038.
No action taken yet
git: fd479f9
svn: r47072
180 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-15 18:29:11 +0000
Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor.
Props pratik-jain, justinahinon, audrasjb.
Fixes #49115.
No action taken yet
git: fc944f9
svn: r47071
181 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-15 00:21:26 +0000
File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens.
Props passoniate.
Fixes #49197.
No action taken yet
git: 06775e4
svn: r47070
182 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-14 01:09:03 +0000
Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process.
Props garrett-eclipse, audrasjb.
Fixes #49018.
No action taken yet
git: 92fc229
svn: r47069
183 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-13 17:25:26 +0000
Site Health: Avoid "Undefined property" PHP notices in `wp_dashboard_site_health()` when the status result transient does not exist yet.
Props dlh for initial patch.
See #47606.
No action taken yet
git: 5ee2e23
svn: r47068
184 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-13 17:03:39 +0000
Cron API: Use `WEEK_IN_SECONDS` constant for the `weekly` schedule added in [47062].
Props afercia.
See #47606.
No action taken yet
git: d9501dd
svn: r47067
185 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-13 16:58:06 +0000
Networks and Sites: Use `warning` styles for 'Caution' and 'Warning' messages during Multisite installation.
Props dlh.
Fixes #49186.
No action taken yet
git: 14376be
svn: r47066
186 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-13 00:48:27 +0000
Docs: Correct description for `show_in_admin_all_list` and `show_in_admin_status_list` arguments of `register_post_status()`.
Props audrasjb.
Fixes #49180.
No action taken yet
git: 9b38bca
svn: r47065
187 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-12 16:54:56 +0000
Docs: Improve documentation for `wp_save_image_file()` and related functions.
See #48303.
No action taken yet
git: 2daa4b6
svn: r47064
188 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-12 14:16:57 +0000
Tests: In `Tests_Site_Health`, create a `WP_Site_Health` instance before clearing the cron array, as the constructor schedules its own task now.
See #47606.
No action taken yet
git: 396cc82
svn: r47063
189 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-12 13:31:49 +0000
Site Health: Introduce Site Health Status dashboard widget.
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.

Props Clorith, hedgefield, guddu1315.
See #47606.
No action taken yet
git: 5eaf160
svn: r47062
190 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-12 11:18:03 +0000
Cron API: Add a new cron schedule for `weekly` events.
Props Clorith.
See #47606.
No action taken yet
git: eb7bf9c
svn: r47061
191 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-12 02:22:17 +0000
Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation.
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.

Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242.
No action taken yet
git: 4c2ee4e
svn: r47060
192 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-11 18:30:58 +0000
Docs: In various `@return` tags, list the expected type first, instead of `false`.
Follow-up to [46696].

See #48303.
No action taken yet
git: f9e52f8
svn: r47059
193 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-11 17:56:15 +0000
Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables.
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.
No action taken yet
git: 1824604
svn: r47058
194 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-11 17:55:49 +0000
Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`.
Props pbiron.
Fixes #49170.
No action taken yet
git: 5dbe5a8
svn: r47057
195 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-11 02:44:17 +0000
Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`.
Props diddledan.
Fixes #48570.
No action taken yet
git: 4a854cd
svn: r47056
196 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-10 14:03:50 +0000
Docs: Remove a reference to WordPress 2.7 from `readme.html`.
Props afercia, donmhico.
Fixes #47963.
No action taken yet
git: 32ccb24
svn: r47055
197 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-10 00:28:10 +0000
Docs: Remove `@return void` from widget DocBlocks.
Per the documentation standards, it should not be used outside of the default bundled themes.

See #48303.
No action taken yet
git: f243dc3
svn: r47054
198 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-09 00:53:29 +0000
Coding Standards: Use strict comparison and Yoda conditions in the root directory files.
Props pikamander2.
Fixes #48965.
No action taken yet
git: 424071a
svn: r47053
199 of 3404
Author
Jonathan Desrosiers <[email protected]> 2020-01-08 16:48:43 +0000
Bundled Themes: Remove duplicate `font-size` property in Twenty Twenty.
Props ankitmaru.
Fixes #49015.
No action taken yet
git: 90db6f5
svn: r47052
200 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-08 12:08:49 +0000
Docs: Correct alphabetic order of parameters in `WP_Query::parse_query()` DocBlock.
See #48303.
No action taken yet
git: e02ebc1
svn: r47051
201 of 3404
Author
Jorge Costa <[email protected]> 2020-01-08 11:55:03 +0000
Block Editor: Update WordPress Packages.
Updated packages:
@wordpress/annotations: 1.7.2 -> 1.9.0
@wordpress/api-fetch: 3.6.4 -> 3.8.0
@wordpress/block-directory: 1.0.5 -> 1.2.0
@wordpress/block-editor: 3.2.5 -> 3.4.0
@wordpress/block-library: 2.9.6 -> 2.11.0
@wordpress/blocks: 6.7.2 -> 6.9.0
@wordpress/components: 8.3.2 -> 8.5.0
@wordpress/compose: 3.7.2 -> 3.9.0
@wordpress/core-data: 2.7.5 -> 2.9.0
@wordpress/data: 4.9.2 -> 4.11.0
@wordpress/data-controls: 1.3.4 -> 1.5.0
@wordpress/date: 3.5.0 -> 3.7.0
@wordpress/dom: 2.5.2 -> 2.6.0
@wordpress/e2e-test-utils: 3.0.0 -> 4.0.0
@wordpress/edit-post: 3.8.6 -> 3.10.0
@wordpress/editor: 9.7.6 -> 9.9.0
@wordpress/element: 2.8.2 -> 2.10.0
@wordpress/escape-html: 1.5.1 -> 1.6.0
@wordpress/format-library: 1.9.5 -> 1.11.0
@wordpress/i18n: 3.6.1 -> 3.7.0
@wordpress/keycodes: 2.6.2 -> 2.7.0
@wordpress/list-reusable-blocks: 1.8.4 -> 1.10.0
@wordpress/media-utils: 1.2.4 -> 1.4.0
@wordpress/notices: 1.8.2 -> 1.10.0
@wordpress/nux: 3.7.2 -> 3.9.0
@wordpress/plugins: 2.7.2 -> 2.9.0
@wordpress/rich-text: 3.7.2 -> 3.9.0
@wordpress/scripts: 6.0.0 -> 6.1.1
@wordpress/server-side-render: 1.3.4 -> 1.5.0
@wordpress/shortcode: 2.4.1 -> 2.5.0
@wordpress/token-list: 1.6.1 -> 1.8.0
@wordpress/url: 2.8.2 -> 2.9.0
@wordpress/viewport: 2.8.2 -> 2.10.0

Props gziolo, youknowriad.
Fixes #49142.
No action taken yet
git: 7b0f5e5
svn: r47050
202 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-08 11:30:37 +0000
Coding Standards: Use Yoda conditions in `wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php`.
Props jenilk.
Fixes #49150.
No action taken yet
git: 6bf5238
svn: r47049
203 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-08 00:25:04 +0000
Docs: Indicate that `load_script_textdomain_relative_path` filter value can be `false`.
See #48303.
No action taken yet
git: 01a3632
svn: r47048
204 of 3404
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2020-01-07 15:26:44 +0000
Build Tools: do not include assets for JS dependencies that do not exist.
This is a follow-up for #48154, where we started including *.asset.php files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built.

Props jeherve, swissspidy.

Fixes #49144.
No action taken yet
git: 638a948
svn: r47047
205 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-07 00:07:53 +0000
Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button.
Props garrett-eclipse.
Fixes #49139.
No action taken yet
git: f216d9c
svn: r47046
206 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-06 17:07:52 +0000
REST API: Display the actual conflicting value in addition to the taxonomy name in the `_doing_it_wrong()` message for a conflicting `rest_base` or `name` property.
Follow-up to [47037] and [47045].

Props TimothyBlynJacobs.
See #48401.
No action taken yet
git: 105375c
svn: r47045
207 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-06 16:45:58 +0000
REST API: Display the taxonomy name in the `_doing_it_wrong()` message for a conflicting `rest_base` or `name` property, to match the translator comment.
Follow-up to [47037].

See #48401.
No action taken yet
git: 6cd0e35
svn: r47044
208 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-06 16:19:51 +0000
I18N: Replace `rest_authentication_errors` filter name with a placeholder in a translatable string.
Follow-up to [38947] and [40038].

See #38446.
No action taken yet
git: b459cdd
svn: r47043
209 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-06 16:14:30 +0000
I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message.
Props ramiy.
Fixes #48868.
No action taken yet
git: 086ae28
svn: r47042
210 of 3404
Author
Dominik Schilling <[email protected]> 2020-01-06 14:49:13 +0000
Docs: Remove duplicate inline comment in `wp_mail()`.
See [5639].
See #48303.
No action taken yet
git: cd5b7df
svn: r47041
211 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-05 15:31:10 +0000
Docs: Improve documentation for `tests/phpunit/includes/testcase-ajax.php`.
Props andizer, SergeyBiryukov.
Fixes #47568.
No action taken yet
git: 5f600eb
svn: r47040
212 of 3404
Author
Dominik Schilling <[email protected]> 2020-01-05 13:09:52 +0000
Media: After [46375], enable JavaScript translations for the `media-views` script.
See #49134.
No action taken yet
git: 50ed776
svn: r47039
213 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-04 17:58:37 +0000
Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description.
Props mukesh27.
Fixes #49131.
No action taken yet
git: 0a6720a
svn: r47038
214 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-04 01:26:26 +0000
Coding Standards: Add missing braces to `if` conditions in `js/_enqueues/wp/customize/base.js`.
Props ankitmaru.
Fixes #49122.
No action taken yet
git: 746502e
svn: r47037
215 of 3404
Author
K. Adam White <[email protected]> 2020-01-03 19:22:32 +0000
REST API: Issue doing_it_wrong if a taxonomy's specified rest_base is already in use by a different resource.
Props fgiannar, TimothyBlynJacobs, kingkool68, SergeyBiryukov.
Fixes #48401.
No action taken yet
git: 172e0b0
svn: r47036
216 of 3404
Author
K. Adam White <[email protected]> 2020-01-03 18:42:09 +0000
REST API: Short-circuit comment controller permissions check if commented-upon post type does not exist.
Props imani3011, dragosh635, subrataemfluence, timothyblynjacobs.
Fixes #42238.
No action taken yet
git: a35e46a
svn: r47035
217 of 3404
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2020-01-03 13:15:33 +0000
Build Tools: Integrate DependencyExtractionWebpackPlugin in the JS build.
This patch integrates DependencyExtractionWebpackPlugin which was battle-tested in Gutenberg. 

This will greatly simplify the process of upgrading npm packages which change after every Gutenberg release. It might even useful during the WordPress release cycle as we might need to publish more often as we discover critical bugs and regressions.

Props jonsurrell, adamsilverstein, youknowriad, ocean90, netweb.

Fixes #48154.
No action taken yet
git: c27ab74
svn: r47034
218 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-03 02:26:36 +0000
REST API: Synchronize permission checks in `::get_items_permissions_check()` methods for post types, post statuses, and users:
* Only query post types with `'show_in_rest' => true` instead of looping over all post types and checking the `show_in_rest` property separately.
* Return from the `foreach()` loop as soon as the permission check succeeded.

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #49118.
No action taken yet
git: adb9483
svn: r47033
219 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-03 01:12:13 +0000
Link Manager: Use a strict `in_array()` check in `wp-links-opml.php`.
Props dkarfa.
Fixes #49106.
No action taken yet
git: b773334
svn: r47032
220 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-02 19:20:33 +0000
Docs: Synchronize "Default empty array" notes for `$args` parameter in `get_comment_text()` and `comment_text()`.
Props denisco.
See #48303.
No action taken yet
git: 10d4ad9
svn: r47031
221 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-02 12:09:27 +0000
Site Health: Fix typo in a variable name in `js/_enqueues/admin/site-health.js`.
Props nickylimjj.
Fixes #49112.
No action taken yet
git: 83defdf
svn: r47030
222 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-02 12:05:29 +0000
Coding Standards: Move assignment out of condition in `js/media/controllers/library.js`.
Props ankitmaru.
Fixes #49108.
No action taken yet
git: aaee49f
svn: r47029
223 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-02 12:00:11 +0000
Coding Standards: Move assignment out of condition in `js/media/views/settings.js`.
Props ankitmaru.
Fixes #49107.
No action taken yet
git: f4346b9
svn: r47028
224 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-02 11:40:11 +0000
Coding Standards: Use strict comparison in `wp-comments-post.php`.
Props dkarfa.
Fixes #49105.
No action taken yet
git: 3e47858
svn: r47027
225 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-02 11:35:55 +0000
Coding Standards: Use strict comparison and Yoda conditions in `wp-includes/widgets.php`.
Props jenilk.
Fixes #49104.
No action taken yet
git: f4a8e84
svn: r47026
226 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-01 03:51:29 +0000
Happy New Year!
Update copyright year to 2020 in bundled themes' `readme.txt`.
No action taken yet
git: 7bd6157
svn: r47025
227 of 3404
Author
Sergey Biryukov <[email protected]> 2020-01-01 02:17:53 +0000
Happy New Year!
Update copyright year to 2020 in `license.txt`.
No action taken yet
git: c9a366e
svn: r47024
228 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-31 12:32:19 +0000
Docs: Fix typo in `_crop_image_resource()` DocBlock.
Props mukesh27.
Fixes #49103.
No action taken yet
git: ae53e41
svn: r47023
229 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-31 01:29:42 +0000
Docs: Add missing descriptions and `@return` tags for `_WP_Editors::get_mce_locale()` and `::get_baseurl()`.
Props adnan.limdi.
Fixes #41869.
No action taken yet
git: fa0feb0
svn: r47022
230 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-31 01:23:11 +0000
Docs: Add missing `@since` tags for `wp-includes/class-wp-editor.php`.
See #48303.
No action taken yet
git: e2748f4
svn: r47021
231 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-30 13:46:17 +0000
Docs: Fix typo in `.env` file description.
Props mujuonly, dkarfa.
Fixes #49095.
No action taken yet
git: 7b3483c
svn: r47020
232 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-29 22:30:26 +0000
Coding Standards: Fix WPCS issue in [47019].
See #49091.
No action taken yet
git: 1dfd6c5
svn: r47019
233 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-29 20:43:04 +0000
Twenty Twenty: Remove extra space from `arrow-down-circled` icon name in `TwentyTwenty_SVG_Icons::$ui_icons`.
Props kitchin.
Fixes #49091.
No action taken yet
git: ef6973b
svn: r47018
234 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-28 21:18:03 +0000
Bootstrap/Load: Make handling the `/favicon.ico` requests more flexible.
Previously, `wp_favicon_request()` was introduced in [13205] to avoid a performance hit of serving a full 404 page on every favicon request.

While working as intended, that implementation did not provide a way for theme or plugin authors to manage the behavior of favicon requests.

This changeset implements the following logic (only applied if WordPress is installed in the root directory):

* If there is a Site Icon set in Customizer, redirect `/favicon.ico` requests to that icon.
* Otherwise, use the WordPress logo as a default icon.
* If a physical `/favicon.ico` file exists, do nothing, let the server handle the request.

Handling `/favicon.ico` is now more consistent with handling `/robots.txt` requests.

New functions and hooks:

* Introduce `is_favicon()` conditional tag to complement `is_robots()`.
* Introduce `do_favicon` action to complement `do_robots` and use it in template loader.
* Introduce `do_favicon()` function, hooked to the above action by default, to complement `do_robots()`.
* Introduce `do_faviconico` action to complement `do_robotstxt`, for plugins to override the default behavior.
* Mark `wp_favicon_request()` as deprecated in favor of `do_favicon()`.

Props jonoaldersonwp, birgire, joostdevalk, mukesh27, SergeyBiryukov.
Fixes #47398.
No action taken yet
git: 85c7a64
svn: r47017
235 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-27 00:28:39 +0000
Docs: Improve `@return` description for `wp_update_comment()` and `WP_UnitTest_Factory_For_Comment::update_object()`.
See #48303.
No action taken yet
git: 004023d
svn: r47016
236 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-26 15:51:33 +0000
Coding Standards: Fix WPCS issue in [47015].
See #49082.
No action taken yet
git: c231e66
svn: r47015
237 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-26 14:40:10 +0000
Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation.
Props mukesh27.
Fixes #49082.
No action taken yet
git: 079580a
svn: r47014
238 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-26 00:25:20 +0000
Tests: Set `network_id` instead of `site_id` in `WP_UnitTest_Factory_For_Blog` defaults.
Follow-up to [47011], [47013].

See #47195.
No action taken yet
git: 93eeb8f
svn: r47013
239 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-25 21:39:46 +0000
Tests: Update legacy arguments passed to `WP_UnitTest_Factory_For_Blog::create_object()`.
This converts the arguments originally meant for `wpmu_create_blog()` to the ones used by `wp_insert_site()`.

Follow-up to [47011].

Fixes #47195.
No action taken yet
git: f805166
svn: r47012
240 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-25 18:15:13 +0000
Tests: Replace most instances of `wpmu_delete_blog()` not specifically testing that function with `wp_delete_site()`.
Follow-up to [47011].

See #47195.
No action taken yet
git: ebe75fb
svn: r47011
241 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-25 18:10:19 +0000
Tests: Switch `WP_UnitTest_Factory_For_Blog::create_object()` to use `wp_insert_site()`.
Map some arguments for backward compatibility with `wpmu_create_blog()` previously used there.

Props davidbaumwald, danielbachhuber, jeremyfelt, SergeyBiryukov.
See #47195.
No action taken yet
git: dbf6a0b
svn: r47010
242 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-25 02:24:38 +0000
Media: Make sure `attachment_url_to_postid()` performs a case-sensitive search for the uploaded file name.
Previously, the first available match was returned, regardless of the case, which was not always the expected result.

Props archon810, ben.greeley, tristangemus, vsamoletov, SergeyBiryukov.
Fixes #39768.
No action taken yet
git: d56642e
svn: r47009
243 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-24 16:17:17 +0000
Docs: Use a third-person singular verb for comment template function descriptions, per the documentation standards.
See #48303.
No action taken yet
git: 51b421a
svn: r47008
244 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-24 16:08:34 +0000
Docs: Improve documentation for `get_comment_author_url()`.
Props stevenlinx.
Fixes #49076.
No action taken yet
git: 67502b3
svn: r47007
245 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-23 17:58:02 +0000
Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description.
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.

Follow-up to [39064].

Props tomgreer, knutsp, crdunst.
See #49056.
No action taken yet
git: c273108
svn: r47006
246 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-23 14:34:10 +0000
Docs: Improve documentation for admin menu functions:
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`

Add missing descriptions and `@since` tags.

Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253, #49067.
No action taken yet
git: 56e338c
svn: r47005
247 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-22 02:43:30 +0000
Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions.
Props rcutmore, dd32, i3anaan.
Fixes #40572.
No action taken yet
git: 5c83f06
svn: r47004
248 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-21 20:10:25 +0000
Shortcodes: Introduce `apply_shortcodes()` as an alias for `do_shortcode()`.
This better aligns with the semantics of applying filters to the input and returning a result, rather than performing an action and outputting to the current buffer.

Props ljasinskipl, thefarlilacfield.
Fixes #37422.
No action taken yet
git: 7abc076
svn: r47003
249 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-21 18:32:45 +0000
Shortcodes: Make sure `wp.shortcode.string()` accepts the `attrs` array keys in any order.
Props yale01, georgestephanis, adamsilverstein, zsusag, mircoraffinetti, SergeyBiryukov.
Fixes #36263.
No action taken yet
git: 939fbfa
svn: r47002
250 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-21 16:12:15 +0000
Administration: Add `doing_wp_cron` to `wp_removable_query_args()`.
It's a single-use URL parameter that does not need to be passed to canonical URLs in the admin.

Props dlh.
Fixes #49017.
No action taken yet
git: 2c15e0c
svn: r47001
251 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-20 12:13:10 +0000
Tests: Don't fail the test in `WP_UnitTestCase_Base::skipOnAutomatedBranches()` if Travis environment variables are unavailable, it prevents from running the test locally.
Follow-up to [47000].

See #49050.
No action taken yet
git: d697471
svn: r47000
252 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-20 01:10:23 +0000
Tests: Correct the check for pull requests in `WP_UnitTestCase_Base::skipOnAutomatedBranches()`.
Mark the test as failed if the environment variables are unavailable.

Fixes #49050.
No action taken yet
git: 2915793
svn: r46999
253 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-20 00:01:33 +0000
Build/Test Tools: Pass the `TRAVIS_BRANCH` and `TRAVIS_PULL_REQUEST` environment variables along to the Docker container.
This ensures that `WP_UnitTestCase::skipOnAutomatedBranches()` has access to these variables.

See #49050, #47767.
No action taken yet
git: 26cc3cf
svn: r46998
254 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-19 20:27:16 +0000
Tests: Skip external HTTP test for recommended PHP and MySQL versions on 503 errors.
Fixes #49049.
No action taken yet
git: 2fad299
svn: r46997
255 of 3404
Author
Jake Spurlock <[email protected]> 2019-12-19 18:48:49 +0000
Editor: Add unit tests for v5.3.1 block serialization functions
r46896 was intended to have included unit tests for the block serialization functions added as part of the changeset.

Props: @aduth.
Fixes: #49048
No action taken yet
git: 9fe4689
svn: r46996
256 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-19 15:43:33 +0000
Tests: In `test_readme()`, if the HTTP request to `secure.php.net` or `dev.mysql.com` failed, include response code in the error message.
See #40533, #44613.
No action taken yet
git: 7cdb642
svn: r46991
257 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 03:20:59 +0000
Tests: Remove unused cache keys from `data_get_site_caches()`.
Follow-up to [46990].

See #40363.
No action taken yet
git: 0ff4f01
svn: r46990
258 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 02:57:18 +0000
Networks and Sites: Remove invalidation of unused cache keys in `clean_blog_cache()`.
Props spacedmonkey, flixos90, thamaraiselvam.
Fixes #40363.
No action taken yet
git: d592888
svn: r46989
259 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 02:24:05 +0000
Users: When creating the first user on installation, populate the Website profile field with the site URL.
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.

Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778.
No action taken yet
git: 38cfdae
svn: r46988
260 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 01:13:14 +0000
I18N: Make the minimum input length to start searching posts in the "Insert/edit link" modal localizable.
Props Toro_Unit, birgire, miyauchi, swissspidy, ocean90.
Fixes #44662.
No action taken yet
git: c8ac42b
svn: r46987
261 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 00:26:23 +0000
Docs: Improve comments in `tests/formatting/redirect.php` per the documentation standards.
See #48303.
No action taken yet
git: 0d81dcb
svn: r46986
262 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 00:24:03 +0000
Docs: Add `@method` notation for `WP_UnitTest_Factory_For_Term::create_and_get()` for consistency with other factories.
See #48303.
No action taken yet
git: a3e674d
svn: r46985
263 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-18 00:17:54 +0000
Docs: Various documentation fixes for unit test factories.
See #48303.
No action taken yet
git: 99ddfa0
svn: r46981
264 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 21:31:08 +0000
Tests: Use delta comparison in `test_should_fall_back_to_last_post_modified()` to avoid race conditions.
See #48957.
No action taken yet
git: a276995
svn: r46976
265 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-17 20:50:16 +0000
Upload: Run the final file name collision test in `wp_unique_filename()` for each existing file + 1.
Props pbiron.
See #48975.
No action taken yet
git: a4b65bf
svn: r46974
266 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 20:41:09 +0000
Date/Time: Ensure that `get_feed_build_date()` correctly handles a modified post object with invalid date.
* Clarify in the documentation that the function returns `false` on failure.
* Consistently pass the return value through the `get_feed_build_date` filter.

Props Rarst, dd32, azaozz, tellyworth.
Fixes #48957.
No action taken yet
git: 9d69e00
svn: r46973
267 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 20:24:46 +0000
Docs: Clarify that `get_lastpostdate()` and `get_lastpostmodified()` can return `false` on failure.
The both use `_get_last_post_time()` internally.

Props Rarst.
See #48957.
No action taken yet
git: ed3e924
svn: r46972
268 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 16:43:22 +0000
Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`.
Props adnan.limdi.
Fixes #41970.
No action taken yet
git: 81a54a4
svn: r46971
269 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 15:34:49 +0000
Login/Registration: Pass the error data to the `wp_login_failed` action.
Props hamedmoodi, rixeo.
Fixes #49007.
No action taken yet
git: 7261695
svn: r46970
270 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 15:23:33 +0000
Docs: Correct `@type` for `timeout` argument in `WP_Http::request()`.
Props georgestephanis, benedictsinger.
Fixes #49005.
No action taken yet
git: 69ddf95
svn: r46969
271 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 14:35:25 +0000
Date/Time: Add a unit test for [46968].
See #48145.
No action taken yet
git: e8c854d
svn: r46968
272 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-17 02:23:51 +0000
Date/Time: In `wp_insert_post()`, when checking the post date to set `future` or `publish` status, use a proper delta comparison.
[3525] allowed a difference up to 59 seconds between the post date/time and the current time to consider the post published instead of scheduled, but that didn't take start of a new minute into account.

Rapidly creating post fixtures in unit tests could encounter a one-second discrepancy between `current_time( 'mysql' )` and `gmdate( 'Y-m-d H:i:s' )`, returning values like `2019-12-16 23:43:00` vs. `2019-12-16 23:42:59`, respectively, and setting the post to a `future` status instead of `publish`.

[45851], while working as intended, made the issue somewhat more likely to occur.

This caused all sorts of occasional random failures in various tests on Travis, mostly on PHP 7.1.

Fixes #48145.
No action taken yet
git: 5e813ad
svn: r46967
273 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-17 00:13:47 +0000
Fix the colors in all color schemes for the `.active` class for buttons.
Props ryelle, audrasjb.
Fixes #49003 for trunk.
No action taken yet
git: 99ef48a
svn: r46966
274 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-16 23:42:34 +0000
Upload: Fix the final file name collision test in `wp_unique_filename()` when uploading a file with upper case extension. Add a unit test to catch that in the future.
Fixes #48975 for trunk.
No action taken yet
git: 735b354
svn: r46965
275 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-16 23:22:00 +0000
Upload:
- Fix PHP warnings in `wp_unique_filename()` when the destination directory is unreadable.
- Run the final name collision test only for files that are saved to the uploads directory.
- Update the unit tests to match.

Props eden159, audrasjb, azaozz.
Fixes #48960 for trunk.
No action taken yet
git: 8a88cfa
svn: r46964
276 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-16 12:53:59 +0000
Coding Standards: Use strict comparison in `wp-admin/widgets.php`.
Props jenilk.
Fixes #49000.
No action taken yet
git: 2a8f0cb
svn: r46963
277 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-16 12:35:26 +0000
Coding Standards: Use strict comparison in `wp-admin/includes/network.php`.
Props ataurr.
Fixes #48994.
No action taken yet
git: 3b25bc4
svn: r46962
278 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-15 10:44:37 +0000
Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`.
Props passoniate.
Fixes #48985.
No action taken yet
git: ee4f57d
svn: r46961
279 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-15 09:43:08 +0000
Coding Standards: Use strict comparison in `wp-admin/term.php`.
Props vinita29.
Fixes #48983.
No action taken yet
git: 49c6bc2
svn: r46960
280 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-15 08:43:42 +0000
Coding Standards: Add missing braces to `if` conditions in `js/_enqueues/wp/util.js`.
Props ankitmaru.
Fixes #48980.
No action taken yet
git: b202cb4
svn: r46959
281 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-14 15:51:33 +0000
Formatting: Return early from `wp_kses_attr_check()` if the element is not in the list of allowed elements and attributes.
Props krynes, tristanleboss.
Fixes #48549.
No action taken yet
git: 1440dab
svn: r46958
282 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-13 21:43:06 +0000
Docs: Clarify descriptions for `get_gmt_from_date()` and `get_date_from_gmt()`.
Props johnbillion, Rarst.
Fixes #48650.
No action taken yet
git: 5e840c7
svn: r46957
283 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-13 21:25:14 +0000
I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.
Props ramiy.
Fixes #48863.
No action taken yet
git: b7b29dd
svn: r46902
284 of 3404
Author
Ian Belanger <[email protected]> 2019-12-12 18:24:33 +0000
Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1.
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944.
No action taken yet
git: 7c38cf1
svn: r46896
285 of 3404
Author
Jake Spurlock <[email protected]> 2019-12-12 18:00:45 +0000
Prevent stored XSS in the block editor.
Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.

Props: aduth, epiqueras,
No action taken yet
git: 39a8eac
svn: r46895
286 of 3404
Author
Jake Spurlock <[email protected]> 2019-12-12 17:52:18 +0000
Update `wp_kses_bad_protocol()` to recognize `&colon;` on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Props: xknown, nickdaugherty, peterwilsoncc.
No action taken yet
git: dcab984
svn: r46894
287 of 3404
Author
Jake Spurlock <[email protected]> 2019-12-12 17:51:35 +0000
Prevent stored XSS through wp_targeted_link_rel().
Props: vortfu, whyisjake, peterwilsoncc, xknown,  SergeyBiryukov, flaviozavan.
No action taken yet
git: fb952b5
svn: r46893
288 of 3404
Author
Jake Spurlock <[email protected]> 2019-12-12 17:50:13 +0000
Ensure that a user can publish_posts before making a post sticky.
Props: danielbachhuber, whyisjake, peterwilson, xknown.
No action taken yet
git: a69a2c2
svn: r46891
289 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-12 16:45:32 +0000
Docs: Update description for `get_categories()` to avoid suggesting the deprecated `type` argument.
Follow-up to [13754].

Props dingo_d.
Fixes #48913.
No action taken yet
git: 2830c68
svn: r46887
290 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-11 23:01:23 +0000
Upgrade/Install: Improve the appearance of language selection on install:
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.
No action taken yet
git: 3778b1e
svn: r46885
291 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-11 22:12:09 +0000
Comments: Avoid a PHP notice in `comment_form()` if the `email` field is not set.
Follow-up to [46090].

Props mat-lipe.
Fixes #48943.
No action taken yet
git: c85e33c
svn: r46883
292 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-11 18:54:55 +0000
Fixes in `admin-bar.js`:
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Fixes #47069.
No action taken yet
git: b73180d
svn: r46882
293 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-11 15:46:51 +0000
Tests: Docs: Correct `@param` formatting in `SpeedTrapListener` after [35226] and [45607].
See #48303.
No action taken yet
git: 2c55227
svn: r46881
294 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-11 15:40:57 +0000
Tests: Correct the `slowThreshold` option name for `SpeedTrapListener`.
The previous change in [45607] appears to be accidental.

Props Rarst.
Fixes #48933.
No action taken yet
git: 3575a07
svn: r46880
295 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-11 10:57:44 +0000
Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`.
Props grapplerulrich.
Fixes #48932.
No action taken yet
git: 0566a2a
svn: r46879
296 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-10 18:31:46 +0000
TinyMCE: remove CSS map reference from `/tinymce/skins/lightgray/skin.min.css`.
Props AlexHolsgrove.
Fixes #48577.
No action taken yet
git: 78feb00
svn: r46878
297 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-10 13:45:41 +0000
Comments: Optimize the query for pending comments count in `wp_notify_moderator()` for better performance on large tables.
Props sgoen.
Fixes #48514.
No action taken yet
git: 7ac5a9f
svn: r46874
298 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-10 01:32:56 +0000
Coding Standards: Fix WPCS and JSHint issues in [46872].
See #47069.
No action taken yet
git: 2133f83
svn: r46872
299 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-10 01:01:35 +0000
Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package.
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069.
No action taken yet
git: ada69f5
svn: r46870
300 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 22:27:41 +0000
Block Editor: Resolve `@wordpress/block-directory` to the expected version, 1.0.6.
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Fixes #48884.
No action taken yet
git: c1ab0cc
svn: r46868
301 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 21:01:13 +0000
Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.
No action taken yet
git: f090f85
svn: r46866
302 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 20:24:17 +0000
Administration: Standardize form control height and alignment across the admin.
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.
No action taken yet
git: bdca31b
svn: r46864
303 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 19:54:16 +0000
Date/Time: XML-RPC: Сalculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set.
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes #30429.
No action taken yet
git: 50f01f4
svn: r46862
304 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 18:48:50 +0000
Date/Time: When determining whether to decline the month name in `wp_maybe_decline_date()`, take word boundaries into account.
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Fixes #48606.
No action taken yet
git: 2e175ca
svn: r46860
305 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 17:35:22 +0000
Block Editor: Bug fixes targeted for WordPress 5.3.1.
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
No action taken yet
git: 3360da2
svn: r46858
306 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 16:40:11 +0000
Upgrade/Install: Update sodium_compat to v1.12.1.
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371.
No action taken yet
git: a521300
svn: r46856
307 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 16:21:10 +0000
Media: Use consistent width for Scale and Crop inputs.
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.
No action taken yet
git: 55de626
svn: r46854
308 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 16:16:09 +0000
Twenty Twenty: Adjust the comment in [46851] per the documentation standards.
See #48876.
No action taken yet
git: cb9ed87
svn: r46852
309 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 15:29:47 +0000
Help/About: Add a hover effect for links on About pages.
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.
No action taken yet
git: 9b69d0f
svn: r46851
310 of 3404
Author
Ian Belanger <[email protected]> 2019-12-09 15:08:16 +0000
Bundled Themes: Misaligned input placeholder text Twenty Twenty.
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal.
Fixes #48876.
No action taken yet
git: 2de8f8b
svn: r46849
311 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 14:58:52 +0000
Twenty Twenty: Remove redundant `echo` for `bloginfo()` call in `footer.php`.
Props acosmin.
Fixes #48918.
No action taken yet
git: c96a56c
svn: r46845
312 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 14:24:26 +0000
Administration: Correct checkbox width in list tables on smaller screens.
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.
No action taken yet
git: 868f91e
svn: r46844
313 of 3404
Author
Ian Belanger <[email protected]> 2019-12-09 14:06:55 +0000
Bundled Themes: Make checkbox in comment form larger Twenty Twenty.
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb.
Fixes #48652.
No action taken yet
git: 9c82519
svn: r46842
314 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:47:12 +0000
Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.
No action taken yet
git: 358705a
svn: r46840
315 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:37:30 +0000
Twenty Twenty: Correct alignment for embedded Instagram posts.
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688.
No action taken yet
git: a5d26f7
svn: r46838
316 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:24:20 +0000
Users: Introduce `admin_email_remind_interval` filter for dismissing the admin email confirmation screen.
Props desrosj, birgire.
Fixes #48334.
No action taken yet
git: ed126e5
svn: r46837
317 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:08:53 +0000
Docs: Correct DocBlock formatting for `admin_email_confirm` and `admin_email_confirm_form` hooks.
See #48303.
No action taken yet
git: e76722f
svn: r46835
318 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 12:16:43 +0000
Tests: Change `group` annotation for `test_unique_filename_with_dimension_like_filename()` to `ticket.
See #42437.
No action taken yet
git: d706e90
svn: r46832
319 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 11:48:00 +0000
Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context.
Props msaari, SergeyBiryukov.
Fixes #48906.
No action taken yet
git: de38dfd
svn: r46831
320 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 11:29:14 +0000
Tests: Make sure network factory returns an integer ID for created objects, for consistency with other factories and the documented value.
See #48145.
No action taken yet
git: 102cb95
svn: r46830
321 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-09 10:39:39 +0000
Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected.
Previously, tests could create sequential objects with names like `Term 99`, `Term 100`, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.

See #48145.
No action taken yet
git: 0660804
svn: r46829
322 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-08 18:00:23 +0000
Tests: Speed up comment submission unit tests by creating less fixtures and reusing them where possible.
See #30017, #48145.
No action taken yet
git: 8b0feef
svn: r46828
323 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-07 14:01:44 +0000
Twenty Twenty: Use duplicate hook references for `page_css_class` and `page_menu_link_attributes` filters in `TwentyTwenty_Walker_Page`.
See #48303.
No action taken yet
git: ac6dc8a
svn: r46827
324 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-07 13:54:43 +0000
Bundled Themes: Correct `@since` tags to refer to the theme version instead of WordPress version.
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.

See #48303.
No action taken yet
git: e12f866
svn: r46826
325 of 3404
Author
John Blackbourn <[email protected]> 2019-12-07 13:21:07 +0000
Docs: Further docblock corrections and improvements.
See #48303
No action taken yet
git: 388524c
svn: r46824
326 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-07 11:03:09 +0000
Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property.
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763, #48551, #48866.
No action taken yet
git: 726d3a1
svn: r46823
327 of 3404
Author
John Blackbourn <[email protected]> 2019-12-06 22:41:26 +0000
Docs: Increase the specificity of various docblock parameter types and return types.
See #48303
No action taken yet
git: 5464dcb
svn: r46822
328 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-06 22:26:19 +0000
Upload: fix `wp_unique_filename()` to prevent name collisions with existing or future image sub-size file names, and add unit tests.
Props Viper007Bond, pbiron, azaozz.
Fixes #42437.
No action taken yet
git: bcfccc7
svn: r46821
329 of 3404
Author
John Blackbourn <[email protected]> 2019-12-06 22:21:07 +0000
Docs: Correct various docblocks documentation.
See #48303
No action taken yet
git: 8ed3551
svn: r46820
330 of 3404
Author
Aaron Jorbin <[email protected]> 2019-12-06 18:10:58 +0000
Text Changes: Rename Comment Blacklist option to be more inclusive
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.

Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900.
No action taken yet
git: 0c673c2
svn: r46819
331 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-06 17:25:32 +0000
Tests: Remove duplicate `test_get_page_by_path_priority()` test.
The test was moved into its own file in [37478], but never removed from its previous location.

See #36711.
No action taken yet
git: 47e38ea
svn: r46817
332 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-05 22:10:29 +0000
Accessibility: Administration: Correct active button color for the alternative color schemes.
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.
No action taken yet
git: 94b37d4
svn: r46815
333 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-05 21:30:58 +0000
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.
No action taken yet
git: eb4b070
svn: r46814
334 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-05 13:46:43 +0000
XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency.
Props ramiy, SergeyBiryukov.
Fixes #48883.
No action taken yet
git: 46cffd8
svn: r46813
335 of 3404
Author
Ian Belanger <[email protected]> 2019-12-04 15:57:54 +0000
Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty.
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange acosmin, dlh.
Fixes #48550.
No action taken yet
git: 8b08d64
svn: r46812
336 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-04 10:34:03 +0000
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
Props ramiy.
Fixes #48875.
No action taken yet
git: 972ca00
svn: r46811
337 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-03 13:56:25 +0000
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.

Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857.
No action taken yet
git: 9440ad9
svn: r46810
338 of 3404
Author
Sergey Biryukov <[email protected]> 2019-12-02 14:47:27 +0000
Taxonomy: Remove redundant caching from `get_all_category_ids()`, deprecated in favor of `get_terms()` in [28679].
The `all_category_ids` cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.

Props itowhid06, johnjamesjacoby.
Fixes #48176.
No action taken yet
git: 8917973
svn: r46809
339 of 3404
Author
Andrew Ozz <[email protected]> 2019-12-01 18:24:30 +0000
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
Fixes #48736.
No action taken yet
git: 2a85333
svn: r46808
340 of 3404
Author
Sergey Biryukov <[email protected]wordpress.org> 2019-12-01 12:11:57 +0000
Widgets: Remove `WP_Widget_Factory::$hashed_class_counts` property, unused since [46220].
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so the `WP_Widget_Factory::hash_object()` workaround was removed in [46220].

See #48074.
No action taken yet
git: bf3295d
svn: r46807
341 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-30 00:40:24 +0000
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
Props donmhico, jeremyfelt.
Fixes #48799.
No action taken yet
git: 4bd7b37
svn: r46806
342 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 22:15:31 +0000
Tests: Merge [24251] from `_wp_filter_build_unique_id()` to `_test_filter_build_unique_id()`, for consistency.
See #47407.
No action taken yet
git: aacfec6
svn: r46805
343 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 22:12:10 +0000
Plugins: In `_wp_filter_build_unique_id()`, remove `$wp_filter` global and `$filter_id_count` static variable, unused since [46220].
See #47407, #48074.
No action taken yet
git: b5ed00d
svn: r46804
344 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 22:02:30 +0000
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
See #48839.
No action taken yet
git: e3261b6
svn: r46803
345 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 21:58:37 +0000
REST API: Use a strict `in_array()` check in `WP_REST_Request::get_parameter_order()`.
See #48839.
No action taken yet
git: d50f672
svn: r46802
346 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 21:57:09 +0000
REST API: Use a strict `in_array()` check in `WP_REST_Meta_Fields::get_registered_fields()`.
Props dkarfa.
Fixes #48839.
No action taken yet
git: 890bd87
svn: r46801
347 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 21:40:58 +0000
Docs: Correct `@param` type for the function parameter in `tests_add_filter()` and `_test_filter_build_unique_id()`.
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.

Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.

Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407. See #48303.
No action taken yet
git: a03bb54
svn: r46800
348 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 17:59:47 +0000
Docs: Replace `@returns` tags in JS docs with `@return`.
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
No action taken yet
git: ea5bfe1
svn: r46799
349 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-29 16:55:01 +0000
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
Props shital-patel, kalpshit.
Fixes #48305.
No action taken yet
git: 4b60e6a
svn: r46797
350 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-28 15:46:45 +0000
Site Health: Add a test for PHP default timezone.
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.
No action taken yet
git: e720a9d
svn: r46795
351 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-28 13:40:19 +0000
Date/Time: Make `get_permalink()` more resilient against PHP timezone changes.
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623.
No action taken yet
git: 9737e5f
svn: r46793
352 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-28 00:27:21 +0000
KSES: Add support for gradient backgrounds.
Props jorgefilipecosta.
Fixes #48376.
No action taken yet
git: 81581b5
svn: r46792
353 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-27 23:53:31 +0000
Plugins: Correct default value of `$replacement` parameter in `do_action_deprecated()` and `apply_filters_deprecated()`.
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.

Props shaampk1, felipeelia.
Fixes #48817.
No action taken yet
git: 2dc58b9
svn: r46791
354 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-27 19:49:24 +0000
Menus: Improve the wording of instructions for dragging the items into the preferred order.
Props amolv, equin0x80, dlh.
Fixes #48184.
No action taken yet
git: 10d5efa
svn: r46790
355 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-27 16:50:59 +0000
Administration: Properly wrap long titles in list tables on smaller screens.
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.
No action taken yet
git: 993180b
svn: r46788
356 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-27 14:33:47 +0000
Users: Display admin email verification screen in user's locale instead of site locale.
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313.
No action taken yet
git: 43ecd78
svn: r46786
357 of 3404
Author
Ian Belanger <[email protected]> 2019-11-26 18:19:54 +0000
Bundled Themes: Fixes JS TypeError in Twenty Twenty.
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601.
No action taken yet
git: 4159a41
svn: r46785
358 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-26 16:17:02 +0000
Tests: Add `feed` group for `get_feed_build_date()` test added in [46756].
See #48675.
No action taken yet
git: c2413a4
svn: r46784
359 of 3404
Author
Dominik Schilling <[email protected]> 2019-11-26 15:17:30 +0000
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.
No action taken yet
git: 29f0d74
svn: r46782
360 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-25 13:59:02 +0000
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.
No action taken yet
git: 752d749
svn: r46779
361 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-25 13:42:22 +0000
Options, Meta APIs: Update `@since` version for the `$force_cache` parameter added for `wp_load_alloptions()` in [46753] to 5.3.1.
See #31245.
No action taken yet
git: 7dfb911
svn: r46772
362 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-25 10:05:39 +0000
Media: Avoid a PHP notice in `image_downsize()` when trying to replace a non-image URL with a rendered image from its meta.
Props Mte90, jrf, hareesh-pillai.
Fixes #48324.
No action taken yet
git: dc48630
svn: r46770
363 of 3404
Author
SergeyBiryukov <[email protected]> 2019-11-24 19:55:01 +0000
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.
No action taken yet
git: 5e801fe
svn: r46765
364 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-24 10:53:40 +0000
Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`.
Props manikmist09.
Fixes #48624.
No action taken yet
git: 29ff549
svn: r46764
365 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-23 19:19:57 +0000
Coding Standards: Fix WPCS issue in [46763].
See #48777.
No action taken yet
git: fec3976
svn: r46763
366 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-23 18:49:59 +0000
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
Props sathyapulse, zodiac1978.
Fixes #48777.
No action taken yet
git: c5d880c
svn: r46762
367 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-23 14:52:13 +0000
Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
Props nielslange, Anlino.
Fixes #48619.
No action taken yet
git: 29e97b7
svn: r46761
368 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-23 10:13:32 +0000
Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.
Props audrasjb, youknowriad.
Fixes #48696.
No action taken yet
git: b718cc0
svn: r46760
369 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-22 18:26:41 +0000
Docs: Adjust `wp_is_json_request()` and `wp_is_xml_request()` return value descriptions for consistency.
See #48771, #48303.
No action taken yet
git: 7551c2b
svn: r46759
370 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-22 18:14:45 +0000
Docs: Correct spelling and capitalization in `wp-includes/load.php`:
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.

Props stevegrunwell.
Fixes #48771.
No action taken yet
git: 206ea67
svn: r46758
371 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-22 00:02:12 +0000
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.
No action taken yet
git: 172f434
svn: r46757
372 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-21 16:25:38 +0000
Date/Time: Correct the time format in `get_feed_build_date()` to use 24-hour format.
Follow-up to [46756].

See #48675.
No action taken yet
git: 6ce8175
svn: r46756
373 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-21 13:16:50 +0000
Date/Time: Remove `mysql2date()` usage in `get_feed_build_date()` to ensure the output includes correct timezone offset.
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Fixes #48675.
No action taken yet
git: 065a181
svn: r46755
374 of 3404
Author
Sergey Biryukov <[email protected]> 2019-11-21 00:06:32 +0000
I18N: Correct translator comment for `By %s` string in Plugins list table.
Follow-up to [44541].

See #45898.