WordPress commits: wp-trunk branch

git: b202cb4
svn: r46959
1 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-14 15:51:33 +0000
Formatting: Return early from `wp_kses_attr_check()` if the element is not in the list of allowed elements and attributes.
Props krynes, tristanleboss.
Fixes #48549.
No action taken yet
git: 1440dab
svn: r46958
2 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-13 21:43:06 +0000
Docs: Clarify descriptions for `get_gmt_from_date()` and `get_date_from_gmt()`.
Props johnbillion, Rarst.
Fixes #48650.
No action taken yet
git: 5e840c7
svn: r46957
3 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-13 21:25:14 +0000
I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.
Props ramiy.
Fixes #48863.
No action taken yet
git: b7b29dd
svn: r46902
4 of 3124
Author
Ian Belanger <[email protected]> 2019-12-12 18:24:33 +0000
Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1.
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944.
No action taken yet
git: 7c38cf1
svn: r46896
5 of 3124
Author
Jake Spurlock <[email protected]> 2019-12-12 18:00:45 +0000
Prevent stored XSS in the block editor.
Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.

Props: aduth, epiqueras,
No action taken yet
git: 39a8eac
svn: r46895
6 of 3124
Author
Jake Spurlock <[email protected]> 2019-12-12 17:52:18 +0000
Update `wp_kses_bad_protocol()` to recognize `&colon;` on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Props: xknown, nickdaugherty, peterwilsoncc.
No action taken yet
git: dcab984
svn: r46894
7 of 3124
Author
Jake Spurlock <[email protected]> 2019-12-12 17:51:35 +0000
Prevent stored XSS through wp_targeted_link_rel().
Props: vortfu, whyisjake, peterwilsoncc, xknown,  SergeyBiryukov, flaviozavan.
No action taken yet
git: fb952b5
svn: r46893
8 of 3124
Author
Jake Spurlock <[email protected]> 2019-12-12 17:50:13 +0000
Ensure that a user can publish_posts before making a post sticky.
Props: danielbachhuber, whyisjake, peterwilson, xknown.
No action taken yet
git: a69a2c2
svn: r46891
9 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-12 16:45:32 +0000
Docs: Update description for `get_categories()` to avoid suggesting the deprecated `type` argument.
Follow-up to [13754].

Props dingo_d.
Fixes #48913.
No action taken yet
git: 2830c68
svn: r46887
10 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-11 23:01:23 +0000
Upgrade/Install: Improve the appearance of language selection on install:
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.
No action taken yet
git: 3778b1e
svn: r46885
11 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-11 22:12:09 +0000
Comments: Avoid a PHP notice in `comment_form()` if the `email` field is not set.
Follow-up to [46090].

Props mat-lipe.
Fixes #48943.
No action taken yet
git: c85e33c
svn: r46883
12 of 3124
Author
Andrew Ozz <[email protected]> 2019-12-11 18:54:55 +0000
Fixes in `admin-bar.js`:
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Fixes #47069.
No action taken yet
git: b73180d
svn: r46882
13 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-11 15:46:51 +0000
Tests: Docs: Correct `@param` formatting in `SpeedTrapListener` after [35226] and [45607].
See #48303.
No action taken yet
git: 2c55227
svn: r46881
14 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-11 15:40:57 +0000
Tests: Correct the `slowThreshold` option name for `SpeedTrapListener`.
The previous change in [45607] appears to be accidental.

Props Rarst.
Fixes #48933.
No action taken yet
git: 3575a07
svn: r46880
15 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-11 10:57:44 +0000
Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`.
Props grapplerulrich.
Fixes #48932.
No action taken yet
git: 0566a2a
svn: r46879
16 of 3124
Author
Andrew Ozz <[email protected]> 2019-12-10 18:31:46 +0000
TinyMCE: remove CSS map reference from `/tinymce/skins/lightgray/skin.min.css`.
Props AlexHolsgrove.
Fixes #48577.
No action taken yet
git: 78feb00
svn: r46878
17 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-10 13:45:41 +0000
Comments: Optimize the query for pending comments count in `wp_notify_moderator()` for better performance on large tables.
Props sgoen.
Fixes #48514.
No action taken yet
git: 7ac5a9f
svn: r46874
18 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-10 01:32:56 +0000
Coding Standards: Fix WPCS and JSHint issues in [46872].
See #47069.
No action taken yet
git: 2133f83
svn: r46872
19 of 3124
Author
Andrew Ozz <[email protected]> 2019-12-10 01:01:35 +0000
Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package.
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069.
No action taken yet
git: ada69f5
svn: r46870
20 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 22:27:41 +0000
Block Editor: Resolve `@wordpress/block-directory` to the expected version, 1.0.6.
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Fixes #48884.
No action taken yet
git: c1ab0cc
svn: r46868
21 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 21:01:13 +0000
Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.
No action taken yet
git: f090f85
svn: r46866
22 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 20:24:17 +0000
Administration: Standardize form control height and alignment across the admin.
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.
No action taken yet
git: bdca31b
svn: r46864
23 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 19:54:16 +0000
Date/Time: XML-RPC: Сalculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set.
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes #30429.
No action taken yet
git: 50f01f4
svn: r46862
24 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 18:48:50 +0000
Date/Time: When determining whether to decline the month name in `wp_maybe_decline_date()`, take word boundaries into account.
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Fixes #48606.
No action taken yet
git: 2e175ca
svn: r46860
25 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 17:35:22 +0000
Block Editor: Bug fixes targeted for WordPress 5.3.1.
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]
- @wordpress/[email protected]

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
No action taken yet
git: 3360da2
svn: r46858
26 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 16:40:11 +0000
Upgrade/Install: Update sodium_compat to v1.12.1.
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371.
No action taken yet
git: a521300
svn: r46856
27 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 16:21:10 +0000
Media: Use consistent width for Scale and Crop inputs.
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.
No action taken yet
git: 55de626
svn: r46854
28 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 16:16:09 +0000
Twenty Twenty: Adjust the comment in [46851] per the documentation standards.
See #48876.
No action taken yet
git: cb9ed87
svn: r46852
29 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 15:29:47 +0000
Help/About: Add a hover effect for links on About pages.
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.
No action taken yet
git: 9b69d0f
svn: r46851
30 of 3124
Author
Ian Belanger <[email protected]> 2019-12-09 15:08:16 +0000
Bundled Themes: Misaligned input placeholder text Twenty Twenty.
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal.
Fixes #48876.
No action taken yet
git: 2de8f8b
svn: r46849
31 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 14:58:52 +0000
Twenty Twenty: Remove redundant `echo` for `bloginfo()` call in `footer.php`.
Props acosmin.
Fixes #48918.
No action taken yet
git: c96a56c
svn: r46845
32 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 14:24:26 +0000
Administration: Correct checkbox width in list tables on smaller screens.
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.
No action taken yet
git: 868f91e
svn: r46844
33 of 3124
Author
Ian Belanger <[email protected]> 2019-12-09 14:06:55 +0000
Bundled Themes: Make checkbox in comment form larger Twenty Twenty.
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb.
Fixes #48652.
No action taken yet
git: 9c82519
svn: r46842
34 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:47:12 +0000
Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.
No action taken yet
git: 358705a
svn: r46840
35 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:37:30 +0000
Twenty Twenty: Correct alignment for embedded Instagram posts.
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688.
No action taken yet
git: a5d26f7
svn: r46838
36 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:24:20 +0000
Users: Introduce `admin_email_remind_interval` filter for dismissing the admin email confirmation screen.
Props desrosj, birgire.
Fixes #48334.
No action taken yet
git: ed126e5
svn: r46837
37 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 13:08:53 +0000
Docs: Correct DocBlock formatting for `admin_email_confirm` and `admin_email_confirm_form` hooks.
See #48303.
No action taken yet
git: e76722f
svn: r46835
38 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 12:16:43 +0000
Tests: Change `group` annotation for `test_unique_filename_with_dimension_like_filename()` to `ticket.
See #42437.
No action taken yet
git: d706e90
svn: r46832
39 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 11:48:00 +0000
Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context.
Props msaari, SergeyBiryukov.
Fixes #48906.
No action taken yet
git: de38dfd
svn: r46831
40 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 11:29:14 +0000
Tests: Make sure network factory returns an integer ID for created objects, for consistency with other factories and the documented value.
See #48145.
No action taken yet
git: 102cb95
svn: r46830
41 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-09 10:39:39 +0000
Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected.
Previously, tests could create sequential objects with names like `Term 99`, `Term 100`, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.

See #48145.
No action taken yet
git: 0660804
svn: r46829
42 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-08 18:00:23 +0000
Tests: Speed up comment submission unit tests by creating less fixtures and reusing them where possible.
See #30017, #48145.
No action taken yet
git: 8b0feef
svn: r46828
43 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-07 14:01:44 +0000
Twenty Twenty: Use duplicate hook references for `page_css_class` and `page_menu_link_attributes` filters in `TwentyTwenty_Walker_Page`.
See #48303.
No action taken yet
git: ac6dc8a
svn: r46827
44 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-07 13:54:43 +0000
Bundled Themes: Correct `@since` tags to refer to the theme version instead of WordPress version.
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.

See #48303.
No action taken yet
git: e12f866
svn: r46826
45 of 3124
Author
John Blackbourn <[email protected]> 2019-12-07 13:21:07 +0000
Docs: Further docblock corrections and improvements.
See #48303
No action taken yet
git: 388524c
svn: r46824
46 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-07 11:03:09 +0000
Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property.
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763, #48551, #48866.
No action taken yet
git: 726d3a1
svn: r46823
47 of 3124
Author
John Blackbourn <[email protected]> 2019-12-06 22:41:26 +0000
Docs: Increase the specificity of various docblock parameter types and return types.
See #48303
No action taken yet
git: 5464dcb
svn: r46822
48 of 3124
Author
Andrew Ozz <[email protected]> 2019-12-06 22:26:19 +0000
Upload: fix `wp_unique_filename()` to prevent name collisions with existing or future image sub-size file names, and add unit tests.
Props Viper007Bond, pbiron, azaozz.
Fixes #42437.
No action taken yet
git: bcfccc7
svn: r46821
49 of 3124
Author
John Blackbourn <[email protected]> 2019-12-06 22:21:07 +0000
Docs: Correct various docblocks documentation.
See #48303
No action taken yet
git: 8ed3551
svn: r46820
50 of 3124
Author
Aaron Jorbin <[email protected]> 2019-12-06 18:10:58 +0000
Text Changes: Rename Comment Blacklist option to be more inclusive
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.

Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900.
No action taken yet
git: 0c673c2
svn: r46819
51 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-06 17:25:32 +0000
Tests: Remove duplicate `test_get_page_by_path_priority()` test.
The test was moved into its own file in [37478], but never removed from its previous location.

See #36711.
No action taken yet
git: 47e38ea
svn: r46817
52 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-05 22:10:29 +0000
Accessibility: Administration: Correct active button color for the alternative color schemes.
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598.
No action taken yet
git: 94b37d4
svn: r46815
53 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-05 21:30:58 +0000
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585.
No action taken yet
git: eb4b070
svn: r46814
54 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-05 13:46:43 +0000
XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency.
Props ramiy, SergeyBiryukov.
Fixes #48883.
No action taken yet
git: 46cffd8
svn: r46813
55 of 3124
Author
Ian Belanger <[email protected]> 2019-12-04 15:57:54 +0000
Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty.
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange acosmin, dlh.
Fixes #48550.
No action taken yet
git: 8b08d64
svn: r46812
56 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-04 10:34:03 +0000
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
Props ramiy.
Fixes #48875.
No action taken yet
git: 972ca00
svn: r46811
57 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-03 13:56:25 +0000
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.

Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857.
No action taken yet
git: 9440ad9
svn: r46810
58 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-02 14:47:27 +0000
Taxonomy: Remove redundant caching from `get_all_category_ids()`, deprecated in favor of `get_terms()` in [28679].
The `all_category_ids` cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.

Props itowhid06, johnjamesjacoby.
Fixes #48176.
No action taken yet
git: 8917973
svn: r46809
59 of 3124
Author
Andrew Ozz <[email protected]> 2019-12-01 18:24:30 +0000
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
Fixes #48736.
No action taken yet
git: 2a85333
svn: r46808
60 of 3124
Author
Sergey Biryukov <[email protected]> 2019-12-01 12:11:57 +0000
Widgets: Remove `WP_Widget_Factory::$hashed_class_counts` property, unused since [46220].
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so the `WP_Widget_Factory::hash_object()` workaround was removed in [46220].

See #48074.
No action taken yet
git: bf3295d
svn: r46807
61 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-30 00:40:24 +0000
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
Props donmhico, jeremyfelt.
Fixes #48799.
No action taken yet
git: 4bd7b37
svn: r46806
62 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 22:15:31 +0000
Tests: Merge [24251] from `_wp_filter_build_unique_id()` to `_test_filter_build_unique_id()`, for consistency.
See #47407.
No action taken yet
git: aacfec6
svn: r46805
63 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 22:12:10 +0000
Plugins: In `_wp_filter_build_unique_id()`, remove `$wp_filter` global and `$filter_id_count` static variable, unused since [46220].
See #47407, #48074.
No action taken yet
git: b5ed00d
svn: r46804
64 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 22:02:30 +0000
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
See #48839.
No action taken yet
git: e3261b6
svn: r46803
65 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 21:58:37 +0000
REST API: Use a strict `in_array()` check in `WP_REST_Request::get_parameter_order()`.
See #48839.
No action taken yet
git: d50f672
svn: r46802
66 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 21:57:09 +0000
REST API: Use a strict `in_array()` check in `WP_REST_Meta_Fields::get_registered_fields()`.
Props dkarfa.
Fixes #48839.
No action taken yet
git: 890bd87
svn: r46801
67 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 21:40:58 +0000
Docs: Correct `@param` type for the function parameter in `tests_add_filter()` and `_test_filter_build_unique_id()`.
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.

Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.

Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407. See #48303.
No action taken yet
git: a03bb54
svn: r46800
68 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 17:59:47 +0000
Docs: Replace `@returns` tags in JS docs with `@return`.
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
No action taken yet
git: ea5bfe1
svn: r46799
69 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-29 16:55:01 +0000
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
Props shital-patel, kalpshit.
Fixes #48305.
No action taken yet
git: 4b60e6a
svn: r46797
70 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-28 15:46:45 +0000
Site Health: Add a test for PHP default timezone.
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692.
No action taken yet
git: e720a9d
svn: r46795
71 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-28 13:40:19 +0000
Date/Time: Make `get_permalink()` more resilient against PHP timezone changes.
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623.
No action taken yet
git: 9737e5f
svn: r46793
72 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-28 00:27:21 +0000
KSES: Add support for gradient backgrounds.
Props jorgefilipecosta.
Fixes #48376.
No action taken yet
git: 81581b5
svn: r46792
73 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-27 23:53:31 +0000
Plugins: Correct default value of `$replacement` parameter in `do_action_deprecated()` and `apply_filters_deprecated()`.
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.

Props shaampk1, felipeelia.
Fixes #48817.
No action taken yet
git: 2dc58b9
svn: r46791
74 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-27 19:49:24 +0000
Menus: Improve the wording of instructions for dragging the items into the preferred order.
Props amolv, equin0x80, dlh.
Fixes #48184.
No action taken yet
git: 10d5efa
svn: r46790
75 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-27 16:50:59 +0000
Administration: Properly wrap long titles in list tables on smaller screens.
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805.
No action taken yet
git: 993180b
svn: r46788
76 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-27 14:33:47 +0000
Users: Display admin email verification screen in user's locale instead of site locale.
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313.
No action taken yet
git: 43ecd78
svn: r46786
77 of 3124
Author
Ian Belanger <[email protected]> 2019-11-26 18:19:54 +0000
Bundled Themes: Fixes JS TypeError in Twenty Twenty.
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601.
No action taken yet
git: 4159a41
svn: r46785
78 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-26 16:17:02 +0000
Tests: Add `feed` group for `get_feed_build_date()` test added in [46756].
See #48675.
No action taken yet
git: c2413a4
svn: r46784
79 of 3124
Author
Dominik Schilling <[email protected]> 2019-11-26 15:17:30 +0000
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
Prevents an empty continue button if a translation isn't yet available.

Props sathyapulse.
Fixes #48776.
No action taken yet
git: 29f0d74
svn: r46782
80 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-25 13:59:02 +0000
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
Addresses a regression in [45926].

Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725.
No action taken yet
git: 752d749
svn: r46779
81 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-25 13:42:22 +0000
Options, Meta APIs: Update `@since` version for the `$force_cache` parameter added for `wp_load_alloptions()` in [46753] to 5.3.1.
See #31245.
No action taken yet
git: 7dfb911
svn: r46772
82 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-25 10:05:39 +0000
Media: Avoid a PHP notice in `image_downsize()` when trying to replace a non-image URL with a rendered image from its meta.
Props Mte90, jrf, hareesh-pillai.
Fixes #48324.
No action taken yet
git: dc48630
svn: r46770
83 of 3124
Author
SergeyBiryukov <[email protected]> 2019-11-24 19:55:01 +0000
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box

Split "Manage widgets or menus" into separate items for consistency with other links.

For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.

Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone

Props afercia, audrasjb, karmatosed.
Fixes #48406.
No action taken yet
git: 5e801fe
svn: r46765
84 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-24 10:53:40 +0000
Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`.
Props manikmist09.
Fixes #48624.
No action taken yet
git: 29ff549
svn: r46764
85 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-23 19:19:57 +0000
Coding Standards: Fix WPCS issue in [46763].
See #48777.
No action taken yet
git: fec3976
svn: r46763
86 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-23 18:49:59 +0000
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
Props sathyapulse, zodiac1978.
Fixes #48777.
No action taken yet
git: c5d880c
svn: r46762
87 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-23 14:52:13 +0000
Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
Props nielslange, Anlino.
Fixes #48619.
No action taken yet
git: 29e97b7
svn: r46761
88 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-23 10:13:32 +0000
Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.
Props audrasjb, youknowriad.
Fixes #48696.
No action taken yet
git: b718cc0
svn: r46760
89 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-22 18:26:41 +0000
Docs: Adjust `wp_is_json_request()` and `wp_is_xml_request()` return value descriptions for consistency.
See #48771, #48303.
No action taken yet
git: 7551c2b
svn: r46759
90 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-22 18:14:45 +0000
Docs: Correct spelling and capitalization in `wp-includes/load.php`:
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.

Props stevegrunwell.
Fixes #48771.
No action taken yet
git: 206ea67
svn: r46758
91 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-22 00:02:12 +0000
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592.
No action taken yet
git: 172f434
svn: r46757
92 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-21 16:25:38 +0000
Date/Time: Correct the time format in `get_feed_build_date()` to use 24-hour format.
Follow-up to [46756].

See #48675.
No action taken yet
git: 6ce8175
svn: r46756
93 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-21 13:16:50 +0000
Date/Time: Remove `mysql2date()` usage in `get_feed_build_date()` to ensure the output includes correct timezone offset.
With the changes in [45908], `mysql2date()` works correctly for all local time inputs, but should not be used for UTC time inputs.

Add a unit test.

Props Rarst, lisota.
Fixes #48675.
No action taken yet
git: 065a181
svn: r46755
94 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-21 00:06:32 +0000
I18N: Correct translator comment for `By %s` string in Plugins list table.
Follow-up to [44541].

See #45898.
No action taken yet
git: 3b54ab3
svn: r46754
95 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-20 18:47:08 +0000
Customize: If the return URL for Close button is a page added to the Appearance menu by a deactivated theme, fall back to the Themes screen.
Props JarretC, Jean-David, SergeyBiryukov.
Fixes #46686.
No action taken yet
git: 071030b
svn: r46753
96 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-20 13:40:39 +0000
Options, Meta APIs: Avoid a race condition causing the first of two subsequent requests updating different options at the same time to lose changes.
Every time an autoloaded option is updated or deleted, the `alloptions` cache is similarly updated. Due to the race condition, on any autoloaded option being updated, every other autoloaded option had its value set to the value at load time, causing a mismatch between the data in the persistent cache and the database.

This change introduces a `$force_cache` parameter for `wp_load_alloptions()` to force an update of the local `alloptions` cache from the persistent cache when an option is added, updated, or deleted, to minimize the chance of affecting other options.

Props fabifott, rmccue, tollmanz, johnjamesjacoby, spacedmonkey, dd32, jipmoors, tellyworth, jeremyclarke, joehoyle, boonebgorges, danielbachhuber, flixos90, jeichorn, mihdan, Grzegorz.Janoszka, SergeyBiryukov.
See #31245.
No action taken yet
git: 54e2c8c
svn: r46752
97 of 3124
Author
Sergey Biryukov <s[email protected]> 2019-11-20 08:31:32 +0000
Docs: Fix typo in `README.md`.
Props dkarfa.
Fixes #48737.
No action taken yet
git: 2d097fd
svn: r46751
98 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-20 08:29:36 +0000
Docs: Clarify that `WP_Theme::get()`, `::display()`, and several related methods treat the `Tags` theme header as an array.
Props david.binda.
Fixes #48005.
No action taken yet
git: 944502a
svn: r46750
99 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-19 11:05:08 +0000
XML-RPC: Pass correct variable as the URL parameter to `http_headers_useragent` filter in `wp_xmlrpc_server::pingback_ping()`.
Props wpgurudev, andreaitm.
Fixes #48721. See #42186.
No action taken yet
git: af941d4
svn: r46749
100 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-19 09:59:19 +0000
Login and Registration: Pass `$user_data` parameter to the `lostpassword_post` action in `retrieve_password()`.
Props wpgurudev, pagewidth, lukecavanagh, johnbillion, kkarpieszuk.
Fixes #38334.
No action taken yet
git: 82e352e
svn: r46748
101 of 3124
Author
Andrea Fercia <[email protected]> 2019-11-18 22:21:26 +0000
Accessibility: Media: Add an `aria-pressed` attribute to active button within a button group.
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".

Fixes #48355.
No action taken yet
git: 4ebaf2b
svn: r46747
102 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-18 17:05:23 +0000
Twenty Twenty: Fix typos in a variable name and inline comment in `assets/js/color-calculations.js`.
Props tanvirul.
Fixes #48704.
No action taken yet
git: 5e574eb
svn: r46746
103 of 3124
Author
Andrea Fercia <[email protected]> 2019-11-18 16:49:42 +0000
Accessibility: Add an `aria-current` attribute to the Media Library switch links.
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.
No action taken yet
git: 72e66c1
svn: r46745
104 of 3124
Author
Andrea Fercia <[email protected]> 2019-11-18 16:21:37 +0000
Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven.
See #43169.
Fixes #48588.
No action taken yet
git: 22eb74c
svn: r46744
105 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-18 13:16:54 +0000
Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`.
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.
No action taken yet
git: f64a6a8
svn: r46743
106 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-18 07:57:47 +0000
Taxonomy: Correct the initial value for `WP_Taxonomy::$labels` to match `get_taxonomy_labels()` return type.
Improve documentation for consistency with `WP_Post_Type::$labels`.

Props alpipego.
Fixes #48681.
No action taken yet
git: e686018
svn: r46742
107 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-17 16:14:37 +0000
Docs: Update broken source code link in `WP_Filesystem_SSH2` class.
Props mryoga, finchps.
Fixes #48467.
No action taken yet
git: 8781a41
svn: r46741
108 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-17 16:12:43 +0000
Docs: Update broken source code link in `imgAreaSelect` jQuery plugin.
Props mryoga, finchps.
See #48467.
No action taken yet
git: b99845d
svn: r46740
109 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-17 11:09:05 +0000
Docs: Replace Codex URLs with corresponding HelpHub articles in `wp-config-sample.php`.
Props sebastienserre.
Fixes #48680.
No action taken yet
git: 7bb2a56
svn: r46739
110 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-17 07:41:49 +0000
Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
Props garrett-eclipse.
Fixes #48676.
No action taken yet
git: 24de36b
svn: r46738
111 of 3124
Author
SergeyBiryukov <[email protected]> 2019-11-16 21:02:02 +0000
Docs: Fix typo in `wp_credits_section_title()` description.
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Fixes #48674.
No action taken yet
git: aa99cfb
svn: r46737
112 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-16 16:34:18 +0000
Editor: Pass `$editor_id` parameter to `tiny_mce_plugins`, `mce_external_plugins`, and `mce_external_languages` filters, for consistency with `teeny_mce_plugins`.
Document the `classic-block` value passed to various editor filters in `wp_tinymce_inline_scripts()`.

Add missing `@since` entries for the existing `$editor_id` parameter in various filters.

Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441.
No action taken yet
git: 81f92c6
svn: r46736
113 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-16 11:17:42 +0000
Security: Add WordPress 5.3.x to the "Supported Versions" section of GitHub Security Policy.
Props imath.
Fixes #48667. See #48521.
No action taken yet
git: a2b561e
svn: r46735
114 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-15 23:44:17 +0000
Security: Add a GitHub Security Policy.
As part of more responsible security disclosure, we are adding a security policy to GitHub.

Fixes #48521.
Props whyisjake, ayeshrajans.
No action taken yet
git: 90ad63f
svn: r46734
115 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-15 23:22:19 +0000
Toolbar: Properly escape the onclick attribute.
The onclick attribute was being escaped twice, once with `esc_js` and again with `esc_attr`.

Fixes #48117.
Props tmatsuur, dinhtungdu.
No action taken yet
git: e879f7d
svn: r46733
116 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-15 08:57:03 +0000
Docs: Improve a comment about `$doing_wp_cron` global in `wp-cron.php`.
Props chinteshprajapati, subrataemfluence, nielslange.
Fixes #46104.
No action taken yet
git: 6cf77db
svn: r46732
117 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-14 09:55:21 +0000
Docs: Remove incorrect `@return` tags.
Props diddledan.
Fixes #48613, #48614.
No action taken yet
git: 1b55f9d
svn: r46731
118 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-14 08:53:16 +0000
Docs: Correct parameter type for `$item` in `WP_REST_Terms_Controller::prepare_item_for_response()`.
Props diddledan, TimothyBlynJacobs.
Fixes #48616.
No action taken yet
git: b3c54e6
svn: r46730
119 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-13 13:44:00 +0000
Docs: Fix typo in `@return` value for `PO::trim_quotes()`.
Props diddledan.
Fixes #48572.
No action taken yet
git: f420222
svn: r46729
120 of 3124
Author
John Blackbourn <[email protected]> 2019-11-12 22:40:29 +0000
Docs: Correct some invalid hook docblocks.
See #48303
No action taken yet
git: 6d27a05
svn: r46724
121 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-12 18:28:40 +0000
Help/About: Move images to the CDN.
Props ryelle.
Fixes #47708.
No action taken yet
git: 2a3cbd8
svn: r46722
122 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-12 18:22:39 +0000
Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see https://github.com/WordPress/twentytwenty/compare/fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.
No action taken yet
git: 1047d80
svn: r46720
123 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-12 17:49:24 +0000
Bundled Themes: Update copyright year in `readme.txt` for Twenty Twelve and Twenty Twenty.
Follow-up to [46719].

See #48566.
No action taken yet
git: 6c776ea
svn: r46719
124 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-12 17:34:05 +0000
Bundled Themes: Update copyright year in `readme.txt`.
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Fixes #48566.
No action taken yet
git: eabc288
svn: r46715
125 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-12 02:04:14 +0000
Bundled Themes: Update Twenty Twenty.
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see https://github.com/WordPress/twentytwenty/compare/162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.
No action taken yet
git: 732a358
svn: r46713
126 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-12 01:42:20 +0000
Bundled Themes: Update Twenty Twenty.
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see https://github.com/WordPress/twentytwenty/compare/ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.
No action taken yet
git: 14df171
svn: r46711
127 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 20:54:49 +0000
Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways.
Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557.
No action taken yet
git: 895ec72
svn: r46709
128 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 20:43:48 +0000
Help/About: Update the 5.3 About page.
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.
No action taken yet
git: 91312ab
svn: r46707
129 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-11 18:48:06 +0000
Tests: Fix a typo in an inline comment.
Fix a regression from [46568].

Props david.binda.
See #48312.
No action taken yet
git: 385d079
svn: r46705
130 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 16:05:39 +0000
Help/About: Update the 5.3 About page.
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.

Previously [46556], [46572], [46616].

Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708.
No action taken yet
git: e4edcf9
svn: r46703
131 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 15:08:43 +0000
Script Loader: In `wp_default_packages_inline_scripts()`, make sure the root URL middleware is registered before using the media middleware.
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.

Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Fixes #48542.
No action taken yet
git: fdeb2ff
svn: r46702
132 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 12:57:54 +0000
Twenty Twenty: Fix WPCS issue in [46701].
See #48557.
No action taken yet
git: 41a47a0
svn: r46701
133 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 12:27:21 +0000
Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see https://github.com/WordPress/twentytwenty/compare/c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.
No action taken yet
git: ae487b5
svn: r46700
134 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 11:49:29 +0000
Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press.
Follow-up to [45790].

Props raamdev.
Fixes #48543. See #41545.
No action taken yet
git: 1ee0c8e
svn: r46698
135 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 09:58:17 +0000
Customize: Remove the deprecated `-precomposed` suffix from `apple-touch-icon` link in `wp_site_icon()`.
Props mukto90, khag7.
Fixes #48555.
No action taken yet
git: 188f809
svn: r46697
136 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 09:51:09 +0000
Networks and Sites: Pass the `$blog_id` parameter to the `newblog_notify_siteadmin` filter.
Props mukto90, virgodesign.
Fixes #48554.
No action taken yet
git: cde71ee
svn: r46696
137 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 02:41:15 +0000
Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`.
See #48303.
No action taken yet
git: 63a5340
svn: r46695
138 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-11 00:03:53 +0000
Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`.
See #48303.
No action taken yet
git: 84540ab
svn: r46694
139 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-10 23:03:34 +0000
Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`.
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352.
No action taken yet
git: 1b82ea8
svn: r46693
140 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-10 01:53:17 +0000
Tests: Don't skip the tests intended for Multisite when running on single site, add them to the `ms-required` group instead.
See #43438.
No action taken yet
git: a311331
svn: r46692
141 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-10 01:43:55 +0000
Coding Standards: Fix WPCS issue in [46690].
See #41880.
No action taken yet
git: a9b3e85
svn: r46691
142 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-10 01:41:43 +0000
Docs: Move the `@link` tag for Customize API in `WP_Customize_Manager::add_setting()` and `WP_Customize_Setting` to a more appropriate place.
See #48303.
No action taken yet
git: 99132f8
svn: r46690
143 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-10 01:17:00 +0000
Docs: Improve documentation for `WP_Http` per the documentation standards.
Props hareesh-pillai, adnan.limdi, isabel_brison.
Fixes #41880.
No action taken yet
git: 00aff3a
svn: r46689
144 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 13:55:43 +0000
Docs: Use 3-digit, x.x.x style semantic versioning for `$version` argument in `do_action_deprecated()` and `apply_filters_deprecated()` calls.
Props jrf.
Fixes #48255.
No action taken yet
git: 67e82bc
svn: r46688
145 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 13:41:29 +0000
Docs: Correct the documentation placement for `wp_print_styles` and `shortcode_atts_{$shortcode}` hooks.
Props jrf.
See #48255.
No action taken yet
git: 36994ef
svn: r46687
146 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 13:31:07 +0000
Coding Standards: Fix WPCS issue in [46684].
See #48255.
No action taken yet
git: 51d6408
svn: r46686
147 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 13:29:14 +0000
Coding Standards: Revert the change to `wp-includes/class-wp-xmlrpc-server.php` in [46684] to investigate unit test failures.
See #48255.
No action taken yet
git: 26dec96
svn: r46685
148 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 13:03:02 +0000
Docs: Use the `{@see ...}` tag for the replacement in `@deprecated` tags, so that Developer Reference could automatically link to the replacement.
Props jrf.
See #48255.
No action taken yet
git: ae2ebb8
svn: r46684
149 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 12:57:27 +0000
Coding Standards: Consistently use `do_action_deprecated()` and `apply_filters_deprecated()` for deprecated hooks.
Props jrf.
See #48255.
No action taken yet
git: 243d1a2
svn: r46683
150 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 03:44:51 +0000
Test: Don't skip the tests intended for single site when running on Multisite, add them to the `ms-excluded` group instead.
See #39776, #45747.
No action taken yet
git: fcf86b8
svn: r46682
151 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 03:36:19 +0000
Tests: Skip `test_readme()` if the HTTP request to `secure.php.net` or `dev.mysql.com` failed on timeout.
Move `skipTestOnTimeout()` to `WP_UnitTestCase_Base` to avoid duplication.

See #44613.
No action taken yet
git: 9b1fc27
svn: r46681
152 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-09 00:01:40 +0000
Docs: Correct some inconsistencies in comments with Dashicon class references in `wp-admin/css/customize-widgets.css`.
Prepend all class name references with `dashicons-` for clarity.

Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417.
No action taken yet
git: 4a73b56
svn: r46679
153 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-08 22:54:33 +0000
Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations.
Props skithund.
Fixes #48422.
No action taken yet
git: a216b6d
svn: r46678
154 of 3124
Author
John Blackbourn <[email protected]> 2019-11-08 13:17:35 +0000
Toolbar: Un-deprecate the `WP_Admin_Bar::add_menu()` method.
This is only a wrapper for the `add_node()` method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.

Props whyisjake

Fixes #19647
No action taken yet
git: 698aa0e
svn: r46677
155 of 3124
Author
Andrew Ozz <[email protected]> 2019-11-07 18:49:17 +0000
Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
Props desrosj, azaozz.
Fixes #48518 for trunk.
No action taken yet
git: 3dca77e
svn: r46676
156 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-07 15:17:02 +0000
Bundled Themes: Standardize the Required PHP and Tested Up To headers.
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Fixes #48517.
No action taken yet
git: 4185cf7
svn: r46675
157 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-07 07:10:38 +0000
Docs: Make `@param` tags in `mce_buttons` and related filters consistent with the variable names.
Props upadalavipul, isabel_brison.
Fixes #41456.
No action taken yet
git: 75f82d8
svn: r46674
158 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-06 01:15:11 +0000
Tests: Properly mark `test_submenu_helpers_priority()` as skipped for multisite, so it's not categorized as "risky".
See #39776.
No action taken yet
git: 9c3319d
svn: r46671
159 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-05 23:17:01 +0000
Coding Standards: Fix WPCS issues in [46670].
See #48145.
No action taken yet
git: bd2130f
svn: r46670
160 of 3124
Author
John Blackbourn <[email protected]> 2019-11-05 22:39:37 +0000
REST API: Use explicit dates in a post ordering test to avoid indeterminate ordering.
See #48145
No action taken yet
git: 560b682
svn: r46668
161 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-05 22:20:52 +0000
Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see https://github.com/WordPress/twentytwenty/compare/dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.
No action taken yet
git: 1842040
svn: r46665
162 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-05 22:02:03 +0000
Emoji: Upgrade Twemoji to 12.1.3.
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.

Props matstars, desrosj, Otto42, pento.
Fixes #48293.
No action taken yet
git: ed4b67b
svn: r46664
163 of 3124
Author
John Blackbourn <[email protected]> 2019-11-05 21:57:47 +0000
Block Editor: Revert [46663] which was itself an erroneous revert.
See #48502
No action taken yet
git: afecdb2
svn: r46663
164 of 3124
Author
John Blackbourn <[email protected]> 2019-11-05 21:51:30 +0000
Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
Merges [46656] to the 5.3 branch.
Fixes #48502
No action taken yet
git: 4658108
svn: r46662
165 of 3124
Author
John Blackbourn <[email protected]> 2019-11-05 21:28:51 +0000
Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes.
See #48303
No action taken yet
git: 3cdee7a
svn: r46661
166 of 3124
Author
John Blackbourn <[email protected]> 2019-11-05 21:25:53 +0000
Docs: Further improve documentation of known return types, plus other docs fixes.
See #48303
No action taken yet
git: db4f746
svn: r46660
167 of 3124
Author
John Blackbourn <[email protected]> 2019-11-05 21:21:46 +0000
Docs: Improve documentation of known return types, plus other docs fixes.
See #48303
No action taken yet
git: 63d4dcd
svn: r46658
168 of 3124
Author
Andrew Ozz <[email protected]> 2019-11-05 20:51:12 +0000
Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image.
Props ianmjones, azaozz.
Fixes #48453 for trunk.
No action taken yet
git: 4a729f0
svn: r46657
169 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-05 20:41:12 +0000
REST API: Speed up pagination unit tests by creating less fixtures and reusing them where possible.
Includes minor documentation and code layout fixes for better readability.

See #30017, #48145.
No action taken yet
git: 4cee80b
svn: r46656
170 of 3124
Author
Jorge Costa <[email protected]> 2019-11-05 19:34:07 +0000
Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
The list of included fixes is:

https://github.com/WordPress/gutenberg/pull/18183
https://github.com/WordPress/gutenberg/pull/18194
https://github.com/WordPress/gutenberg/pull/18230
https://github.com/WordPress/gutenberg/pull/18275
https://github.com/WordPress/gutenberg/pull/18287

Updated packages:
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]

Props @aduth, @mcsf, @youknowriad, @johnbillion.
Fixes #48502.
No action taken yet
git: 969285d
svn: r46654
171 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-05 17:36:31 +0000
REST API: Fix for Yoda condition.
Little coding standards fix for the REST API.

Props mukesh27, spenserhale.

Fixes #48337.
No action taken yet
git: f6cb28a
svn: r46652
172 of 3124
Author
John Blackbourn <[email protected]> 2019-11-04 17:48:55 +0000
Docs: Correct and improve the readability of some parameters of `WP_Term_Query`.
See #48303
No action taken yet
git: 9ed5e8c
svn: r46651
173 of 3124
Author
Andrew Ozz <[email protected]> 2019-11-04 17:05:53 +0000
Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it.
See #48472.
No action taken yet
git: 20165c2
svn: r46650
174 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-04 15:04:41 +0000
Login and Registration: Simplify the test for `wp_signon()` added in [46640].
Make sure it actually tests the change in behavior, previously it passed both before and after the patch.

Add `wp_unslash()` to the last remaining instance of `$_POST['user_login']` that didn't have it.

See #38744.
No action taken yet
git: c231bb4
svn: r46649
175 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-04 12:57:17 +0000
Build/Test Tools: Adjust the test for `wp_redirect()` status codes added in [46641] per the documentation and coding standards.
Move the test to a more appropriate place for consistency with `wp_sanitize_redirect()` and `wp_validate_redirect()` tests.

See #44317.
No action taken yet
git: c04078a
svn: r46648
176 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-04 12:34:35 +0000
REST API: Set `orderby` parameter in tax relation unit tests added in [46646].
The default value of `date` caused a race condition resulting in random test failures.

See #44326.
No action taken yet
git: ec5f103
svn: r46647
177 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-04 09:35:59 +0000
Docs: Correct some array hash notations added in [46644].
See #48303.
No action taken yet
git: a104c82
svn: r46646
178 of 3124
Author
Timothy Jacobs <[email protected]> 2019-11-03 23:12:44 +0000
REST API: Add tax relation parameter to posts collection.
The REST API supports filtering by terms across multiple taxonomies using an AND relation. This adds support for an OR relation by adding "tax_relation=OR" as a query parameter.

Props earnjam.
Fixes #44326.
No action taken yet
git: 20d984f
svn: r46645
179 of 3124
Author
Aaron Jorbin <[email protected]> 2019-11-03 22:47:52 +0000
Remove Failing Tests added in r46641
The tests for good redirects send headers that we can't handle in the test suite, so let's just remove them.

Unprops Jorbin.
Fixes #44317.
No action taken yet
git: 27b67d5
svn: r46644
180 of 3124
Author
John Blackbourn <[email protected]> 2019-11-03 22:21:20 +0000
Docs: Fix some incorrect return tags in docblocks.
See #48303
No action taken yet
git: 8336614
svn: r46643
181 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-03 22:16:27 +0000
Coding Standards: Clean up the tests around `test_that_you_can_login_with_an_email_that_has_apostrophe`.
Let's use the proper coding standards for the comments.

Fixes #38744.
Props cafenoirdesign.
No action taken yet
git: 922721c
svn: r46642
182 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-03 22:12:32 +0000
Toolbar: Use `add_node()` instead of `add_menu()` in core.
This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)

Fixes: #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.
No action taken yet
git: 40946e9
svn: r46641
183 of 3124
Author
Aaron Jorbin <[email protected]> 2019-11-03 22:08:56 +0000
General: wp_safe_redirect() and wp_redirect() shouldn't allow non-3xx status codes
Redirects should use redirect status codes and if you attempt to call wp_safe_redirect or wp_redirect with a non redirect status it can lead to undesired behavior and head scratching.

Fixes #44317.
Props spenserhale, johnbillion, mjnewman for initial patch.
No action taken yet
git: 84c794b
svn: r46640
184 of 3124
Author
Jake Spurlock <[email protected]> 2019-11-03 20:10:23 +0000
Login and Registration: Allow email logins to be more flexible.
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.

Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.
No action taken yet
git: 9d88dba
svn: r46638
185 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-03 17:07:42 +0000
External Libraries: Revert [46634-46635].
On further investigation, Plupload changed it’s license to a non-GPL compatible license. The newest, GPL compatible version is being used already in Core.

Unprops desrosj.
See #48277.
No action taken yet
git: 6d41359
svn: r46637
186 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-03 16:46:55 +0000
Customize: Formally deprecate unused Customizer classes.
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.

Props weston.ruter, matthias-reuter, jrf.
Fixes #42364.
No action taken yet
git: ab36135
svn: r46636
187 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-03 16:19:15 +0000
Add `svn:auto-props` for `eol-style` and `mime-type` to `trunk`.
`svn:eol-style` and `svn:mime-type` property default values are now provided for all file types currently in `trunk`.

This also reverts the `eol-style` change to `wp-config-sample.php` made in [46586].

Fixes #42594.
No action taken yet
git: 0a9437d
svn: r46635
188 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-03 15:32:04 +0000
Remove unintended change to `svn:ignore` in [46634].
No action taken yet
git: 669e701
svn: r46634
189 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-11-03 15:29:46 +0000
External Libraries: Update Plupload from 2.1.9 to 2.3.6.
This change also updates the MoxieJS dependency from 1.3.5 to 1.5.7, converts Plupload to a dependency in NPM, and integrates all relevant parts into the build process.

For a full list of upstream changes, see https://github.com/moxiecode/plupload/compare/v2.1.9...v2.3.6.

Props desrosj, hareesh-pillai.
Fixes #48277.
No action taken yet
git: b0cdad7
svn: r46633
190 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-03 10:54:39 +0000
General: Wrap the error message in `_deprecated_constructor()` in `<code>` tags instead of `<pre>`.
Props aftabmuni.
Fixes #48483.
No action taken yet
git: 358364e
svn: r46632
191 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-02 20:47:44 +0000
Code Modernization: Call PHP 5 constructors in methods extending `POMO_Reader`.
Follow-up to [46629].

See #48252.
No action taken yet
git: 74795ca
svn: r46631
192 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-02 20:28:31 +0000
Docs: Correct version number in `@deprecated` tags for PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
Follow-up to [46629].

Props jrf.
See #48252.
No action taken yet
git: d3f486e
svn: r46630
193 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-02 20:11:20 +0000
Docs: Correct `@see` references for PHP 4 constructors in `wp-includes/class-json.php`.
See #48252, #48303.
No action taken yet
git: 168bb48
svn: r46629
194 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-02 20:09:35 +0000
Docs: Add missing `@deprecated` tags to PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
Props jrf.
Fixes #48252.
No action taken yet
git: 095ef4a
svn: r46628
195 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-02 20:06:55 +0000
Twenty Eleven: Add missing `@deprecated` tag to PHP 4 constructor in `Twenty_Eleven_Ephemera_Widget`.
Props jrf.
See #48252.
No action taken yet
git: dcced77
svn: r46627
196 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-02 20:04:27 +0000
Docs: Add missing `@deprecated` tags to PHP 4 constructors in `WP_Widget` and `WP_Widget_Factory()`.
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].

Props jrf.
See #48252.
No action taken yet
git: 00384f9
svn: r46626
197 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-01 14:55:51 +0000
Docs: Update URLs in some `@link` tags and switch them to HTTPS.
Props tsuyoring.
Fixes #48479.
No action taken yet
git: 8962187
svn: r46625
198 of 3124
Author
Sergey Biryukov <[email protected]> 2019-11-01 00:39:04 +0000
Code Modernization: Pass an appropriate error level to `trigger_error()` in `_doing_it_wrong()` and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.

Props jrf.
Fixes #36561.
No action taken yet
git: 3623ab0
svn: r46624
199 of 3124
Author
johnbillion <[email protected]> 2019-10-31 21:18:01 +0000
Docs: Correct some more invalid inline docs.
See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description

See #48303
No action taken yet
git: 669cefe
svn: r46623
200 of 3124
Author
John Blackbourn <[email protected]> 2019-10-31 17:49:12 +0000
Docs: Correct some incorrect docblock tags.
See #48303
No action taken yet
git: fe9b176
svn: r46622
201 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-31 00:11:20 +0000
Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621].
See #48472.
No action taken yet
git: b9c02b3
svn: r46621
202 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-30 21:08:32 +0000
Upload:
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.
No action taken yet
git: 6582966
svn: r46620
203 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-30 02:57:16 +0000
Docs: Document `$error`, `$interim_login`, and `$action` globals in `login_header()` and `login_footer()`.
Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.
No action taken yet
git: 7d2bb9f
svn: r46616
204 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-29 20:08:32 +0000
Help/About: Update the 5.3 About page for RC3.
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.
No action taken yet
git: 5250853
svn: r46613
205 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-29 14:53:27 +0000
Bundled Themes: Update Twenty Twenty.
This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see https://github.com/WordPress/twentytwenty/compare/4549fd9...dea9290.

Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450.
No action taken yet
git: b0419af
svn: r46612
206 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-29 14:26:41 +0000
Build/Test Tools: Ignore EOL differences in tests using multiline string assertions.
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Fixes #31432. See #42594, #47411.
No action taken yet
git: c6c46a5
svn: r46610
207 of 3124
Author
John Blackbourn <[email protected]> 2019-10-28 19:46:13 +0000
Docs: Miscellaneous docblock corrections.
See #48303
No action taken yet
git: 38dd307
svn: r46609
208 of 3124
Author
John Blackbourn <[email protected]> 2019-10-28 19:33:24 +0000
Docs: Coding standards fix after [46608].
See #48303
No action taken yet
git: 0cd24d5
svn: r46608
209 of 3124
Author
John Blackbourn <[email protected]> 2019-10-28 19:02:31 +0000
Docs: Remove some funky nested filters.
See #48303
No action taken yet
git: 7548aa8
svn: r46607
210 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-28 15:15:51 +0000
Docs: Restore correct placement for duplicate hook reference in `render_block_core_latest_comments()`.
Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.
No action taken yet
git: 6352823
svn: r46606
211 of 3124
Author
Riad Benguella <[email protected]> 2019-10-28 14:11:06 +0000
Block Editor: Bug fixes targetted for WordPress 5.3 RC3.
The list of included fixes is:

- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102

Updated packages:
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]

Props desrosj.
See #48447.
No action taken yet
git: cf01483
svn: r46605
212 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-28 04:15:37 +0000
Build/Test Tools: Don't hardcode the directory name of the repo
When Travis builds the directory, it was looking for a hardcoded `wordpress-develop` directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.
Props pento, whyisjake.
No action taken yet
git: 8c21607
svn: r46604
213 of 3124
Author
John Blackbourn <[email protected]> 2019-10-27 19:33:12 +0000
Docs: Correct invalid hook docblock placement.
See #48303
No action taken yet
git: b422cc2
svn: r46603
214 of 3124
Author
John Blackbourn <[email protected]> 2019-10-27 19:09:10 +0000
Docs: Correct invalid hook docblocks.
See #48303
No action taken yet
git: 6ac79fe
svn: r46602
215 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-27 14:19:13 +0000
Docs: Remove "private" designation from `_doing_it_wrong()` and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.
No action taken yet
git: f06419d
svn: r46601
216 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-27 14:06:04 +0000
Editor: Fix typo in an error message in `WP_Block_Styles_Registry::register()`.
Props man4toman, alishankhan, shaampk1.
Fixes #48437.
No action taken yet
git: fa02b89
svn: r46600
217 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-27 14:05:18 +0000
Docs: Improve DocBlock formatting in `WP_Block_Styles_Registry` per the documentation standards.
See #48303.
No action taken yet
git: 1ec1c58
svn: r46599
218 of 3124
Author
John Blackbourn <[email protected]> 2019-10-26 23:47:04 +0000
Docs: Correct and improve inline docs for the file type functions.
See #48303
No action taken yet
git: e228178
svn: r46598
219 of 3124
Author
John Blackbourn <[email protected]> 2019-10-26 23:44:02 +0000
Docs: Add missing docs for the `auth_cookie_bad_session_token` action.
See #48303
No action taken yet
git: 3559504
svn: r46597
220 of 3124
Author
John Blackbourn <[email protected]> 2019-10-26 23:14:59 +0000
Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
See #48303
No action taken yet
git: 4f281f1
svn: r46596
221 of 3124
Author
John Blackbourn <[email protected]> 2019-10-26 21:07:10 +0000
Docs: Switch more docs over to typed array notation, plus some fixes.
See #48303, #41756
No action taken yet
git: e07cf22
svn: r46595
222 of 3124
Author
John Blackbourn <[email protected]> 2019-10-26 21:00:08 +0000
Docs: Switch to typed array notation for the docs for asset dependency functions.
Props marekdedic

See #48303
No action taken yet
git: a2e0803
svn: r46594
223 of 3124
Author
John Blackbourn <[email protected]> 2019-10-26 20:42:00 +0000
Docs: Miscellaneous docblock fixes and improvements.
See #48303
No action taken yet
git: c951d94
svn: r46593
224 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-26 17:28:20 +0000
Docs: Improve documentation for `esc_attr_e()`, `esc_html_e()`, `esc_attr_x()`, `esc_html_x()`.
Props atachibana.
Fixes #48383.
No action taken yet
git: e2c34a7
svn: r46592
225 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-26 00:56:50 +0000
Docs: Improve documentation for `wptexturize()`.
Props atachibana.
Fixes #48397.
No action taken yet
git: 21ce200
svn: r46591
226 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-26 00:34:10 +0000
Docs: Improve formatting of various `WP_Screen` DocBlocks.
See #48303.
No action taken yet
git: d490968
svn: r46590
227 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-26 00:32:20 +0000
Docs: Improve documentation for `WP_Screen::add_help_tab()`.
Props atachibana.
Fixes #48395.
No action taken yet
git: 354fc5c
svn: r46589
228 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-26 00:15:53 +0000
Build/Test Tools: Add banner to RTL CSS and minified JS files.
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.
No action taken yet
git: 59ae54b
svn: r46588
229 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-25 19:31:54 +0000
Ensure `svn:mime-type` is consistently set for appropriate files.
Continuation of [46586], [46587]

See #42594.
No action taken yet
git: 10c787f
svn: r46587
230 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-25 19:27:49 +0000
Ensure `svn:eol-style` is consistently set for all files (part 2).
Continuation of [46586]

See #42594.
No action taken yet
git: d376fed
svn: r46586
231 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-25 16:36:41 +0000
Ensure `svn:eol-style` is consistently set for all files.
See #42594.
No action taken yet
git: 3646ed7
svn: r46585
232 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-25 15:34:43 +0000
Remove the `svn:executable` property from files that don't need it.
See #42594.
No action taken yet
git: ee52275
svn: r46583
233 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-25 15:09:30 +0000
Date/Time: Remove incomplete and redundant test for `get_post_time()` added in [46580].
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

See #48384.
No action taken yet
git: 4b1dd6e
svn: r46582
234 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-25 14:22:40 +0000
Trunk is now 5.4 alpha.
No action taken yet
git: c67b47c
svn: r46580
235 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-25 13:06:29 +0000
Date/Time: Make sure `get_post_time()` keeps UTC time on timezone change.
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.
No action taken yet
git: db4e52b
svn: r46579
236 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-25 12:52:46 +0000
Posts, Post Types: Remove unintended change from [46578].
See #48384.
No action taken yet
git: 9a9abc0
svn: r46578
237 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-25 12:49:40 +0000
Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp.
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
No action taken yet
git: 38b4ecf
svn: r46577
238 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-25 11:03:13 +0000
Date/Time: Make sure `date_i18n()` correctly handles zero timestamp after [45901].
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.
No action taken yet
git: 2092a37
svn: r46576
239 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-25 00:22:14 +0000
Build/Test Tools: Update the `https-proxy-agent` dependency.
Fixes #48428.
No action taken yet
git: 5952a5d
svn: r46575
240 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-23 20:55:31 +0000
Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241].
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.
No action taken yet
git: aa34f0d
svn: r46574
241 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-22 20:09:15 +0000
Post WordPress 5.3 RC2 version bump.
No action taken yet
git: 1b411f9
svn: r46573
242 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-22 19:43:01 +0000
WordPress 5.3 RC2.
No action taken yet
git: 3bf7246
svn: r46572
243 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-22 19:17:59 +0000
Help/About: Update the 5.3 About page for RC2.
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.
No action taken yet
git: a8fa073
svn: r46571
244 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-22 18:25:45 +0000
Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see https://github.com/WordPress/twentytwenty/compare/bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.
No action taken yet
git: 7ee1e12
svn: r46570
245 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-22 17:50:45 +0000
Administration: Relax the default value check for the `$position` argument added to `add_submenu_page()` and related functions in [46197].
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
No action taken yet
git: 747f8e2
svn: r46569
246 of 3124
Author
SergeyBiryukov <[email protected]> 2019-10-22 17:29:02 +0000
Date/Time: Make sure `wp_date()` does not unnecessarily escape localized numbers, but keeps localized slashes.
Props Rarst, tmatsuur, remcotolsma, peterwilsoncc.
Reviewed by peterwilsoncc.
Fixes #48319.
No action taken yet
git: 99d5986
svn: r46568
247 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-22 00:09:39 +0000
Plugins: Restore backward compatibility for PHP4-style passing of `array( &$this )` as action argument to `do_action()`.
This is a follow-up to [46149] to avoid unnecessary breakage in case of using the old notation.

Props david.binda, jrf.
Reviewed by azaozz.
Fixes #48312.
No action taken yet
git: 67a937a
svn: r46567
248 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-21 23:21:51 +0000
Media: After [46237] add the same fix to the `.button-group` on the "Insert form URL" screen in the media modal.
Props afercia, sabernhardt.
FIxes #48087.
No action taken yet
git: 295acd4
svn: r46566
249 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-21 22:42:02 +0000
Upload: Expand error codes to include all 5xx HTTP errors when retrying to create image sub-sizes. Some servers may be configured to set HTTP 508 or 504, or possibly other `5` errors.
Porps mikeschroder, azaozz.
Fixes #48379.
No action taken yet
git: c424187
svn: r46565
250 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-21 21:41:09 +0000
Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append `scaled-` to the file names of the scaled images to make them easier to recognize.
Props kraftbj, azaozz.
Fixes #48304.
No action taken yet
git: 1f7f0a1
svn: r46564
251 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-21 20:39:16 +0000
Comments: Add `rel="nofollow ugc"` attribute when converting plain URLs to `<a>` tags in comments via `make_clickable()`.
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.
No action taken yet
git: 56aa018
svn: r46563
252 of 3124
Author
K. Adam White <[email protected]> 2019-10-21 19:08:34 +0000
REST API: Cast empty meta values to correct scalar types in REST response.
Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.
No action taken yet
git: 0ad9c82
svn: r46562
253 of 3124
Author
Riad Benguella <[email protected]> 2019-10-21 14:00:13 +0000
Block Editor: Update Packages that include WP 5.3 RC2 fixes.
Updated packages:
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]

Props gziolo.
Fixes #48381.
No action taken yet
git: 3cd121d
svn: r46561
254 of 3124
Author
John Blackbourn <[email protected]> 2019-10-17 18:36:27 +0000
Administration: Revert changes to the admin menu styles for long line lengths.
This reverts [46555], [46453], and [46332].

See #42201
No action taken yet
git: 3e6c0fb
svn: r46560
255 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-16 21:01:22 +0000
Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing.
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.
No action taken yet
git: aa37e6e
svn: r46559
256 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-16 17:47:28 +0000
Script Loader: Partially revert [46550] as it brought in unrelated CSS changes.
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.
No action taken yet
git: 31ae9e0
svn: r46558
257 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-15 21:12:48 +0000
Post WordPress 5.3 RC1 version bump
No action taken yet
git: 52151d5
svn: r46557
258 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-15 20:48:59 +0000
WordPress 5.3 RC1
No action taken yet
git: c0cb230
svn: r46556
259 of 3124
Author
John Blackbourn <[email protected]> 2019-10-15 20:40:05 +0000
Help/About: Let's tell the world about 5.3.
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald

Thanks to everyone who provided feedback for this page for 5.3.

See #47708
No action taken yet
git: 9d2aa0f
svn: r46555
260 of 3124
Author
John Blackbourn <[email protected]> 2019-10-15 19:37:03 +0000
Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed.
Props afercia, amolv, sabernhardt

Fixes #42201, #48294
No action taken yet
git: 943fa44
svn: r46554
261 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-15 19:34:31 +0000
Shortcodes: Revert [46369] for now to allow more time to investigate and prepare for backward compatibility changes.
Also reverts follow-up changes in [46370] and [46465].

See #47863.
No action taken yet
git: d5f11a9
svn: r46553
262 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-15 19:10:53 +0000
Media: Similarly to `wp_get_original_image_path()` add `wp_get_original_image_url()` to always retrieve the URL to the original uploaded image.
Props kraftbj.
Fixes #48302.
No action taken yet
git: 7fdb0e7
svn: r46552
263 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-15 18:51:42 +0000
Build/Test Tools: Move PHP 7.4 to the top of the list for consistency.
See #48232.
No action taken yet
git: 2b3fc32
svn: r46551
264 of 3124
Author
desrosj <[email protected]> 2019-10-15 18:45:02 +0000
Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see https://github.com/WordPress/twentytwenty/compare/7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.
No action taken yet
git: 943320f
svn: r46550
265 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-15 17:21:50 +0000
Accessibility: Script Loader: Remove jQuery as dependency of `admin-bar` after [46440].
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.
No action taken yet
git: 6e133af
svn: r46549
266 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-15 16:45:08 +0000
Accessibility: Media: Improve the Media Modal spinner position after [46418].
Fixes #47138.
No action taken yet
git: 3fb04ab
svn: r46548
267 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-15 16:41:51 +0000
Customize: Ensure that `WP_Customize_Manager::import_theme_starter_content()` properly handles starter content with (nested) arrays as values.
Previously, searching for symbol references to replace with post or attachment IDs in array values resulted in a PHP warning.

Props timph, JarretC, SergeyBiryukov.
Fixes #45484.
No action taken yet
git: 8a8d016
svn: r46547
268 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-15 16:36:42 +0000
Build/Test: Remove PHP 7.4 from allowed failures
PHP7.4 is supported in WordPress 5.3. :elephant: :tada:

Fixes: #48232.
No action taken yet
git: 849e070
svn: r46546
269 of 3124
Author
Jorge Costa <[email protected]> 2019-10-15 16:15:50 +0000
Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.8 release.
Updated packages:
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]

Props gziolo, youknowriad.
Fixes: #48310
No action taken yet
git: 3b2c656
svn: r46544
270 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-15 15:45:39 +0000
REST API: Allow for multiple Vary: Origin headers in GET responses.
Simple fix, we pass `false` as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.
No action taken yet
git: 78d3ff3
svn: r46543
271 of 3124
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2019-10-15 15:35:03 +0000
Block Editor: Remove experimental Social Links blocks
We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release.

Props youknowriad.

Fixes #48263.
No action taken yet
git: b4d3499
svn: r46542
272 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-15 14:40:31 +0000
Build/Test tools use Trunk revision 2170172 of importer
Update Travis configuration to temporarily use trunk for the importer in order for PHP 7.4 tests to pass. When the new version is released, this will be updated to point to that tag.

See: #48231
No action taken yet
git: 5df589d
svn: r46507
273 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-14 20:03:01 +0000
Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging.
Fixes #40439.
No action taken yet
git: 329e042
svn: r46506
274 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-14 19:54:36 +0000
Uploads: Retry to post-process images after HTTP 500 and HTTP 502 errors.
Props mikeschroder, azaozz.
Fixes #47872.
No action taken yet
git: d2da46a
svn: r46489
275 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-14 18:01:53 +0000
Accessibility: Media: Improve the text of the Media Modal actions toggle button displayed in the responsive view.
See #47149.
No action taken yet
git: ab8e929
svn: r46488
276 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-14 17:56:41 +0000
Accessibility: Media: Improve the new Media Modal headings text.
See #47610.
No action taken yet
git: 778bf0c
svn: r46485
277 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 17:13:35 +0000
Administration: Ensure that admin referer nonce is valid.
Fix for a testing regression.

Props desrosj.
Backported in 30c498e
git: 4e2d91d
svn: r46483
278 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 16:23:13 +0000
REST API: Ensure that we don't generate warnings from sending extra headers after headers have been sent.
Fixes issues stemming from [46478].
Backported in 30c498e
git: 2a5c167
svn: r46478
279 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 15:41:05 +0000
REST API: Send a Vary: Origin header on GET requests.
Add this header on all GET requests to prevent cached requests.

Props darthhexx, davidbinda, nickdaugherty, whyisjake.
Backported in 30c498e
git: f53a78f
svn: r46477
280 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 15:38:14 +0000
Administration: Ensure that admin referer nonce is valid.
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.
Backported in 30c498e
git: f06c6bb
svn: r46476
281 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 15:29:25 +0000
Filesystem API: Prevent directory travelersals when creating new folders.
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.
Backported in 30c498e
git: af8afb9
svn: r46475
282 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 15:25:38 +0000
HTTP API: Protect against hex interpretation.
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.
Backported in 30c498e
git: ad6c214
svn: r46474
283 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-14 15:18:49 +0000
Query: Remove the static query property.
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.
Backported in 30c498e
git: 0c75758
svn: r46472
284 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-14 10:50:41 +0000
Formatting: In `wp_validate_redirect()`, normalize the path when validating the location for relative URLs, to account for Windows paths.
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.
No action taken yet
git: a9891c7
svn: r46471
285 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-13 10:00:18 +0000
Docs: Fix typo in a comment in `WP_REST_Settings_Controller::prepare_value()`.
Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.
No action taken yet
git: 8f7174f
svn: r46470
286 of 3124
Author
Peter Wilson <[email protected]> 2019-10-13 02:46:25 +0000
Docs: Correct documentation typo in print_emoji_detection_script().
Props itowhid06.
Fixes #48298. See #47110.
No action taken yet
git: 438de1f
svn: r46469
287 of 3124
Author
Peter Wilson <[email protected]> 2019-10-13 02:40:05 +0000
Docs: Correct comment typo in WP_REST_Terms_Controller::update_item().
Props manikmist09.
Fixes #48295. See #47110.
No action taken yet
git: cda19de
svn: r46468
288 of 3124
Author
John Blackbourn <[email protected]> 2019-10-12 18:03:22 +0000
Docs: Fix and improve inline documentation for the HTTP API.
See #47110
No action taken yet
git: a8259b8
svn: r46467
289 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-12 03:08:56 +0000
Users: Make sure `wp_logout()` clears current user, so that a subsequent call to `is_user_logged_in()` works as expected.
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.
No action taken yet
git: 5729349
svn: r46466
290 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-12 03:00:32 +0000
Tests: Rename tests methods in `tests/pluggable.php` per the handbook's naming convention.
See #47632.
No action taken yet
git: 5e6d8f5
svn: r46465
291 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-12 02:48:26 +0000
Docs: Adjust `@since` note in `shortcode_parse_atts()` for consistency with similar notes.
See #47863.
No action taken yet
git: 7cd21b7
svn: r46464
292 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-12 02:40:43 +0000
I18N: Don't capitalize "Extension" in `update_core()`, for consistency with other strings.
Follow-up to [46455].

See #47699.
No action taken yet
git: e21792c
svn: r46463
293 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-12 02:33:13 +0000
Docs: Add `requires_php` to the list of fields returned by `plugins_api()`.
Props ediamin.
Fixes #48291.
No action taken yet
git: 9a6bce9
svn: r46462
294 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-11 23:52:11 +0000
Formatting: Make sure `wp_sanitize_redirect()` encodes spaces in URLs instead of stripping them out.
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.
No action taken yet
git: dcb037f
svn: r46461
295 of 3124
Author
Anthony Burchell <[email protected]> 2019-10-11 20:41:51 +0000
Media: Adds Edit Image controller to Media Library `select` frame.
This adds the necessary state for `EditImage` views in the `select` frame and listeners for setting that view.

Props fblaser, w3rkjana, afercia, antpb.
See #48028.
No action taken yet
git: 42493b7
svn: r46460
296 of 3124
Author
Anthony Burchell <[email protected]> 2019-10-11 19:20:43 +0000
Administration: Prevents horizontal scroll jumping around while admin menu is open.
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.
No action taken yet
git: 68729ad
svn: r46459
297 of 3124
Author
Mike Schroder <[email protected]> 2019-10-11 07:52:12 +0000
Media: Update fallback previews to support `_wp_make_subsizes()`
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.
No action taken yet
git: 4669376
svn: r46458
298 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-10 22:50:05 +0000
Cron: Prevent sending headers when using ALTERNATE_WP_CRON
ALTERNATE_WP_CRON echos things which causes a "Headers already sent" warning. This adds a check to ensure headers haven't already been sent.

Previously: [45560]

See: #45560. Fixes #48283.
Props dlh.
No action taken yet
git: 7a682e6
svn: r46457
299 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-10 19:05:57 +0000
Themes: Convert core-provided starter content to block content.
Props Clorith.
Fixes #48130.
No action taken yet
git: 70b408c
svn: r46456
300 of 3124
Author
K. Adam White <[email protected]> 2019-10-10 17:16:44 +0000
REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included.
Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.
No action taken yet
git: 1bcd41b
svn: r46455
301 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-09 22:20:37 +0000
Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.
No action taken yet
git: 22d50c4
svn: r46454
302 of 3124
Author
K. Adam White <[email protected]> 2019-10-09 17:34:20 +0000
REST API: Do not addslash when receiving meta arrays of non-string values.
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.

Props TimothyBlynJacobs, augustuswm.
Fixes #48264.
No action taken yet
git: c608c85
svn: r46453
303 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-09 04:56:55 +0000
Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201
No action taken yet
git: 176a3f0
svn: r46452
304 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-09 04:33:34 +0000
Docs: Tweak the `@since` note in `Walker::walk()` and `::paged_walk()` for better readability and consistency with other notes.
See #47678.
No action taken yet
git: 8ec0a21
svn: r46451
305 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-09 04:26:22 +0000
Docs: Add a `@since` note about new parameters with the spread operator added to function signatures.
Props jrf.
See #47678.
No action taken yet
git: d4e9608
svn: r46450
306 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-08 22:17:54 +0000
Bundled Themes: Update/audit NPM dependencies for Twenty Nineteen.
Also, ignore the `node_modules` folder for Twenty Nineteen.

Fixes #48262.
No action taken yet
git: 71aa81f
svn: r46449
307 of 3124
Author
Adam Silverstein <[email protected]> 2019-10-08 20:45:15 +0000
Post WordPress 5.3 Beta 3 version bump.
No action taken yet
git: 1e1ef43
svn: r46448
308 of 3124
Author
Adam Silverstein <[email protected]> 2019-10-08 19:57:09 +0000
WordPress 5.3 Beta 3.
No action taken yet
git: e20a613
svn: r46447
309 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-08 19:50:54 +0000
Bundled Themes: Fix JSHint error in [46445]
Props ianbelanger.
See #48110.
No action taken yet
git: 2aad78b
svn: r46446
310 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-08 19:19:30 +0000
Bundled Themes: Change the `eol-style` property to `native` for Twenty Twenty files.
Props aazaozz, desrosj.
See #48110.
No action taken yet
git: f95a75b
svn: r46445
311 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-08 19:05:53 +0000
Bundled Themes: Update Twenty Twenty.
This brings `trunk`'s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46357], see https://github.com/WordPress/twentytwenty/compare/7157870...7246fd6.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyusly, luminuu, itowhid06, cbravobernal, intimez, glauberglauber, ocean90, amolv, briceduclos, aristath, mukesh27, garrett-eclipse, audrasjb, afercia, dianeco, utsav72640, mahesh901122, tobifjellner.
See #48110.
No action taken yet
git: af634cc
svn: r46444
312 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 19:05:13 +0000
Themes: Properly align Close/Previous/Next icons in theme preview overlay.
Props chetan200891.
Fixes #48248.
No action taken yet
git: a15cc93
svn: r46443
313 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 18:47:18 +0000
Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
Props chetan200891.
Fixes #48250.
No action taken yet
git: 5f23525
svn: r46442
314 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 17:54:45 +0000
Code Modernisation: Introduce the spread operator in `Walker::walk()` and `::paged_walk()`.
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This re-applies [45624] and reverts [45640], with a dev note upcoming for plugin authors to maintain backward compatibility with old versions of WordPress.

Props jrf.
See #47678.
No action taken yet
git: 0a818ec
svn: r46441
315 of 3124
Author
John James Jacoby <[email protected]> 2019-10-08 17:44:42 +0000
Network Admin: Improve Site States in List Table rows.
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.
No action taken yet
git: 3207d9a
svn: r46440
316 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-08 17:18:07 +0000
Accessibility: Script Loader: Add jQuery as dependency of `admin-bar`.
On the front end, themes that don't use jQuery make the admin bar fallback to the non-jQuery implementation. Some important features miss from the non-jQuery `admin-bar.js` part, for example `hoverintent` and, most importantly, the touch events for the mobile menu don't work at all.

Enqueueing jQuery is the simplest option for now. For the future, a complete rewriting of `admin-bar.js` in plain JavaScript is highly recommended.

See #47069.
No action taken yet
git: 357a18d
svn: r46439
317 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 17:17:07 +0000
Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files.
Props jrf.
Fixes #48254.
No action taken yet
git: fb0d0e2
svn: r46438
318 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-08 17:05:53 +0000
Accessibility: Media: Improve the logic to render the ARIA tabs markup after [46363].
Additionally checks for the "menu" and "router" state attributes to better determine when the ARIA tabs pattern markup is appropriate.

See #47149.
No action taken yet
git: 1f6dbef
svn: r46437
319 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 17:02:23 +0000
I18N: Add context for the `Archives` string introduced in [45651] as a file type heading, to disambiguate from other types of archives.
Props alexclassroom.
Fixes #48259.
No action taken yet
git: 4d44978
svn: r46436
320 of 3124
Author
Adam Silverstein <[email protected]> 2019-10-08 16:04:32 +0000
External Libraries: upgrade `mediaelement` to version 4.2.13.
Upgrade `mediaelement` to the latest version. Includes a variety of bug fixes made since the 4.2.6 release; see https://github.com/mediaelement/mediaelement/releases.

Props danieliser, Hareesh Pillai.
Fixes #46681.
No action taken yet
git: e2cf94f
svn: r46435
321 of 3124
Author
K. Adam White <[email protected]> 2019-10-08 13:41:29 +0000
REST API: Ensure rest_controller instantiates the post type's declared REST controller class.
Ensures that the ::get_rest_controller() method will always return an instanceof the expected controller class, or null.
Removes unused private static property $post_type_controllers.

Props dlh, TimothyBlynJacobs.
Fixes #45677.
No action taken yet
git: 040304d
svn: r46434
322 of 3124
Author
K. Adam White <[email protected]> 2019-10-08 04:43:10 +0000
REST API: Permit embedding of the 'self' link relation in the /search endpoint.
Removes a special-case prohibition against embedding 'self' which prevented ?_embed from being used with the /wp/v2/search endpoint.

Props TimothyBlynJacobs, chrisvanpatten, kadamwhite.
Fixes #47684.
No action taken yet
git: e17e5aa
svn: r46433
323 of 3124
Author
K. Adam White <[email protected]> 2019-10-08 04:00:25 +0000
REST API: Ensure users with "moderate_comments" capability may edit comments.
Props meloniq.
Fixes #47024.
No action taken yet
git: 4e716db
svn: r46432
324 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 03:18:02 +0000
Coding Standards: Correct the number of accepted arguments in `add_action()` calls in `wp-includes/default-filters.php` for functions that don't accept any arguments.
Props itowhid06, johnbillion, jrf.
Fixes #48123.
No action taken yet
git: 392cf3e
svn: r46431
325 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 02:55:20 +0000
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/media-views.css`.
Follow-up to [45478].

Props ianbelanger, afercia.
Fixes #46529. See #44643.
No action taken yet
git: 9ec0161
svn: r46430
326 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 02:00:24 +0000
Twenty Fourteen: Replace overly broad float-clearing selectors with more specific ones, to avoid unintentionally targeting elements generated by plugins.
Props ianbelanger, iandunn, karmatosed.
Fixes #35779.
No action taken yet
git: 683309f
svn: r46429
327 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-08 01:52:26 +0000
Twenty Fourteen: Ensure the content after the Read More tag is visible and has the appropriate padding.
Props ianbelanger, sabernhardt, slobodanmanic, Quantumstate, Gwendydd, andraganescu, francina.
Fixes #28967.
No action taken yet
git: f257bdf
svn: r46428
328 of 3124
Author
John Blackbourn <[email protected]> 2019-10-07 22:17:22 +0000
Pings/Trackbacks: Remove a failing test that won't pass as long as `WP_IMPORTING` gets set during tests.
The `_publish_post_hook()` function checks for `WP_IMPORTING` before setting meta fields fir enclosures and pings, which means this test is doomed to fail.

The test can be re-implemented if the `WP_IMPORTING` constant gets moved to a function similar to how `wp_installing()` works for the `WP_INSTALLING` constant.

See #48014
No action taken yet
git: 385983f
svn: r46427
329 of 3124
Author
John Blackbourn <[email protected]> 2019-10-07 21:35:54 +0000
Pings/Trackbacks: Fix processing of posts with pending enclosures.
Introduced in [46175].

Fixes #36824
No action taken yet
git: 16b45f0
svn: r46426
330 of 3124
Author
John Blackbourn <[email protected]> 2019-10-07 20:27:20 +0000
Pings/Trackbacks: Avoid adding multiple `_pingme` and `_encloseme` meta entries to a post when it gets updated prior to pings being done.
Props rebasaurus, whyisjake

Fixes #48014
No action taken yet
git: 5e943fa
svn: r46425
331 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-07 19:55:58 +0000
Accessibility: Improve and modernize user interface controls: Revert the new links focus style.
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].

See #34904, #47153.
No action taken yet
git: 86b0faf
svn: r46424
332 of 3124
Author
John Blackbourn <[email protected]> 2019-10-07 19:06:41 +0000
Docs: Miscellaneous inline docs corrections and improvements.
See #47110
No action taken yet
git: ae8bef6
svn: r46423
333 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-07 18:45:45 +0000
Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class.
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes

See #34904.
No action taken yet
git: 4848b1e
svn: r46422
334 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-07 17:04:49 +0000
REST API: Add support for continuing the post-processing of images after upload. Flow:
1. `POST /wp/v2/media`.
2. If the upload failed (HTTP 500 error), look for a response header with `X-WP-Upload-Attachment-ID` header that contains the newly created attachment ID.
3. `POST /wp/v2/media/{id}/post-process` with `{ "action": "create-image-subsizes" }`. This request may still fail, but it will save its progress.
4. On continued failure, `DELETE /wp/v2/media/{id}` to give up on the upload and instruct the user to resize their image before uploading.

Props TimothyBlynJacobs.
Fixes #47987.
No action taken yet
git: 022119d
svn: r46421
335 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-07 15:28:29 +0000
Upload: Set custom header with the attachment ID for all uploads from `media_handle_upload()`. Let the REST API endpoint set it separately.
Props timothyblynjacobs.
Fixes #48200.
No action taken yet
git: fd7240c
svn: r46420
336 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-07 15:16:44 +0000
Coding Standards: Fix WPCS issues in `wp-includes/ms-deprecated.php`.
Props itowhid06.
Fixes #48237.
No action taken yet
git: c2ffe16
svn: r46419
337 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-07 13:18:19 +0000
Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments.
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent

Props garrett-eclipse, afercia.
See #47477.
No action taken yet
git: 42ef147
svn: r46418
338 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-07 12:41:50 +0000
Accessibility: Media: Improve the search media field labelling.
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.
No action taken yet
git: 5c91f0d
svn: r46417
339 of 3124
Author
Andrea Fercia <[email protected]> 2019-10-07 11:52:32 +0000
Accessibility: Login and Registration: Improve the invalid username and invalid email messages.
- explicitly informs users they can use their email to log in as an alternative to their username and vice-versa
- shows the `Lost your password?` link only when an wrong password has been entered
- uses a more appropriate copy by changing "invalid" to "unknown"
- removes the all caps `ERROR`

Props subrataemfluence, zalak151291, ryokuhi, SergeyBiryukov, audrasjb, joedolson, marybaum, ramiy, markjaquith, chanthaboune, afercia.
Fixes #43037.
No action taken yet
git: 2215a9b
svn: r46416
340 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-06 17:12:23 +0000
External Libraries: Fix PHP 7.4 compatibility issue in the Requests library.
Moves https://github.com/rmccue/Requests/pull/370 into WordPress.

Previous [46258].

See #47746.
No action taken yet
git: a59b9dd
svn: r46415
341 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-06 15:26:42 +0000
Coding Standards: Fix WPCS issues in `WP_Widget_Links` and `WP_Widget_Pages`.
Props itowhid06.
Fixes #48228.
No action taken yet
git: 3a06234
svn: r46414
342 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-06 15:12:42 +0000
Tests: Use a consistent group for nav menu tests.
Fixes #48230.
No action taken yet
git: f6267a0
svn: r46413
343 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-06 15:04:18 +0000
Menus: In `Walker_Nav_Menu`, `Walker_Category`, and `Walker_Page`, properly output link attributes having a legitimate "empty" value, for example an HTML data attribute with a value of zero (0).
Props nevma, AkSDvP, greenshady, SergeyBiryukov.
Fixes #47720.
No action taken yet
git: ed1a535
svn: r46412
344 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-06 06:54:13 +0000
Privacy: Ensure that sending email, and remove data follow the same user experience.
Both personal data request processes should follow the same convention.

Fixes: #43974.
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.
No action taken yet
git: de0efbb
svn: r46411
345 of 3124
Author
Jake Spurlock <[email protected]> 2019-10-06 06:40:36 +0000
Administration: Add a max-width to the Privacy Policy Page dropdown.
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.
No action taken yet
git: e2b7892
svn: r46410
346 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-06 02:21:42 +0000
Docs: Format comments in `wp-admin/includes/plugin.php` as per the documentation standards.
Props dkarfa.
Fixes #48191.
No action taken yet
git: 2c5032e
svn: r46409
347 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-05 21:59:32 +0000
Build/Test: Update Grunt Uglify options
Follow up to [46408]

Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.

See #48203.
No action taken yet
git: 3f9927d
svn: r46408
348 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-05 19:47:04 +0000
Build/Test: Bump devDependencies for WordPress 5.3
This upgrades a number of devDependencies.  Some of these include changes to how the tasks are configured.

Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options

Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json

As with most changes to uglify, this changes every minified JS file.

Fixes #48203.
No action taken yet
git: f635745
svn: r46405
349 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 15:40:31 +0000
Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
Props garrett-eclipse, dkarfa.
Fixes #48188.
No action taken yet
git: e963c18
svn: r46404
350 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-05 14:19:20 +0000
Build/Test tools: Update grunt-contrib-imagemin and run it
Smaller images are good, so is not having npm vulnerabilities.

See #48203.
Fixes #48206.
Props whyisjake, netweb.
No action taken yet
git: 269c8ba
svn: r46403
351 of 3124
Author
Aaron Jorbin <[email protected]> 2019-10-05 13:47:52 +0000
Build/Test Tools: Fork and Update `grunt-replace`
The version of grunt replace that is bundled in core is using an outdated version of lodash that is bringing 2 low, 3 high, and 1 critical issue. This package is currently abandoned. There is a community forked version, but that is also harboring some similar security issues.

This switches to a fork by @whyisjake and causes no change to the build.

See #48203.
Fixes #48217.
Props whyisjake, netweb for testing.
No action taken yet
git: 04293be
svn: r46402
352 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 02:38:14 +0000
Site Health: Improve the wording for `UTF8MB4` test description.
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044.
No action taken yet
git: 21de64f
svn: r46401
353 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 02:31:14 +0000
Customize: Remove duplicate `attr_title` assignment in `api.Menus.MenuItemControl.renderContent()`.
See #47838.
No action taken yet
git: e99e145
svn: r46400
354 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 02:15:13 +0000
Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`.
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.

Props codex-m.
Fixes #46581.
No action taken yet
git: ef942c6
svn: r46399
355 of 3124
Author
SergeyBiryukov <[email protected]> 2019-10-05 02:08:01 +0000
Docs: Correct formatting of the `@return` value description in `_wp_handle_upload()`.
See #47110.
No action taken yet
git: 840a033
svn: r46398
356 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 01:30:00 +0000
Docs: Add missing documentation for the first parameter of the `big_image_size_threshold` filter.
Props dkarfa, desrosj, earnjam.
Fixes #48214.
No action taken yet
git: c3c0007
svn: r46397
357 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:59:50 +0000
Emoji: Revert [46393] pending test failure investigation.
See #46537.
No action taken yet
git: 0200a42
svn: r46396
358 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:55:48 +0000
Comments: Remove a one-time variable in `wp_rel_nofollow()` and `wp_rel_ugc()`.
See #48022.
No action taken yet
git: 56b6b1e
svn: r46395
359 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:53:39 +0000
Themes: In `get_theme_mod()`, only run the `sprintf()` replacement on the default value if there's a string format pattern found in the value.
This prevents standalone percent symbols from being stripped out, e.g. in a default value like `100%`.

Props aristath, kuus, moonomo, westonruter, davetgreen, daviedR, katielgc, noisysocks, SergeyBiryukov.
Fixes #34290.
No action taken yet
git: 1be6c41
svn: r46394
360 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:39:04 +0000
Docs: Improve documentation for `get_theme_mod()` and `set_theme_mod()`.
See #47110.
No action taken yet
git: c411aad
svn: r46393
361 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-04 23:28:22 +0000
Emoji: Stop emoji replacement from happening inside CodeMirror instances, and clean up some logic in the `MutationObserver`.
Props pento, hirofumi2012, davidbaumwald.
Fixes #46537.
No action taken yet
git: 0e2b212
svn: r46392
362 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-04 23:20:01 +0000
Themes: Bring default values for `get_theme_root()`, `get_theme_root_uri()`, `wp_get_theme()`, and `wp_customize_url()` in line with the documentation.
Reverts [46327].

Fixes #44397.
No action taken yet
git: c2bcdea
svn: r46391
363 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-04 22:18:11 +0000
Docs: Add missing description for `$comment` global.
Props immeet94, mukesh27.
Fixes #46928. See #47110.
No action taken yet
git: 08ff597
svn: r46390
364 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-04 22:08:34 +0000
I18N: Add missing comma in a translator comment.
See #47515.
No action taken yet
git: 84dc68a
svn: r46389
365 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-04 21:58:48 +0000
Customize: Prevent breaking the customizer when site title contains templating syntax.
When the site title is inside an underscore template, syntax defined in `wp.template` like `{{ }}` is treated as special characters and will make Underscore treat it as data to be compiled/rendered.

Props pierlo, donmhico.
Fixes #46863.
No action taken yet
git: 25ba907
svn: r46388
366 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-04 21:19:17 +0000
QUnit: Include script dependencies for wp-a11y script to fix a TypeError.
Also, add missing message argument to Customizer notifications to ensure tests are passing.

Fixes #45066.
No action taken yet
git: a468719
svn: r46387
367 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-04 20:19:11 +0000
I18N: Fix translator comment for a themes list table string with numbered placeholders.
Props garrett-eclipse.
Fixes #47515.
No action taken yet
git: 0b3bc89
svn: r46386
368 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-04 20:11:20 +0000
Docs: Convert 'Block Editor' to lowercase.
Props garrett-eclipse.
Fixes #45634.
No action taken yet
git: c7bd227
svn: r46385
369 of 3124
Author
Dominik Schilling <[email protected]> 2019-10-04 19:57:08 +0000
Networks and Sites: Improve newly added strings for i18n.
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.

Props pedromendonca.
Fixes #48210.
No action taken yet
git: f183dd8
svn: r46384
370 of 3124
Author
Jonathan Desrosiers <[email protected]> 2019-10-04 14:31:05 +0000
Networks and Sites: Fix issues processing additional fields displayed for the Sites list table.
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.

Props pbiron.
Fixes #45954.
No action taken yet
git: 17765e9
svn: r46383
371 of 3124
Author
Sergey Biryukov <[email protected]> 2019-10-03 23:11:20 +0000
Docs: Clarify default value for the `$link` parameter in `edit_tag_link()`, `edit_term_link()`, and `edit_bookmark_link()`.
Props atachibana.
Fixes #48109.
No action taken yet
git: 5e0904c
svn: r46382
372 of 3124
Author
Andrew Ozz <[email protected]> 2019-10-03 21:00:10 +0000
Upload: Fix the method used to create image sub-sizes when uploading fai