WordPress commits: wp-trunk branch

git: 23b6ca3
svn: r46085
1 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-09 00:06:29 +0000
Accessibility: Media: Replace `@` with `at` in the displayed date format.
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props audrasjb, afercia.
Fixes #47893.
No action taken yet
git: 8aa380c
svn: r46084
2 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-08 23:52:43 +0000
Accessibility: Comments: Replace `@` with `at` in the displayed date format.
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47893.
No action taken yet
git: acadc5c
svn: r46083
3 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-08 23:23:26 +0000
Accessibility: Posts, Post Types: Replace `@` with `at` in the displayed date format.
The `@` symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47832.
No action taken yet
git: 4bd76c1
svn: r46082
4 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-08 13:15:19 +0000
Docs: Fix typo in `WP_Hook::resort_active_iterations()` description.
Props itowhid06.
Fixes #47999.
No action taken yet
git: 275f9ba
svn: r46081
5 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-08 02:27:51 +0000
Upload: Reset the temp upload reference in Plupload when the file is not an image.
See #47872.
No action taken yet
git: d48d56e
svn: r46080
6 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-07 19:32:42 +0000
Posts, Post Types: Revert [46079] pending test failure investigation.
See #47824.
No action taken yet
git: 6905468
svn: r46079
7 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-07 14:32:23 +0000
Posts, Post Types: Avoid a PHP warning when `the_content()` is called outside of the loop.
Fixes #47824.
No action taken yet
git: b545a56
svn: r46078
8 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-07 02:11:50 +0000
Fix "white spaces at end of line" in docblock (IDE) woes after [46077].
See #32437.
No action taken yet
git: ba033e4
svn: r46077
9 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-07 01:33:16 +0000
Media: Improve handling of cases where an uploaded image matches exactly a defined intermediate size. In most of these cases the original image has been edited by the user and is "web ready", there is no need for an identical intermediate image.
Introduces the `wp_image_resize_identical_dimensions` filter so plugins and themes can determine whether a new image with identical dimensions should be created, defaults to false.

Props wpdennis, HKandulla, galbaras, azaozz.
See #32437.
No action taken yet
git: f6a8912
svn: r46076
10 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-07 01:06:49 +0000
Media: Add handling for "BIG" images. When the users upload a big image, typically a photo, scale it down to make it suitable for web use. Then use the scaled image as the "full" size, and keep the originally uploaded image for creating high quality sub-sizes in the future and in case the users want to download it later.
Introduces `wp_get_original_image_path()` that retrieves the path to the originally uploaded image in all cases, and `big_image_size_threshold` filter to set the pixel value above which images will be scaled. The same value is used as max-width and max-height when scaling.

See #47873.
No action taken yet
git: 4686297
svn: r46075
11 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-06 23:47:05 +0000
Uploads: Improve the error message shown when all attempts to create image sub-sizes fail.
Props afercia.
See #47872.
No action taken yet
git: e1665da
svn: r46073
12 of 2469
Author
Jake Spurlock <[email protected]> 2019-09-06 21:48:22 +0000
Remove the extra call for wp-sanitize from the script loader.
Fixes #47986
No action taken yet
git: c95616c
svn: r46072
13 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-06 06:25:19 +0000
Upgrade/Install: Escape the `%` in `width="100%"` in a `printf()` call in `Plugin_Upgrader_Skin::after()`.
Props afragen.
Fixes #47989.
No action taken yet
git: 8b17f6c
svn: r46071
14 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-06 00:05:10 +0000
Docs: Improve documentation for `do_meta_boxes` action.
Props felipeelia, killua99, SergeyBiryukov.
Fixes #46542.
No action taken yet
git: 419bb36
svn: r46070
15 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-05 23:17:19 +0000
REST API: Mark `WP_REST_Users_Controller::update_current_item()` and `::delete_current_item()` as public.
Props dkarfa.
Fixes #47967.
No action taken yet
git: 800b8cf
svn: r46069
16 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-05 23:04:05 +0000
Docs: Remove extra spaces in various REST API DocBlocks.
See #47110.
No action taken yet
git: 32086d7
svn: r46068
17 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-05 22:58:50 +0000
Docs: Correct DocBlocks for `WP_REST_Posts_Controller::get_available_actions()` and `WP_REST_Revisions_Controller::get_parent()`.
Props dkarfa.
Fixes #47966.
No action taken yet
git: 58dd5e7
svn: r46067
18 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-05 22:52:29 +0000
Fix (unrelated) test after [46066].
See #43524.
No action taken yet
git: a38ecee
svn: r46066
19 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-05 22:26:50 +0000
Media: Add two new intermediate image sizes, 1536px and 2048px. They are meant to enhance the way WordPress displays images on the front-end on larger, high-density devices. They make it possible to generate more suitable `srcset` and `sizes` attributes, and not use the original, often non-optimized image.
Also change the default `max_srcset_image_width` value to match the new max size.

Props pierlo, azaozz.
See #43524.
No action taken yet
git: a211ce8
svn: r46028
20 of 2469
Author
Andrea Fercia <[email protected]> 2019-09-04 19:32:07 +0000
Widgets: Fix "jumpiness" when reordering widgets by dragging them.
Props ketanumretiya030, mukesh27, andraganescu, audrasjb.
Fixes #46941.
No action taken yet
git: bd29959
svn: r46019
21 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-04 18:40:13 +0000
Coding Standards: Fix WPCS issue in [45990].
No action taken yet
git: cda102f
svn: r45997
22 of 2469
Author
Jonathan Desrosiers <[email protected]> 2019-09-04 17:51:33 +0000
Fix for URL sanitization that can lead to cross-site scripting (XSS) attacks.
Props irsdl, sstoqnov, whyisjake.
Backported in 489488a
git: b91c405
svn: r45990
23 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-04 17:36:46 +0000
Improve handling the existing `rel` attribute in `wp_rel_nofollow_callback()`.
Props xknown, sstoqnov.
Backported in 7b5700b
git: c957e25
svn: r45979
24 of 2469
Author
Jake Spurlock <[email protected]> 2019-09-04 17:11:22 +0000
Update wp.a11y.speak() to sanitize HTML before display.
Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc
No action taken yet
git: 8552a9a
svn: r45971
25 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-04 16:56:33 +0000
Improve URL validation in `wp_validate_redirect()`.
Props vortfu, whyisjake, peterwilsoncc.
Backported in 8382dd5
git: a1fd37e
svn: r45964
26 of 2469
Author
Andrea Fercia <[email protected]> 2019-09-04 16:45:58 +0000
Bundled Theme: Twenty Nineteen: Use human-friendly color names.
For better accessibility, the Primary and Secondary theme colors have now more understandable names.
Changes the names "Primary" and "Secondary" to "Blue" and "Dark Blue". Fallbacks to the `hex` color codes when the theme is set to use a custom Primary color.

Props kjellr, aduth, audrasjb.
Fixes #46698.
No action taken yet
git: 8aab635
svn: r45942
27 of 2469
Author
Andrea Fercia <[email protected]> 2019-09-04 16:26:50 +0000
Bundled Theme: Twenty Nineteen: Fix the nesting of the `main` element.
The `main` element must not appear as a descendant of the `section` element. Correct markup is the first requirement to make user agents and assistive technologies work properly.

Changes the `<section>` element that was wrapping the `<main>` element to a `<div>`.

Props albertomake, ryelle, desrosj, ianbelanger, audrasjb.
Fixes #47066.
No action taken yet
git: a04e391
svn: r45936
28 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-04 16:08:03 +0000
Escape the output in `wp_ajax_upload_attachment()`.
Props whyisjake, sstoqnov.
Backported in 1c174bc
git: 7f033de
svn: r45935
29 of 2469
Author
Jake Spurlock <[email protected]> 2019-09-04 16:03:56 +0000
Remove _convert_urlencoded_to_entities() from the get_the_content() callback.
Props vortfu, whyisjake, peterwilsoncc
No action taken yet
git: 759ee94
svn: r45934
30 of 2469
Author
Andrew Ozz <[email protected]> 2019-09-04 01:10:57 +0000
Uploads: After an image is uploaded and PHP times out or runs out of memory during post-processing (the server response is HTTP 500 error), try to resize it three more times. Then, if all attempts fail, do a cleanup of any sub-sizes that may have been created and show an error message asking the user to scale the image and upload it again.
See #47872.
No action taken yet
git: 29ad307
svn: r45933
31 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-03 00:56:42 +0000
I18N: Fix typo in a function name in [45932].
See #44360.
No action taken yet
git: 00b03f2
svn: r45932
32 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-03 00:39:13 +0000
I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
No action taken yet
git: aed8c49
svn: r45931
33 of 2469
Author
Andrea Fercia <[email protected]> 2019-09-02 21:48:29 +0000
Accessibility: Improve focus styles for legacy modal dialogs powered by jQuery UI.
Fixes #47944.
No action taken yet
git: e12f379
svn: r45930
34 of 2469
Author
Andrea Fercia <[email protected]> 2019-09-02 21:43:39 +0000
Accessibility: Audit usage of abbreviations.
Title attributes on abbreviations are only available to a minority of users. The
best option is to avoid unnecessary abbreviations when possible. In the other cases,
use an `<abbr>` element (which provides a hint to user agents on how to announce
and display the abbreviation) and provide an expansion in plain text on first use.

- `readme.html`: improves abbreviations and removes unnecessary `title` attributes
- options-general: removes unnecessary abbreviations and improves the remaining ones
- customizer schedule changeset date: removes unnecessary abbreviations and improves the remaining ones
- posts table date: uses a `span` element instead of an `abbr` element because this is not an abbreviation

Fixes #46980.
No action taken yet
git: ac2df4e
svn: r45929
35 of 2469
Author
Felix Arntz <[email protected]> 2019-09-02 10:24:18 +0000
Formatting: Improve accuracy of `force_balance_tags()` and add support for custom element tags.
This changeset includes a major iteration on the regular expression used to balance tags, with comprehensive test coverage to ensure that all scenarios are supported or unsupported as expected.

Props dmsnell, westonruter, birgire.
Fixes #47014.
No action taken yet
git: 122cb28
svn: r45928
36 of 2469
Author
Peter Wilson <[email protected]> 2019-09-02 02:26:55 +0000
#43590: Use robots meta tag to better discourage search engines.
This changes the "discourage search engines" option to output a `noindex, nofollow` robots meta tag. `Disallow: /` is removed from the `robots.txt` to allow search engines to discover they are requested not to index the site.

Disallowing search engines from accessing a site in the `robots.txt` file can result in search engines listing a site with a fragment (a listing without content).

Props donmhico, jonoaldersonwp.
Fixes #43590.
No action taken yet
git: d0db5be
svn: r45927
37 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-02 00:42:01 +0000
I18N: Split translatable strings located on the same line preceded with a translator comment, where the first string needs that comment, but the second does not.
Props johnbillion.
See #44360.
No action taken yet
git: a7513ac
svn: r45926
38 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-01 17:12:43 +0000
I18N: Improve translator comments.
* Add missing translator comments.
* Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various `.pot` file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.
No action taken yet
git: 425d6fd
svn: r45925
39 of 2469
Author
Andrea Fercia <[email protected]> 2019-09-01 15:17:37 +0000
Accessibility: Add a default title for the media modal dialog.
Makes sure the media modal dialog `h1` heading isn't empty when custom media frames don't set a title. This is particularly important now that the media modal is an ARIA dialog, as the title is referenced by an `aria-labelledby` attribute to properly label the dialog.

Props donmhico, audrasjb.
Fixes #47612.
No action taken yet
git: e2b68a4
svn: r45924
40 of 2469
Author
Sergey Biryukov <[email protected]> 2019-09-01 13:02:29 +0000
Docs: Improve documentation for `auth_redirect()`.
Props atachibana.
Fixes #47956.
No action taken yet
git: 27c877e
svn: r45923
41 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-31 20:52:07 +0000
Twenty Nineteen: Remove unused jQuery argument passed to an IIFE that accepts no arguments.
Props Christian1012, hareesh-pillai.
Fixes #40333.
No action taken yet
git: 08a9185
svn: r45922
42 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-31 20:51:45 +0000
Twenty Seventeen: Remove unused jQuery argument passed to an IIFE that accepts no arguments.
Props Christian1012, hareesh-pillai.
See #40333.
No action taken yet
git: 9abbd90
svn: r45921
43 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-31 20:42:27 +0000
Twenty Nineteen: Correct file name in JS DocBlocks.
See #47110.
No action taken yet
git: 9445634
svn: r45920
44 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-30 19:14:23 +0000
Twenty Nineteen: Improve compatibility with custom colors in the separator block.
Props kjellr.
Fixes #47811.
No action taken yet
git: 6f22a93
svn: r45919
45 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-30 18:57:51 +0000
Twenty Nineteen: Remove Baskerville Old Face from the font stack due to several shortcomings:
* Being difficult to read due to its mix of thin and thick strokes.
* Having poor language/extended character support.
* Not having other weights/styles (bold, italic, etc) and relying on browser approximations of those variants.

The next fonts down the stack (Garamond and Times) are more properly aligned to the appearance of the top-level serif font in the stack (Hoefler Text), and work better in its place.

Props kjellr, Rarst, justintadlock.
Fixes #45881.
No action taken yet
git: 5377bc4
svn: r45918
46 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-30 18:32:14 +0000
Comments: In AJAX response when deleting a comment, account for `&nbsp;` as a thousands separator in `total_items_i18n` and `total_pages_i18n` numbers.
Props denisco, SergeyBiryukov.
Fixes #47953.
No action taken yet
git: 3a0faad
svn: r45917
47 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-30 16:56:39 +0000
Docs: Simplify `get_plugin_data()` and `get_file_data()` description.
See #47110.
No action taken yet
git: b36feb1
svn: r45916
48 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-30 16:15:32 +0000
Docs: Update plugin headers example in `get_plugin_data()` to clarify that `Version` is not a required field.
Props casiepa.
See #47110, #meta4707.
No action taken yet
git: ab7c365
svn: r45915
49 of 2469
Author
John Blackbourn <[email protected]> 2019-08-30 11:34:11 +0000
Docs: Correct and improve inline docs relating to caching, terms, meta, and some misc tweaks.
See #47110
No action taken yet
git: 56d4e7f
svn: r45914
50 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 23:17:30 +0000
Date/Time: Restore the previous behavior of `date_i18n()` where invalid input would result in current time.
Make `wp_date()` return `false` on invalid timestamp input, for consistency with upstream PHP `date()` function.

Props Rarst.
Fixes #28636.
No action taken yet
git: 07ec966
svn: r45913
51 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 21:36:00 +0000
I18N: Add missing translator comment in help text on Reading Settings screen.
Props garrett-eclipse.
See #46708.
No action taken yet
git: e9d1a9a
svn: r45912
52 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 21:24:46 +0000
Administration: Add a note to "For each post in a feed, include [Full text / Summary]" option that how content is displayed in browsers depends on the theme.
Add a documentation link to learn more about feeds.

Props JarretC, SergeyBiryukov, pento, talldanwp, dinhtungdu, noisysocks, tobifjellner.
Fixes #46708.
No action taken yet
git: 355d93d
svn: r45911
53 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 16:43:28 +0000
Date/Time: Update XML-RPC tests for invalid date input to account for a more consistent `mysql2date()` error handling in [45908].
The tests were meant to check for the lack of a fatal error in case of invalid date input, not specifically mark a particular outcome as the correct one.

Props Rarst.
Fixes #28992.
No action taken yet
git: 4572bb0
svn: r45910
54 of 2469
Author
Felix Arntz <[email protected]> 2019-08-29 12:41:45 +0000
Multisite: Improve performance by caching not found lookups for sites and networks.
With this change, the result of a site or network lookup by ID will be cached even if the ID does not exist. When a new site or network is created, the cache for the respective new ID is cleared.

Props mnelson4, nielsdeblaauw.
Fixes #42251.
No action taken yet
git: 65f3124
svn: r45909
55 of 2469
Author
Mike Schroder <[email protected]> 2019-08-29 07:52:43 +0000
Administration: Output valid HTML when `wp_die()` is called.
To better support HTML and string calls to `wp_die()` without
outputting invalid HTML, wraps error messages in `<div>` rather than `<p>`.

Adds `.wp-die-message` CSS class for styling.

Props dinhtungdu, jeremyfelt, audrasjb, SergeyBiryukov, afercia, audrasjb, noisysocks.
Fixes #47580.
No action taken yet
git: 71697ae
svn: r45908
56 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 05:06:15 +0000
Date/Time: Revamp `mysql2date()` to use `wp_date()` and handle invalid input in a consistent manner.
Add unit tests, improve documentation.

Props Rarst, pbearne.
Fixes #28992.
No action taken yet
git: f490fb9
svn: r45907
57 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 02:39:21 +0000
Coding Standards: Fix WPCS issue in [45906].
See #45322.
No action taken yet
git: c3e89c2
svn: r45906
58 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-29 02:09:42 +0000
XML-RPC: Make sure editing a draft post with `wp.editPost` does not unintentionally cause its published date to be set.
Props redsweater.
Fixes #45322.
No action taken yet
git: 5a1e364
svn: r45905
59 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-28 03:12:09 +0000
Site Health: Merge two similar strings explaining what drop-in plugins are.
Props garrett-eclipse, ramiy, Clorith.
Fixes #47247.
No action taken yet
git: 83efbc6
svn: r45904
60 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-28 03:07:59 +0000
Site Health: Standardize on `SELECT VERSION()` query for checking the database server version, due to the MariaDB version declaration potentially causing issues in production environments.
Partially reverts [45691].

Props Clorith.
Fixes #47738.
No action taken yet
git: 2d0cb48
svn: r45903
61 of 2469
Author
K. Adam White <[email protected]> 2019-08-28 03:07:03 +0000
REST API: Only cast scalar types to string when comparing new & old meta values.
Newly-supported array and object meta types should not be cast to strings.

Props TimothyBlynJacobs, caercam.
Fixes #47928.
No action taken yet
git: dfe51f6
svn: r45902
62 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-28 02:19:46 +0000
Date/Time: Correct delta comparison in `test_should_return_wp_timestamp()`.
See #25768.
No action taken yet
git: a4723ed
svn: r45901
63 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-28 00:51:16 +0000
Date/Time: Introduce `wp_date()` to retrieve the date in localized format.
Convert `date_i18n()` into a wrapper for `wp_date()`.

`wp_date()` is intended as a replacement for `date_i18n()` without legacy quirks in it. It accepts a true Unix timestamp (not summed with timezone offset) and an arbitrary timezone.

Props Rarst, mboynes, MikeHansenMe, rmccue, nacin.
Fixes #28636.
No action taken yet
git: 6c8b425
svn: r45900
64 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-27 21:54:58 +0000
Date/Time: Remove the last remaining `current_time( 'timestamp' )` instance in `wp_post_revision_title_expanded()`.
Timestamps don't carry any timezone information, using `$revision->post_modified_gmt` simplifies the logic.

Props Rarst.
See #40657.
No action taken yet
git: dea752a
svn: r45899
65 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-27 01:16:20 +0000
Docs: Clarify that `$name` and `$value` parameters of `set_user_setting()` can contain hyphens.
Props tmatsuur.
Fixes #47938.
No action taken yet
git: 62a8756
svn: r45898
66 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-27 00:16:06 +0000
Docs: Remove a clarification from `do_robots()` description that doesn't really clarify anything.
See #47110.
No action taken yet
git: ef69d4b
svn: r45897
67 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-26 19:00:46 +0000
Twenty Nineteen: Make sure center-aligned images in columns do not break beyond the column boundaries.
Props kjellr.
Fixes #47937.
No action taken yet
git: c8bd4cb
svn: r45896
68 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-26 18:59:39 +0000
Twenty Nineteen: Update `style-rtl.css` after [45773].
See #47850.
No action taken yet
git: 144cb53
svn: r45895
69 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-26 16:59:53 +0000
Docs: Reference `WP_Term_Query::__construct()` in `wp_list_categories()` DocBlock for additional accepted arguments.
Clarify that `wp_dropdown_categories()` always returns a string, regardless of the `echo` parameter.

See #47896, #47110.
No action taken yet
git: 7dac24c
svn: r45894
70 of 2469
Author
Boone Gorges <[email protected]> 2019-08-26 15:23:48 +0000
Taxonomy: Standardize docs for `wp_list_categories()`.
Many of the parameters historically documented on this function are merely
passed through to `get_categories()` and its underlying functions. In order to
avoid unnecessary duplication of function arguments, we remove documentation of
these parameters, and replace it with reference to the wrapped functions.

Parameters that receive special treatment or are otherwise changed before
being passed through continue to be documented as part of `wp_list_categories()`.

Props audrasjb, itowhid06, birgire.
Fixes #47896.
No action taken yet
git: c2c8a68
svn: r45893
71 of 2469
Author
Boone Gorges <[email protected]> 2019-08-26 15:18:40 +0000
Taxonomy: Fix unique-slug check for terms with parents.
`wp_unique_term_slug()` appends numeric suffixes when the requested slug is
already in use by a sibling term. Changes introduced in [32837] inadvertently
caused this suffixing to be skipped in cases where the requested slug is
suffixed with the parent slug, so that it became possible to have two terms
`childslug-parentslug` underneath to the same `parentslug`. We fix this
regression by ensuring that the numeric-suffix routine runs in all cases.

Props yashar_hv, saskak, dlh.
Fixes #46431.
No action taken yet
git: 152083b
svn: r45892
72 of 2469
Author
Andrew Ozz <[email protected]> 2019-08-25 22:20:57 +0000
Docs: Improve and update the description of `multi_resize()` to explain changes and expected use.
See #40439.
No action taken yet
git: 252e14a
svn: r45891
73 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-25 21:31:43 +0000
Menus: In `wp_setup_nav_menu_item()` and `Walker_Nav_Menu_Edit::start_el()`, check if the post or term associated with the menu item still exists to avoid a PHP notice.
If the associated post or term no longer exists, mark the menu item as invalid.

Props mehulkaklotar, kamrankhorsandi, cristiano.zanca, SergeyBiryukov.
Fixes #31703.
No action taken yet
git: 7ef2679
svn: r45890
74 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-25 20:02:31 +0000
Users: Adjust [45806] to make sure `$all_userids` is always defined.
Props kbrownkd.
Fixes #47936.
No action taken yet
git: 2e1de73
svn: r45889
75 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-24 19:36:33 +0000
Site Health: Add timezone to Site Health Info page.
Props justinahinon, sharaz, artisticasad, Rarst.
Fixes #47842.
No action taken yet
git: 3e70447
svn: r45888
76 of 2469
Author
Boone Gorges <[email protected]> 2019-08-23 16:04:07 +0000
Taxonomy: Ensure consistency of `hide_empty` in term queries when `taxonomy` is excluded.
When querying for terms in hierarchical categories using `hide_empty=true`,
results have historically included parent terms which are themselves
unattached to any objects (are "empty") but which have non-empty descendent
terms. Because this process involves walking the descendant tree, we avoid it
when we detect that the queried taxonomies are not hierarchical. (This
behavior was introduced in [5525].)

When the `taxonomy` parameter of `get_terms()` was made optional - see #35495,
[36614] - it affected the mechanism for avoiding unneccessary tree walks,
since there may not be any explicitly declared taxonomies to run through
`is_taxonomy_hierarchical()`. As a result, term queries excluding `taxonomy`
did not check descendants, and empty parents with non-empty children were not
included in `hide_empty` results.

We correct the behavior by crawling term descendants when the `taxonomy`
argument is absent, which means that we're querying for terms in all taxonomies.

Props smerriman.
Fixes #37728.
No action taken yet
git: ae2b4f9
svn: r45887
77 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-23 11:02:51 +0000
Date/Time: Rewrite and simplify `get_gmt_from_date()`, `get_date_from_gmt()`, and `iso8601_to_datetime()` using `wp_timezone()`.
Improve unit test coverage.

Props Rarst, goodevilgenius.
Fixes #31809.
No action taken yet
git: b975a25
svn: r45886
78 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-23 02:14:07 +0000
Date/Time: Simplify the date comparing logic in `WP_Community_Events::trim_events()`.
The Events API returns event date without timezone information, so trying to parse it into a timestamp and compare to a WP timestamp is pointless.

Props Rarst.
Fixes #47463.
No action taken yet
git: ece257f
svn: r45885
79 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-23 01:55:28 +0000
Build Tools: Pass the LOCAL_DIR environment variable through to the phpunit Docker container.
This allows code running inside the container to know whether it's supposed to be running in `build` or `src`.

See #47767.
No action taken yet
git: ff36b96
svn: r45884
80 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-23 01:15:16 +0000
Date/Time: Revert unintended changes from [45882].
Props TimothyBlynJacobs.
See #25768.
No action taken yet
git: 1c66cf5
svn: r45883
81 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-23 01:11:22 +0000
Date/Time: Introduce `current_datetime()` for better time operations.
Returning a `DateTimeImmutable` representation of the current moment in time, this allows for a more flexible and reliable use than `current_time()` provides.

Props Rarst.
Fixes #47464.
No action taken yet
git: 67f7d1f
svn: r45882
82 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-23 00:56:21 +0000
Date/Time: Rewrite and simplify `date_i18n()` using `wp_timezone()` to address multiple issues with certain date formats and timezones, while preserving some extra handling for legacy use cases.
Improve unit test coverage.

Props Rarst, remcotolsma, raubvogel.
Fixes #25768.
No action taken yet
git: 0847b67
svn: r45881
83 of 2469
Author
Jonathan Desrosiers <[email protected]> 2019-08-22 19:07:57 +0000
Coding Standards: Dynamic hooks should be named using interpolation not concatenation.
Props arena, desrosj.
Fixes #47052.
No action taken yet
git: 5a47302
svn: r45877
84 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-22 14:49:05 +0000
Coding Standards: Add missing `break` for the default case in `wp_privacy_anonymize_data()`.
Props itowhid06.
Fixes #47921.
No action taken yet
git: 4e129d1
svn: r45876
85 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-22 03:10:05 +0000
Date/Time: Use `wp_timezone()` in `WP_Date_Query::build_mysql_datetime()` to address timezone issues.
Improve unit test coverage.

Props Rarst, Biranit, birgire, jave.web, SergeyBiryukov.
Fixes #41782.
No action taken yet
git: 8d5e4fe
svn: r45875
86 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-22 02:28:50 +0000
Build Tools: Don't use git for package installs.
While NPM supports installing packages from git locations, this requires `git` to be in the path, which won't necessarily be true, particularly on Windows.

We can download the release versions for these packages, instead.

Fixes #47916.
No action taken yet
git: 1ba4455
svn: r45874
87 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-22 01:52:16 +0000
Users: Adjust [45708] to make sure `wp_update_user()` does not issue a `WP_Error` if a single site was previously set up as Multisite and there's still a `spam` field in the user table.
Add a unit test.

Props azaozz, SergeyBiryukov.
Fixes #45747.
No action taken yet
git: 7fbabd5
svn: r45873
88 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-22 00:21:49 +0000
Administration: Adjust [45814] to address a backward compatibility issue for plugins passing multiple CSS classes to `add_settings_error()`.
Only add the `notice-` prefix for `error`, `success`, `warning`, `info` CSS classes, keep other classes as is.

Add unit tests for `settings_errors()`.

Props afercia, SergeyBiryukov.
Fixes #44941.
No action taken yet
git: 6ea6591
svn: r45872
89 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-21 16:26:47 +0000
Docs: Correct type for the `$deprecated` argument of `get_terms()`.
Props itowhid06.
Fixes #47915.
No action taken yet
git: 7b14e0c
svn: r45871
90 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-21 16:22:49 +0000
Docs: Fix typo in `_wp_make_subsizes()` DocBlock.
Props itowhid06.
Fixes #47913. See #40439.
No action taken yet
git: fb189a6
svn: r45869
91 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-21 00:26:45 +0000
Customizer: Trim whitespace from custom link URLs.
This complements a similar fix for the Menus screen in [45655].

Props donmhico, audrasjb.
Fixes #47888. See #47723.
No action taken yet
git: 2fb748b
svn: r45867
92 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 22:53:50 +0000
Docs: Update `@since` tag for new JS functions and variables introduced in [45572].
Props garrett-eclipse.
See #47145.
No action taken yet
git: 23769b6
svn: r45863
93 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 19:10:15 +0000
Twenty Seventeen: Fix tabs vs. spaces in [45764].
See #47414.
No action taken yet
git: 92ba725
svn: r45862
94 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 19:10:12 +0000
Twenty Eleven: Fix tabs vs. spaces in [45763].
See #47414.
No action taken yet
git: c277879
svn: r45861
95 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 19:05:30 +0000
Twenty Seventeen: Adjust [45764] to conform to CSS Coding Standards.
See #47414.
No action taken yet
git: 13f064a
svn: r45860
96 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 19:05:24 +0000
Twenty Eleven: Adjust [45763] to conform to CSS Coding Standards.
See #47414.
No action taken yet
git: d471151
svn: r45859
97 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 17:27:17 +0000
Tests: Remove `$wpdb` global reference from `test_wp_insert_user_with_empty_data()`.
See #47902.
No action taken yet
git: 31a6309
svn: r45858
98 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 17:25:02 +0000
Users: In `wp_insert_user()`, account for the `wp_pre_insert_user_data` filter returning empty data.
Props juliobox, SergeyBiryukov.
Fixes #47902.
No action taken yet
git: 051aa38
svn: r45857
99 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-20 01:34:37 +0000
Date/Time: Fix race conditions in `current_time()` tests.
* Restore default timezone before performing assertions to avoid affecting other tests in case of failure.
* Use delta comparison for timestamps to avoid race conditions.

Props SergeyBiryukov, desrosj.
Fixes #45821.
No action taken yet
git: 91f60af
svn: r45856
100 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 21:05:42 +0000
Date/Time: Use PHP `DateTime` class API in `current_time()`.
Only use the legacy WP timestamp approach (a sum of timestamp and timezone offset) for `timestamp` and `U` formats without the `$gmt` flag.

Otherwise, make sure the function returns correct local time for any format.

Props Rarst, jdgrimes.
Fixes #40653.
No action taken yet
git: f5f2fc3
svn: r45855
101 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 21:05:25 +0000
Coding Standards: Use long array syntax in `Tests_WP_Timezone::timezone_offset_provider()`.
Per https://make.wordpress.org/core/2019/07/12/php-coding-standards-changes/, arrays must be declared using long array syntax for clarity.

See #24730.
No action taken yet
git: c782ad4
svn: r45854
102 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 20:09:11 +0000
Coding Standards: Use `KB_IN_BYTES` in `get_file_data()`.
See #22405, #47632.
No action taken yet
git: 904b41e
svn: r45853
103 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 19:07:03 +0000
Date/Time: Introduce `wp_timezone_string()` and `wp_timezone()` for unified timezone retrieval.
* `wp_timezone_string()` retrieves the timezone from current settings as a string. Uses the `timezone_string` option to get a proper timezone if available, otherwise falls back to an offset.
* `wp_timezone()` retrieves the timezone from current settings as a `DateTimeZone` object. Timezone can be based on a PHP timezone string or a `±HH:MM` offset.

Props Rarst, remcotolsma, johnjamesjacoby, rmccue.
Fixes #24730.
No action taken yet
git: f2b6c12
svn: r45852
104 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 16:34:57 +0000
Coding Standards: Fix WPCS violations in [45851].
See #25347.
No action taken yet
git: 896da17
svn: r45851
105 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 15:49:32 +0000
Date/Time: In `wp_insert_post()`, when checking the post date to set `future` or `publish` status, use string comparison to work around far future dates (year 2038+) on 32-bit systems.
Props Rarst, nofearinc.
Fixes #25347.
No action taken yet
git: 0f8ba2c
svn: r45850
106 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-19 15:16:18 +0000
Date/Time: In `WP_Date_Query::__construct()`, return early if `$date_query` is empty or not an array.
Props vishalkakadiya.
Fixes #47392.
No action taken yet
git: 4e0499e
svn: r45827
107 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-19 02:17:50 +0000
Tests: Add an xdebug group for tests that require xdebug.
These tests are now also run as their own part of the Travis build, to ensure performance of other tests isn't affected by the presence of xdebug.

Fixes #40532.
No action taken yet
git: 9260916
svn: r45826
108 of 2469
Author
Tammie Lister <[email protected]> 2019-08-18 12:29:30 +0000
Multisite: Remove truncation to allow clearers identification of longer site names
Previously the sites were truncated which meant longer names but with ending identifications were unable to be seen as different. This shows the full site name to allow easier understanding.

Props tferry, melinedo, afercia, jeremyfelt
Fixes: 47112
No action taken yet
git: 95c36ce
svn: r45825
109 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-18 02:07:00 +0000
Privacy: Add descriptions for sections in a personal data export file.
Props garrett-eclipse, Venutius, karmatosed.
Fixes #45491.
No action taken yet
git: 6f30523
svn: r45824
110 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-17 14:33:01 +0000
Plugins: Adjust margin for plugin headings on "Add Plugins" screen to avoid overlapping with "Network Activate" button.
Props justinahinon, chetan200891.
Fixes #47600.
No action taken yet
git: e810b32
svn: r45823
111 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-17 13:58:12 +0000
Pings/Trackbacks: In `wp_xmlrpc_server::pingback_ping()`, strip inline JS and CSS while trying to figure out the pingback context.
Props david.binda.
Fixes #47283.
No action taken yet
git: c5438c3
svn: r45822
112 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-17 13:22:26 +0000
Docs: Improve documentation for `wp_set_auth_cookie()` and related functions.
Props arafat, SergeyBiryukov.
Fixes #47886.
No action taken yet
git: b675f56
svn: r45821
113 of 2469
Author
John Blackbourn <[email protected]> 2019-08-16 19:34:31 +0000
Docs: Add a missing return type.
See #47110
No action taken yet
git: 4bb45c6
svn: r45820
114 of 2469
Author
K. Adam White <[email protected]> 2019-08-16 03:32:23 +0000
Add @ticket annotations for [45812].
Props birgire.
See #43709.
No action taken yet
git: a100d0c
svn: r45819
115 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-16 01:39:59 +0000
Build Tools: Improve `local-env` start behaviour under Docker Toolbox.
Docker Toolbox requires port forwarding to be configured, but generates error when trying to forward a port that's already been taken.

This change removes clashing port forwarding rules before adding our own.

See #47767.
No action taken yet
git: f3241f4
svn: r45818
116 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-16 00:38:42 +0000
Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`.
See #44640.
No action taken yet
git: e961891
svn: r45817
117 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-16 00:23:40 +0000
Taxonomy: In `feed_links_extra()` and `get_the_archive_title()`, make sure the queried taxonomy term exists before accessing its properties.
Props donmhico, truchot, zaantar.
Fixes #46420.
No action taken yet
git: beb1d3a
svn: r45816
118 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-16 00:20:58 +0000
Coding Standards: In `wlwmanifest_link()`, use concatenation instead of commas for `echo`, for consistency with `rsd_link()` and the rest of core.
See #47632.
No action taken yet
git: 5a98103
svn: r45815
119 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 23:08:31 +0000
REST API: Add @ticket annotation to test from [45813].
Props birgire.
See #42209.
No action taken yet
git: 7113ab1
svn: r45814
120 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-15 23:00:38 +0000
Administration: In `add_settings_error()`, add `warning` and `info` as possible values for message type.
Account for these new values in `settings_errors()`, resulting in `notice-warning` and `notice-info` CSS classes.

Map legacy `error` and `updated` CSS classes to `notice-error` and `notice-success`.

Props donmhico, toddhalfpenny, flixos90, desrosj, javorszky, SergeyBiryukov.
Fixes #44640, #44941.
No action taken yet
git: d65b89c
svn: r45813
121 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 22:11:07 +0000
REST API: Always return post types list in taxonomies endpoint response as an array.
Prevents a non-sequential post type array such as [ 0 => 'post', 2 => 'page' ] from being improperly converted to an object in the taxonomy endpoint's response JSON.

Props TimothyBlynJacobs, birgire, spectacula.
Fixes #42209.
No action taken yet
git: 8f10077
svn: r45812
122 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 22:00:49 +0000
REST API: Prevent deletion of post revisions.
Allowing the client to delete revisions breaks the "audit trail" functionality. This is not allowed in WordPress and shouldn't be allowed through the API.
While not recommended, a plugin may opt-in to the previous behavior by setting a custom 'delete_post' capability for the revisions post type.

Props dlh, danielbachhuber, TimothyBlynJacobs, azaozz, kadamwhite.
Fixes #43709.
No action taken yet
git: eb468c4
svn: r45811
123 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 21:08:05 +0000
REST API: Cache results of get_item_schema on controller instances for performance.
Caches the output of get_item_schema() to avoid redundant recomputation of translatable strings and other computed values. This method is called many times per item in each REST request, and the results of the method should not vary between calls.
Additional schema fields are not cached.

Props kadamwhite, joehoyle, TimothyBlynJacobs.
Fixes #47871.
No action taken yet
git: 94b8a12
svn: r45810
124 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 20:03:18 +0000
REST API: Clarify arguments passed to rest route get & update callbacks.
Update doc block argument definitions to clarify that the REST API always passes an array to the `get_callback` and always passes an entity object to the `update_callback`.

Props TimothyBlynJacobs, salzano.
Fixes #44432.
No action taken yet
git: 80e44e4
svn: r45809
125 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 19:55:13 +0000
REST API: Do not send response body if status is 204 or body is null.
Status code 204 should indicate no response body is sent. Previously, a "null" string was sent, which MacOS Safari would try to parse as JSON and thereby fail to complete the request.

Props TimothyBlynJacobs, andizer, matthias.thiel.
Fixes #43691.
No action taken yet
git: 22480c0
svn: r45808
126 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 17:20:02 +0000
REST API: Add test class file incorrectly omitted from [45807].
Props @TimothyBlynJacobs.
See #43392.
No action taken yet
git: c92ef7c
svn: r45807
127 of 2469
Author
K. Adam White <[email protected]> 2019-08-15 17:16:21 +0000
REST API: Support 'object' and 'array' types in register_meta() schemas.
Extends meta registration to support complex schema values, mirroring the functionality in the settings controller.
Error when trying to modify a meta key containing schema-nonconformant data.

Props @TimothyBlynJacobs, @birgire, @mnelson4, @flixos90.
Fixes #43392.
No action taken yet
git: a636529
svn: r45806
128 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-15 13:05:39 +0000
Users: When deleting users, exclude the current user from the content existence check.
The current user cannot be deleted, so the check is redundant in that context and should only be done for other users.

Props mt8.biz, SergeyBiryukov.
Fixes #47851.
No action taken yet
git: 9c3fb72
svn: r45805
129 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-15 07:12:04 +0000
Schema: Add an index to `wp_options.autoload`.
Most sites will be unaffected by this change, but those with a large number of rows in `wp_options`, only a small number of which have `autoload` set, will see a significant performance improvement.

Sites with a large number of rows in `wp_options`, with many of them having `autoload` set will unfortunately see a performance penalty on top of the already very slow queries they're running, but this should be the minority of cases.

Props DanBUK.
Fixes #24044.
No action taken yet
git: e982455
svn: r45804
130 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-15 01:20:52 +0000
Networks and Sites: Trim site domain when creating a new site on Add New Site screen before further validation.
Props dharmin16, jeremyfelt, aubreypwd.
Fixes #44808.
No action taken yet
git: 4f86944
svn: r45803
131 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-15 00:41:25 +0000
Docs: Add missing `@since` tag for `WP_Site_Health::has_late_cron()`.
See #47223.
No action taken yet
git: 0d2b94a
svn: r45802
132 of 2469
Author
Peter Wilson <[email protected]> 2019-08-15 00:36:38 +0000
Site Health Check: New tests file missed in [45801].
No action taken yet
git: f29952a
svn: r45801
133 of 2469
Author
Peter Wilson <[email protected]> 2019-08-15 00:34:53 +0000
Site Health Check: Increase time allowance for cron checks.
Introduces `WP_Site_Health::has_late_cron()` for late wp-cron jobs and extends the time allowance before a job is considered missed.

In a standard configuration using loopback requests, a job is considered late once past due and missed over five minutes past due.

Late and missed time frames are extended if `DISABLE_WP_CRON` is defined as `true` to allow for crontab tasks running less frequently. A job is considered late once it's 15 minutes past due and missed over one hour past due.

A file for site health unit tests has been introduced with tests for cron in critical, late and missed states.

Props rockfire, afragen, peterwilsoncc.
Fixes #47223.
No action taken yet
git: f756d80
svn: r45800
134 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-15 00:33:32 +0000
Build Tools: Change the PHPUnit Docker image's working directory to match the other images.
Also, pass the `WP_MULTISITE` environment variable along to the container.

See #47767.
No action taken yet
git: da411cd
svn: r45799
135 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-14 23:11:39 +0000
Build Tools: Run `composer` commands in a Docker container on Travis.
This tidies up the `.travis.yml` file a little more.

See #47767.
No action taken yet
git: a2a28e4
svn: r45798
136 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 23:02:25 +0000
Widgets: Allow for short-circuiting widget output in `the_widget()` using the `widget_display_callback` filter, for consistency with output via a registered sidebar.
Props MarcGuay, donmhico.
Fixes #34226.
No action taken yet
git: 1177e12
svn: r45797
137 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 17:46:20 +0000
Docs: Correct type for `query_var` argument of `register_taxonomy()`.
Props juiiee8487, audrasjb.
Fixes #47877.
No action taken yet
git: a58eb86
svn: r45796
138 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 17:17:51 +0000
Posts, Post Types: In `wp_trim_words()` make sure the `$num_words` parameter is always an integer, as documented, to avoid a PHP warning.
Props donmhico, pikamander2.
Fixes #47867.
No action taken yet
git: d4a3052
svn: r45795
139 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 15:35:19 +0000
Users: Make `wp_list_authors()` unit tests more readable.
See #23498.
No action taken yet
git: 5bcd25a
svn: r45794
140 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 14:28:52 +0000
Networks and Sites: Improve documentation and variable naming in `switch_to_blog()` and `restore_current_blog()`.
In `switch_to_blog()`:

* Rename `$blog_id` to `$prev_blog_id` for clarity.
* Rename `$new_blog` to `$new_blog_id` for consistency.
* Pass `$prev_blog_id` as a second parameter to `switch_blog` action, instead of the duplicated `$new_blog_id`. This only clarifies documentation and does not affect functionality, since the values are equal in the context where the DocBlock is located.

In `restore_current_blog()`:

* Rename `$blog` to `$new_blog_id` for clarity.
* Rename `$blog_id` to `$prev_blog_id` for clarity.

Props ChriCo, jeremyfelt, SergeyBiryukov.
Fixes #45594.
No action taken yet
git: 94f4dcd
svn: r45793
141 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 02:01:26 +0000
Plugins: Adjust the pause before running plugin search AJAX request on "Add Plugins" screen to allow more time for using browser's autocomplete.
Props donmhico, apermo.
Fixes #46021.
No action taken yet
git: e196360
svn: r45792
142 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-14 00:01:40 +0000
Coding Standards: Fix JSHint error in [45790].
See #41545.
No action taken yet
git: ee1159c
svn: r45791
143 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-13 23:34:53 +0000
Site Health: Simplify the language in Status Health Info page introduction, add a link to Status page.
Props birgire, mukesh27, subrataemfluence, leogermani.
Fixes #46946.
No action taken yet
git: 98255d4
svn: r45790
144 of 2469
Author
Adam Silverstein <[email protected]> 2019-08-13 21:25:57 +0000
Comments: enable typing cmd/ctrl-enter to submit comment forms.
Add a key handler on the comment form that detects the cmd/ctrl-enter key press and submits the comment form. 

Props xyfi, Lindstromer, helen, splitti.
Fixes #41545.
No action taken yet
git: 9a20a07
svn: r45789
145 of 2469
Author
Andrew Ozz <[email protected]> 2019-08-13 19:52:50 +0000
Remove trailing white space in upgrade.php.
See #46349.
No action taken yet
git: 6dad32d
svn: r45788
146 of 2469
Author
Andrew Ozz <[email protected]> 2019-08-13 17:39:06 +0000
Admin email verification:
- Add the `admin_email_lifespan` option when installing. Fixes a bug where the verification screen is shown right after installation.
- Reset the same option when upgrading and the user doing the DB upgrade is not an admin. This will ensure the email verification is shown next time an admin logs in.
- Use `site_url()` instead of `network_site_url()` for the form action. The latter seems needed only for password reset.

See #46349.
No action taken yet
git: feb0830
svn: r45787
147 of 2469
Author
Peter Wilson <[email protected]> 2019-08-13 05:08:14 +0000
Comments: Include post permalink in comment reply link.
Include the post's permalink when generating reply links in `get_comment_reply_link()` to account for comments displayed on index and archive pages.

This reapplies [32786] which was inadvertently reverted in [42360].

Props justinahinon, donmhico.
See #33383.
Fixes #47174.
No action taken yet
git: 3d53fdb
svn: r45786
148 of 2469
Author
K. Adam White <[email protected]> 2019-08-13 01:51:00 +0000
Docs: Clarify custom-fields support requirement for viewing custom post meta in REST API.
Fixes #47866.
No action taken yet
git: 457a57a
svn: r45785
149 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-12 09:22:00 +0000
Build Tools: Remove the old `docker-compose.yml` file, now no longer used.
See #47767.
No action taken yet
git: 4311bac
svn: r45784
150 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-12 09:20:06 +0000
Build Tools: Add the `docker-compose.yml` file, missed in [45783].
See #47767.
No action taken yet
git: 13d3566
svn: r45783
151 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-12 08:28:33 +0000
Build Tools: Miscellaneous `local-env` improvements.
- Move the functionality for controlling `local-env` out of `package.json`, into JS scripts.
- Merge the `docker-compose` config files, and move it to the root directory. This allows `docker-compose.override.yml` to work for local overrides.
- Fix nginx redirecting to port 80 under some circumstances.
- `npm run env:install` now creates `wp-tests.config.php` for you.
- Cleaned up a bunch of cruft in `.travis.yml`.

See #47767.
No action taken yet
git: 83eb411
svn: r45782
152 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-12 01:53:17 +0000
Site Health: Add database charset and collation information to debug info.
Props sharaz, Clorith, SergeyBiryukov.
Fixes #47828.
No action taken yet
git: c76271c
svn: r45781
153 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-11 17:20:51 +0000
Docs: Improve documentation for various feed link functions and filters.
Props atachibana, SergeyBiryukov.
Fixes #47862.
No action taken yet
git: 64eeede
svn: r45780
154 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-11 16:17:16 +0000
Docs: Improve documentation for `get_last_updated()`.
Props atachibana.
Fixes #47861.
No action taken yet
git: 2659219
svn: r45779
155 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-11 12:41:34 +0000
Docs: Improve documentation for `get_page_by_title()`.
Props atachibana.
Fixes #47860.
No action taken yet
git: 6ca6c44
svn: r45778
156 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-10 22:27:02 +0000
Docs: Document the `show_split_view` argument for `wp_text_diff()`.
Convert `$args` array documentation to hash notation.

Props riddhiehta02, jeremyfelt, SergeyBiryukov.
Fixes #47224.
No action taken yet
git: f88cc8a
svn: r45777
157 of 2469
Author
Jake Spurlock <[email protected]> 2019-08-09 17:05:13 +0000
Widgets: Replace http with https in the link placeholder widget image
The existing placeholder can make the user think that they must use http. We should encourage the use of https. 
Also, the block editor uses https for its placeholders. Let's add some consistency.

Props Chaton666, audrasjb, mukesh27.
Fixes #46320.
No action taken yet
git: 4513c3f
svn: r45776
158 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-09 13:52:49 +0000
Twenty Sixteen: Correct HelpHub URL in `readme.txt`.
See #47771.
No action taken yet
git: 5b2c4b5
svn: r45775
159 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-09 13:41:38 +0000
Twenty Nineteen: Add missing `Installation` section to `readme.txt`, for consistency with other themes.
See #47857.
No action taken yet
git: 570cadf
svn: r45774
160 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-09 13:35:57 +0000
Twenty Nineteen: Add missing copyright information.
Props poena, kjellr.
Fixes #47857.
No action taken yet
git: 18632fb
svn: r45773
161 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-09 02:56:40 +0000
Twenty Nineteen: Correct license URI.
Props munyagu, shital-patel.
Fixes #47850.
No action taken yet
git: 72529b3
svn: r45772
162 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-09 01:30:32 +0000
Feeds: Introduce the `get_self_link()` function.
Corresponds to the `self_link()` template function.

This matches other feed template functions, using one function to get the value, and a different function to echo it.

Props jojotjebaby, mobeen-abdullah, donmhico, audrasjb, dshanske.
Fixes #44838.
No action taken yet
git: 739bc58
svn: r45771
163 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-08 20:19:48 +0000
REST API: In `get_rest_url()`, check if `$_SERVER['SERVER_NAME']` is set to avoid a PHP warning in CLI context.
Props paulschreiber.
Fixes #47854.
No action taken yet
git: 3008781
svn: r45770
164 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-08 12:53:21 +0000
Bootstrap/Load: Change "Insufficient Requirements" `wp_die()` heading to "Requirements Not Met", which is more appropriate for the context it's used in.
Props yoavf.
Fixes #47575.
No action taken yet
git: c645936
svn: r45769
165 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-08 04:04:15 +0000
Emoji: Upgrade Twemoji to 12.1.2.
This upgrade adds support for the transgender flag: 🏳️‍⚧️

There's some additional housekeeping in this commit:

- Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that.
- As only new files were added in this Twemoji release, the CDN version didn't need updating.

Fixes #47852.
No action taken yet
git: 0d9ec05
svn: r45768
166 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-08 01:28:26 +0000
Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting.
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981.
No action taken yet
git: e58b5f1
svn: r45767
167 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-08 01:24:32 +0000
Bundled Themes: Audit and update version numbers passed to `wp_enqueue_style()` to ensure proper cache busting.
Props dswebsme, ianbelanger, desrosj.
Fixes #46979.
No action taken yet
git: 98642e4
svn: r45766
168 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-07 23:02:43 +0000
Administration: Show a warning in Reading Settings when a Privacy Policy page is accidentally set as a Homepage or Posts page.
Props garrett-eclipse, subrataemfluence.
Fixes #46831.
No action taken yet
git: 72d2ed8
svn: r45765
169 of 2469
Author
Aaron Jorbin <[email protected]> 2019-08-07 15:08:04 +0000
Bump grunt-patch-wordpress to 2.0.0
Fixes #47845
Props pento, kadamwhite, netweb, jorbin
No action taken yet
git: f57620a
svn: r45764
170 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-07 11:56:04 +0000
Twenty Seventeen: Correct height for a Button block without text.
Props ianbelanger, laurelfulford, nayana123.
Fixes #47414.
No action taken yet
git: e7c67d4
svn: r45763
171 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-07 11:55:46 +0000
Twenty Eleven: Correct height for a Button block without text.
Props ianbelanger, laurelfulford, nayana123.
See #47414.
No action taken yet
git: 4271f1a
svn: r45762
172 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-07 11:54:22 +0000
Build Tools: Switch all Travis PHPUnit jobs over to Docker-based PHP.
Additionally, there are a handful of related minor changes in this commit:
- `.travis.yml` has been tidied up a little.
- [45745] was incorrectly marking Travis jobs as passed when some PHPUnit runs failed.
- Add the `LOCAL_PHP_MEMCACHED` environment variable, for enabling Memcached.
- Add the `env:pull` NPM script, for refreshing Docker images.

See #47767.
No action taken yet
git: 008085d
svn: r45761
173 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-07 11:47:26 +0000
Twenty Nineteen: Revise Latest Posts block styles to support post content options.
Props kjellr, ianbelanger.
Fixes #47340.
No action taken yet
git: 20905d6
svn: r45760
174 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-07 11:40:28 +0000
Twenty Nineteen: Remove duplicate `height` and `width` attributes from SVG icons.
The attributes are added via `TwentyNineteen_SVG_Icons::get_svg()`, there's no need to have them separately in SVG sources.

Props mukesh27, albertomake.
Fixes #47128.
No action taken yet
git: 10e13da
svn: r45759
175 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-07 11:40:00 +0000
Coding Standards: Use strict comparison in `wp-admin/edit.php`.
Props davidbaumwald.
Fixes #47201.
No action taken yet
git: 93aa98c
svn: r45758
176 of 2469
Author
Andrew Ozz <[email protected]> 2019-08-07 01:00:06 +0000
Remove trailing white space in upgrade.php after [45757].
See #46349.
No action taken yet
git: 296d864
svn: r45757
177 of 2469
Author
Andrew Ozz <[email protected]> 2019-08-07 00:03:39 +0000
Add admin email verification screen. Shown every six months after an admin has logged in.
Also includes WPCS fixes for wp-login.php.

Props andraganescu, boemedia, lessbloat, azaozz.
See #46349.
No action taken yet
git: bab0d4e
svn: r45756
178 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 22:19:10 +0000
Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.
Props jobthomas, burhandodhy.
Fixes #47815.
No action taken yet
git: 4bbe1ab
svn: r45755
179 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 18:09:20 +0000
Coding Standards: Fix WPCS violation in [45754].
See #46570.
No action taken yet
git: fad1821
svn: r45754
180 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 13:54:43 +0000
General: Correctly detect large floats in `is_serialized()`.
Props killerbishop, donmhico, hoythan.
Fixes #46570.
No action taken yet
git: 9bb2eea
svn: r45753
181 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 13:14:25 +0000
Feeds: Escape `&` characters in `atom_site_icon()` for XML, for consistency with `rss2_site_icon()`.
Props abhijitrakas, shawfactor.
Fixes #47482.
No action taken yet
git: 7b11f12
svn: r45752
182 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 12:51:33 +0000
Coding Standards: Use strict comparison in `wp-admin/options-reading.php`.
Props subrataemfluence.
Fixes #46834.
No action taken yet
git: c68927e
svn: r45751
183 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 11:06:27 +0000
Plugins: Use `include_once` for `wp-admin/includes/plugin-install.php` in `WP_Plugin_Install_List_Table::prepare_items()`.
This brings consistency with the other instances where the file is included, and allows for reusing its functions in custom code.

Props engelen, desrosj.
Fixes #38874.
No action taken yet
git: 3f2e265
svn: r45750
184 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 10:57:04 +0000
Site Health: Use correct variable when checking PHP requirements for a plugin update in `WP_Plugins_List_Table::single_row()`.
Props diddledan, sharaz, vaishalipanchal.
Fixes #47835.
No action taken yet
git: 7110d55
svn: r45749
185 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 08:11:28 +0000
Docs: Correct `@type` annotation for `WP_Http_Curl` properties.
Props diddledan.
Fixes #46860.
No action taken yet
git: 89058d3
svn: r45748
186 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 07:55:15 +0000
Docs: Correct `@type` annotation for `WP_HTTP_Cookie::$expires`.
Props diddledan.
Fixes #46859.
No action taken yet
git: 62f6907
svn: r45747
187 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 07:47:43 +0000
Upgrade/Install: Make sure `translate_level_to_role()` always returns a value.
Props diddledan.
Fixes #46848.
No action taken yet
git: 89c1d39
svn: r45746
188 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-05 07:43:52 +0000
Posts, Post Types: Update, not delete the `page_for_posts` option in `_reset_front_page_settings_for_post()` when a linked page is deleted or trashed.
Props diddledan.
Fixes #46850.
No action taken yet
git: 82d7870
svn: r45745
189 of 2469
Author
Gary Pendergast <[email protected]> 2019-08-05 07:09:14 +0000
Build Tools: Add a WordPress Development Environment.
This commit adds the first iteration of a Docker-based config for setting up a local WordPress development environment.

Props pento, noisysocks, mcsf, pbearne, isabel_brison.
See #47767.
No action taken yet
git: 3705fdd
svn: r45744
190 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 14:43:21 +0000
Posts, Post Types: Revert unintended change from [45742].
See #46503.
No action taken yet
git: b536f1d
svn: r45743
191 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 13:02:58 +0000
Administration: Display a warning at the top of "All Settings" screen.
Props zodiac1978, donmhico, pixolin.
Fixes #47718.
No action taken yet
git: 7a6f44b
svn: r45742
192 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 12:27:02 +0000
Docs: Add missing description for `$post` global.
Props immeet94.
Fixes #46503. See #47110.
No action taken yet
git: b440cd9
svn: r45741
193 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 02:19:19 +0000
Docs: Remove incorrect `@return` tags in `comment_reply_link()` and `post_reply_link()` DocBlocks.
Props atachibana.
Fixes #47826.
No action taken yet
git: a7b20de
svn: r45740
194 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 02:02:10 +0000
Docs: Add missing description for `$current_screen` global.
Props mukesh27.
Fixes #45604. See #47110.
No action taken yet
git: d19f4d7
svn: r45739
195 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 01:58:03 +0000
Docs: Add missing description for `$wp_query` and `$wp_the_query` globals.
Props mukesh27.
See #45604, #47110.
No action taken yet
git: 5af994b
svn: r45738
196 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 01:46:34 +0000
Docs: Add missing description for `$wp_locale_switcher` global.
See #45604, #47110.
No action taken yet
git: 1e6420b
svn: r45737
197 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 01:45:03 +0000
Docs: Add missing description for `$wp_locale` global.
Props mukesh27.
See #45604, #47110.
No action taken yet
git: 914509f
svn: r45736
198 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 01:27:22 +0000
Docs: Add missing description for `$wp` global.
See #45604, #47110.
No action taken yet
git: 9c1123f
svn: r45735
199 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 01:18:54 +0000
Docs: Add missing description for `$wp_rewrite` global.
See #45604, #47110.
No action taken yet
git: cb1d211
svn: r45734
200 of 2469
Author
SergeyBiryukov <[email protected]> 2019-08-04 01:11:01 +0000
Docs: Add missing description for `$wpdb`, `$wp_db_version`, and `$wp_current_db_version` globals.
Props mukesh27, utsav72640, immeet94, SergeyBiryukov.
See #45604.
No action taken yet
git: cbbaca7
svn: r45733
201 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 00:47:20 +0000
Docs: Fix typo in a comment in `WP_Site_Health::get_test_theme_version()`.
See #47110.
No action taken yet
git: 17d1f40
svn: r45732
202 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-04 00:01:14 +0000
Site Health: If `WP_DEFAULT_THEME` doesn't exist, use `WP_Theme::get_core_default_theme()` as a fallback.
Props ajayghaghretiya1, juliobox, SergeyBiryukov.
Fixes #47299.
No action taken yet
git: f0f94ae
svn: r45731
203 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-03 22:16:23 +0000
Script Loader: Send a 400 Bad Request status code in `load-scripts.php` and `load-styles.php` if the required `load[]` parameter is not set.
Props compilenix.
Fixes #44108.
No action taken yet
git: 5ed5587
svn: r45730
204 of 2469
Author
Aaron Jorbin <[email protected]> 2019-08-03 20:20:42 +0000
PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax
PHP used to allow both square brackets and curly braces to be used interchangeably for accessing array elements and string offsets. The curly bracket syntax is only allowed in a limited set of cases and can be confusing for people not used to it.
PHP 7.4 will deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

See #47751.
Props jrf.
No action taken yet
git: 1f92cbb
svn: r45729
205 of 2469
Author
Andrea Fercia <[email protected]> 2019-08-03 15:45:06 +0000
Accessibility: Improve the differences between revisions.
Color alone is not sufficient to visually communicate differences.

- adds `plus` and `minus` icons to the changed lines
- adds visually hidden text: `Added`, `Deleted`, and `Unchanged` to clarify the differences to assistive technologies users

Props birgire, audrasjb, kjellr, adamsilverstein.
Fixes #43532.
No action taken yet
git: 882d3f5
svn: r45728
206 of 2469
Author
Andrea Fercia <[email protected]> 2019-08-03 13:27:43 +0000
Accessibility: Remove title attributes from the Meta widget.
- removes the `Powered by WordPress, state-of-the-art semantic personal publishing platform.` title attribute
- removes the title attribute from the abbreviations: contrary to a common belief, title attributes on abbreviations are only available to a minority of users, see https://developer.paciellogroup.com/blog/2019/03/short-note-the-abbreviation-appreciation-society/
- changes the term `RSS` to `feed`, as `RSS` is a technical term not all users are supposed to be familiar with
- improves the `widget_meta_poweredby` filter documentation

Props nishitlangaliya, chetan200891, audrasjb.
See #46980, #24766.
Fixes #46978.
No action taken yet
git: f82b40a
svn: r45727
207 of 2469
Author
Andrea Fercia <[email protected]> 2019-08-03 12:18:50 +0000
Menus: Fix the Custom Links text fallback.
When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: ` (Pending)`, with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415.
No action taken yet
git: b1ccaf8
svn: r45726
208 of 2469
Author
Andrea Fercia <[email protected]> 2019-08-03 11:52:51 +0000
Accessibility: Improve the way emojis are announced by screen readers.
Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role.
Tested with Safari 12.1.1 / VoiceOver 9.

Props pento.
See #37486.
No action taken yet
git: 101fd06
svn: r45725
209 of 2469
Author
Andrea Fercia <[email protected]> 2019-08-03 11:35:19 +0000
Accessibility: Fix the `alt` attribute of the Gallery images within the Classic Editor.
Passes the images `alt` attribute value to the Gallery template used within the Classic Editor.

Props yarnboy, wpboss.
Fixes #47687.
No action taken yet
git: a634252
svn: r45724
210 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-03 03:46:46 +0000
Posts, Post Types: Check the result of `wp_update_post()` in `wp_trash_post()` and `wp_untrash_post()`.
Props abhijitrakas, manzoorwani.jk, siliconforks.
Fixes #47773.
No action taken yet
git: 3c73c7a
svn: r45723
211 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-03 03:34:54 +0000
Taxonomy: Fix deprecated calls to `get_terms()`.
The taxonomy should be passed as part of `$args`, rather than as its own argument.

Props sgastard, mukesh27, SergeyBiryukov.
Fixes #47819.
No action taken yet
git: 2adeb5b
svn: r45722
212 of 2469
Author
Andrea Fercia <[email protected]> 2019-08-02 17:08:29 +0000
Customize: Make the color picker close when clicking on the empty area on the right.
Props monikarao.
Fixes #47693.
No action taken yet
git: 73e1cdf
svn: r45721
213 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-02 03:08:06 +0000
Twenty Thirteen: Make `twentythirteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise.
See #32096.
No action taken yet
git: ce00f0b
svn: r45720
214 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-02 03:07:58 +0000
Twenty Fifteen: Make `twentyfifteen_author_bio_template()` use author templates if exist, fall back to regular template hierarchy otherwise.
See #32096.
No action taken yet
git: 35e070c
svn: r45719
215 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-02 02:32:58 +0000
Twenty Thirteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username.
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
Fixes #32096.
No action taken yet
git: f6f0ac5
svn: r45718
216 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-02 02:32:35 +0000
Twenty Fifteen: Prevent `author-bio.php` partial template from interfering with rendering an author archive of a user with the `bio` username.
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
See #32096.
No action taken yet
git: 6c78848
svn: r45717
217 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 19:53:45 +0000
Users: Clean user cache in `check_password_reset_key()` tests.
Props davidbaumwald, spacedmonkey.
See #45845.
No action taken yet
git: eedb119
svn: r45716
218 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 19:18:28 +0000
Users: Replace raw SQL query in `check_password_reset_key()` with `get_user_by()`.
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845.
No action taken yet
git: 750a5c4
svn: r45715
219 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 17:48:31 +0000
Users: Use `clean_user_cache()` in `wp_insert_user()`, `wp_update_user()`, `wp_set_password()`, `add_user_to_blog()`.
Props spacedmonkey.
Fixes #47021.
No action taken yet
git: f912470
svn: r45714
220 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 17:24:20 +0000
Users: Use `wp_update_user()` in `get_password_reset_key()`.
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746.
No action taken yet
git: 65254fd
svn: r45713
221 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 17:12:42 +0000
Users: Reorganize `user_nicename`, `user_url`, `user_registered` setting in `wp_insert_user()` for consistency with the order or fields in the database.
See #45746.
No action taken yet
git: 1e0309b
svn: r45712
222 of 2469
Author
SergeyBiryukov <[email protected]> 2019-08-01 15:29:02 +0000
Users: Use `get_password_reset_key()` in `wp_new_user_notification()`.
Props mrasharirfan, spacedmonkey.
Fixes #45745.
No action taken yet
git: 69aa6b5
svn: r45711
223 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 15:03:33 +0000
Taxonomy: Correct some strict comparisons after [45710].
See #47573.
No action taken yet
git: bdcc896
svn: r45710
224 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 13:44:04 +0000
Coding Standards: Use strict comparison in `wp-includes/taxonomy.php`.
Props andizer, SergeyBiryukov.
Fixes #47573.
No action taken yet
git: 209a72c
svn: r45709
225 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 12:02:30 +0000
Coding Standards: Fix WPCS violations after [45708].
See #45747.
No action taken yet
git: 03122ef
svn: r45708
226 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 11:27:28 +0000
Users: Deprecate `update_user_status()` in favor of `wp_update_user()`.
Props spacedmonkey, SergeyBiryukov.
Fixes #45747.
No action taken yet
git: 1878f25
svn: r45707
227 of 2469
Author
Sergey Biryukov <[email protected]> 2019-08-01 02:24:08 +0000
Database: Use a strict comparison for `has_filter()` check in `wpdb::placeholder_escape()`.
The filter is added with a priority of `0`, so a loose comparison had an unintended effect of adding the filter on every call.

Props withinboredom.
Fixes #47430.
No action taken yet
git: a875f9d
svn: r45706
228 of 2469
Author
K. Adam White <[email protected]> 2019-07-31 20:20:02 +0000
REST API: Skip processing fields which are not present in the selected context.
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.

In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.

Props dlh.
Fixes #45605.
No action taken yet
git: 7aae0cf
svn: r45705
229 of 2469
Author
K. Adam White <[email protected]> 2019-07-31 19:59:30 +0000
REST API: Generate sample permalink only when a dependent field is requested.
The sample permalink will now only be generated if the derivative `permalink_template` or `generated_slug` fields are to be included in the response, preventing an unnecessary database request for each post (via `wp_unique_post_slug()`) when those fields are not requested.

Props dlh.
See #45605.
No action taken yet
git: 57443a6
svn: r45704
230 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-31 15:09:55 +0000
Docs: Correct parameter documentation for `bulk_edit_custom_box` and `quick_edit_custom_box` actions.
Props abrain.
Fixes #47810.
No action taken yet
git: a8a4c09
svn: r45703
231 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-31 01:25:43 +0000
Docs: Correct parameter type and description for `is_email` filter.
Props jenkoian.
Fixes #47793.
No action taken yet
git: 288681a
svn: r45702
232 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-31 01:18:23 +0000
Docs: Correct `@return` value description for `get_term_link()`.
Props garrett-eclipse.
Fixes #47806.
No action taken yet
git: c83f0b0
svn: r45701
233 of 2469
Author
Tammie Lister <[email protected]> 2019-07-30 23:19:18 +0000
Media: Reduces the bulk media options to have one primary button
This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757, #46758
No action taken yet
git: 2f52d5a
svn: r45700
234 of 2469
Author
Tammie Lister <[email protected]> 2019-07-30 22:53:19 +0000
Admin: Improve Dashboard icon contrast.
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.

Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr 
Fixes #46935
No action taken yet
git: da0f9cd
svn: r45699
235 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 17:51:34 +0000
Rewrite Rules: Check if `$wp_rewrite->flush_rules()` is callable before calling it in `flush_rewrite_rules()`.
Props bsetiawan88, markjaquith.
Fixes #47087.
No action taken yet
git: aee18a2
svn: r45698
236 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 17:41:23 +0000
Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen.
Props trepmal.
Fixes #47119.
No action taken yet
git: 4dbc842
svn: r45697
237 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 16:51:46 +0000
Coding Standards: Fix WPCS violations in `wp-admin/includes/class-walker-nav-menu-edit.php`.
Props sudhiryadav, audrasjb.
Fixes #46902.
No action taken yet
git: 4eabbd6
svn: r45696
238 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 16:51:26 +0000
Coding Standards: Fix WPCS violations in [45694].
See #47466.
No action taken yet
git: f793983
svn: r45695
239 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 16:34:58 +0000
Docs: Improve the DocBlocks for `got_mod_rewrite()`, `extract_from_markers()`, `insert_with_markers()`.
See #47110.
No action taken yet
git: d7ec5b4
svn: r45694
240 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 16:30:46 +0000
Rewrite Rules: Add a comment to `# BEGIN/END` `.htaccess` markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters.
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.

Props bradleyt, SergeyBiryukov.
Fixes #47466.
No action taken yet
git: 806d151
svn: r45693
241 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 16:10:35 +0000
Permalinks: Improve appearance of URL examples on Permalink Settings screen.
Props luan-ramos, sarath.ar.
Fixes #41559.
No action taken yet
git: 5c6b35c
svn: r45692
242 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 16:08:47 +0000
Administration: Allow breaking long strings in `<code>` tags at any point, to avoid overflowing on mobile.
Props david.binda, mukesh27.
Fixes #47329.
No action taken yet
git: df874c9
svn: r45691
243 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-28 14:54:06 +0000
Site Health: Consistently use `wpdb::db_version()` for checking the database server version, instead of partically replicating its functionality.
Props Clorith, wpfed.
Fixes #47738.
No action taken yet
git: 3df5f2a
svn: r45690
244 of 2469
Author
Dominik Schilling <[email protected]> 2019-07-27 14:30:19 +0000
I18N: Display the logged out message in the user's locale
No action taken yet
git: 41dc7c7
svn: r45689
245 of 2469
Author
Dominik Schilling <[email protected]> 2019-07-27 14:29:28 +0000
I18N: Following [45688], remove test for removed method.
See #44865.
No action taken yet
git: 3503320
svn: r45688
246 of 2469
Author
Dominik Schilling <[email protected]> 2019-07-27 14:16:59 +0000
I18N: Use RTL stylesheets when running from /src.
To run WordPress from /src you have to use the `--dev` flag which also builds the RTL stylesheets thus the admin notice and force to LTR is no longer required.

See #44492.
Fixes #44865.
No action taken yet
git: 3ea5731
svn: r45687
247 of 2469
Author
Dominik Schilling <[email protected]> 2019-07-27 13:43:41 +0000
REST API: Pass current request object to `rest_authentication_errors` filter in `WP_REST_Server::check_authentication()`.
Fixes #46907.
No action taken yet
git: 2f1afbc
svn: r45686
248 of 2469
Author
Dominik Schilling <[email protected]> 2019-07-27 13:09:16 +0000
Tools: Remove internationalization tools (also known as `makepot.php`).
It has been a great pleasure to work with `makepot.php` over the past [https://i18n.trac.wordpress.org/changeset/4169/ 11 years] but now it's time to say goodbye.
The tools have been integrated into WP-CLI as [https://developer.wordpress.org/cli/commands/i18n/make-pot/ wp i18n make-pot] and [https://developer.wordpress.org/cli/commands/i18n/make-json/ wp i18n make-json]. The new commands were optimized to support current PHP versions and are more flexible and reliable when extracting strings for PHP, and JavaScript.

Access to the old tools continue to exist in previous branches or at https://i18n.svn.wordpress.org/tools/.

Fixes #45287.
No action taken yet
git: 84b9779
svn: r45685
249 of 2469
Author
Dominik Schilling <[email protected]> 2019-07-27 12:43:56 +0000
I18N: Add support for custom `WP_PLUGIN_URL` in `load_script_textdomain()`.
Plugins may not be on the same host/path as the rest of the content. To support loading translations for this setup check if the script source matches `plugins_url()`.
Also fixes an undefined index notice when a custom content URL has no path.

Props odminstudios, ocean90.
Fixes #46336, #46387.
No action taken yet
git: 160fc05
svn: r45684
250 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-26 22:03:31 +0000
Accessibility: Toolbar: Make the `min-width` value for `#wpadminbar` at `782px` breakpoint consistent with that of `<body>`.
This ensures that the "My Account" toolbar item stays visible at high zoom levels.

Props isabel_brison, chetan200891.
Fixes #47603.
No action taken yet
git: 5618dfc
svn: r45683
251 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-26 17:45:21 +0000
Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607.
No action taken yet
git: 7493196
svn: r45682
252 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-26 13:48:52 +0000
Administration: Merge CSS rules for `#adminmenu .wp-submenu a` in one place.
Props ozmatflc, AkSDvP.
Fixes #47780.
No action taken yet
git: 455cc05
svn: r45681
253 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-26 13:19:44 +0000
REST API: Make "Could not update meta value in database" error messages more helpful.
Props apermo, AkSDvP.
Fixes #46252.
No action taken yet
git: 230960f
svn: r45680
254 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-26 03:48:32 +0000
Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes".
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925.
No action taken yet
git: d18b725
svn: r45679
255 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-26 00:11:37 +0000
Coding Standards: Fix newlines in `wp-includes/date.php`.
See #47775.
No action taken yet
git: 0eaaf84
svn: r45678
256 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 23:30:21 +0000
Coding Standards: Move `wp-includes/date.php` to `wp-includes/class-wp-date-query.php`.
This renames the file containing the `WP_Date_Query` class to conform to the coding standards.

This commit also includes:

- A new `date.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

Fixes #47775. See #47632.
No action taken yet
git: 48120a1
svn: r45677
257 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 22:55:36 +0000
I18N: Update translator comment missed in [45676].
See #47771.
No action taken yet
git: 004ff0e
svn: r45676
258 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 22:51:53 +0000
I18N: Update translator comments after [45674].
See #47771.
No action taken yet
git: 5b86d71
svn: r45675
259 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 22:45:48 +0000
Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article.
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
No action taken yet
git: ae8a620
svn: r45674
260 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 22:44:48 +0000
General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.
No action taken yet
git: 77a1f39
svn: r45673
261 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 19:10:33 +0000
Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, [email protected], bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.
No action taken yet
git: f00229a
svn: r45672
262 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 15:18:05 +0000
Docs: Clarify that `is_network_admin()` does not check if the site is a Multisite network; `is_multisite()` should be used for that.
Props svovaf, dilipbheda, tazotodua.
Fixes #47415.
No action taken yet
git: 128597b
svn: r45671
263 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 01:35:52 +0000
Posts, Post Types: Introduce `is_sticky` filter in `is_sticky()` to provide more flexibility for custom sticky post implementations.
Props dehisok, greenshady.
Fixes #37629.
No action taken yet
git: d758aa8
svn: r45670
264 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 01:26:13 +0000
Code Editor: Check for correct `mode` value in `wp.codeEditor.initialize` to enable autocomplete support for PHP.
Props ediamin.
Fixes #47769.
No action taken yet
git: 85f0ec3
svn: r45669
265 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 01:18:01 +0000
Permalinks: Update URLs for "Changing File Permissions" documentation article.
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768.
No action taken yet
git: 66be571
svn: r45668
266 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 01:06:45 +0000
Coding Standards: Use correct variable in `wp_dropdown_categories()` after [45667].
See #45059.
No action taken yet
git: e5a0610
svn: r45667
267 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-25 00:47:53 +0000
Coding Standards: Rename `$r` variable used with `wp_parse_args()` to `$parsed_args` for clarity.
Props freewebmentor.
Fixes #45059.
No action taken yet
git: 3d1714d
svn: r45665
268 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-19 07:47:16 +0000
Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests.
The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.

This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.

Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.

See #47632.
No action taken yet
git: ab26c9a
svn: r45664
269 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-19 04:42:00 +0000
Coding Standards: Fix a filename replacement missed in [45663].
See #47632.
No action taken yet
git: 4943b37
svn: r45663
270 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-19 04:31:40 +0000
Coding Standards: Move `wp-includes/class-oembed.php` to `wp-includes/class-wp-oembed.php`.
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.

This commit also includes:

- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.
No action taken yet
git: e0d8dbe
svn: r45662
271 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-19 04:01:41 +0000
Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php
This renames the file containing the Custom_Background class to conform to the coding standards.

This commit also includes:

- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.

See #47632.
No action taken yet
git: 968254f
svn: r45661
272 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-19 03:49:26 +0000
Coding Standards: Exclude a handful of incorrectly named files that won't be renamed.
See #47632.
No action taken yet
git: 8cf3e59
svn: r45660
273 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-19 00:08:38 +0000
Coding Standards: Improve spacing of `printf()` calls in the admin About pages.
Props garrett-eclipse.
Fixes #47734.
No action taken yet
git: 6ec230a
svn: r45659
274 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-18 12:40:39 +0000
I18N: Make URLs to `https://wordpress.org/about/` and related pages translatable, as they can now be localized on Rosetta sites.
Props mukesh27.
Fixes #46386.
No action taken yet
git: 0b06e59
svn: r45658
275 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-18 05:54:10 +0000
Customizer: Show all widgets when the search field is cleared.
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.

Props Mahesh901122.
Fixes #47534.
No action taken yet
git: e6e96d0
svn: r45657
276 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-18 01:32:13 +0000
Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected.
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.

Props garrett-eclipse, derweili, afercia.
Fixes #47487.
No action taken yet
git: 9db88b1
svn: r45656
277 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-17 19:21:28 +0000
Coding Standards: Fix WPCS issues in [45655].
See #47723.
No action taken yet
git: fd23000
svn: r45655
278 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-17 18:44:56 +0000
Menus: Trim whitespace from custom link URLs.
Props majemedia, SergeyBiryukov.
Fixes #47723.
No action taken yet
git: 8416a2b
svn: r45654
279 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-17 06:16:27 +0000
Coding Standards: Move `wp-admin/custom-header.php` to `wp-admin/includes/class-custom-image-header.php`
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.

This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.
No action taken yet
git: 3686fd8
svn: r45653
280 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-17 04:33:27 +0000
Coding Standards: Exclude some class names from checks when they can't be renamed.
Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.

See #47632.
No action taken yet
git: 3bb75e0
svn: r45652
281 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-17 01:49:08 +0000
Coding Standards: Fix WPCS issues in [45651].
See #38195.
No action taken yet
git: 9169163
svn: r45651
282 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-17 01:21:55 +0000
Media: Add "Documents", "Spreadsheets", and "Archives" groups to file type filter in Media Library.
Props zodiac1978, swissspidy, karmatosed, SergeyBiryukov.
Fixes #38195.
No action taken yet
git: ceeb99e
svn: r45650
283 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-17 01:10:59 +0000
Administration: In `admin-ajax.php`, send `X-Robots-Tag` header earlier, so that it applies before `wp_die()` when no action parameter was provided.
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711.
No action taken yet
git: 8df86ef
svn: r45649
284 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 22:27:55 +0000
Site Health: Use consistent verbiage for "Learn more" links.
Props ronakganatra, garrett-eclipse.
Fixes #47302.
No action taken yet
git: 94a6e06
svn: r45648
285 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 22:18:58 +0000
Site Health: Replace "harddrive" with "device" on Site Health Info screen.
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965.
No action taken yet
git: a65fcde
svn: r45647
286 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 22:13:01 +0000
I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings.
Props ramiy.
Fixes #47252.
No action taken yet
git: 2ae276c
svn: r45646
287 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 21:51:45 +0000
Media: Add a unit test for `wp_get_mime_types()`.
Props pbearne.
Fixes #47701.
No action taken yet
git: 9d00289
svn: r45645
288 of 2469
Author
Andrew Ozz <[email protected]> 2019-07-16 21:47:35 +0000
Media: Sort the new sizes array by priority when creating image sub-sizes.
See #40439.
No action taken yet
git: 98a2971
svn: r45644
289 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 21:32:21 +0000
Customize: In `WP_Customize_Widgets::capture_filter_pre_update_option()`, return the filtered value instead of `null` when bailing early for ignored options.
Props dlh.
Fixes #47715.
No action taken yet
git: 09fc7ba
svn: r45643
290 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 13:14:45 +0000
Docs: Move the `do_mu_upgrade` DocBlock out of the preceding `if` statement.
Props ChriCo, dkarfa.
Fixes #47710.
No action taken yet
git: 811b921
svn: r45642
291 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-16 12:41:16 +0000
Docs: Correct `@since` tag for `do_mu_upgrade` hook, for consistency with `after_mu_upgrade` and `wpmu_upgrade_site`.
See #47110.
No action taken yet
git: 1570f89
svn: r45641
292 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-15 16:45:58 +0000
Comments: Fix typo in comment reply observer options.
Props maguiar.
Fixes #47706. See #46260.
No action taken yet
git: 9f8a75e
svn: r45640
293 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-15 07:03:54 +0000
Code Modernisation: Revert [45624].
Changing the method signatures on `Walker` causes back compat issues.

See #47678.
No action taken yet
git: 2da7f9f
svn: r45639
294 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-15 06:24:08 +0000
Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays.
PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

This change fixes all of these warnings visible in unit tests.

Props jrf.
See #47704.
No action taken yet
git: e6c750b
svn: r45638
295 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-15 05:13:10 +0000
Code Modernisation: Document when the Hash polyfills can be removed.
The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.

Props jrf.
Fixes #47698.
No action taken yet
git: 593c402
svn: r45637
296 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-15 05:10:36 +0000
Code Modernisation: Remove the SPL autoloader polyfill.
As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.

The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.

Props jrf, ayeshrajans.
See #47698, #46630.
No action taken yet
git: f3b826d
svn: r45636
297 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-15 05:07:20 +0000
Code Modernisation: Remove the `array_replace_recursive()` polyfill.
This function was added in PHP 5.3.0, so we no longer need the polyfill.

Props jrf.
See #47698.
No action taken yet
git: 6b3ccc2
svn: r45635
298 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-15 04:06:24 +0000
WPDB: Allow custom data to be added to logged queries.
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.

Props CrazyJaco, johnbillion, pento.
Fixes 42151.
No action taken yet
git: eb9f88e
svn: r45634
299 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-14 14:46:10 +0000
I18N: Add context for theme filter strings in `WP_MS_Themes_List_Table::get_views()`.
Props audrasjb.
Fixes #47695.
No action taken yet
git: 60c7970
svn: r45633
300 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-14 14:38:43 +0000
Upgrade/Install: Remove debugging artifacts from `wp-admin/upgrade.php` added in [1229].
Props rahulvaza.
Fixes #47074.
No action taken yet
git: 0492ad7
svn: r45632
301 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-14 14:34:02 +0000
REST API: Allow `rest_get_avatar_urls()` to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data.
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.

Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030.
No action taken yet
git: a7041b9
svn: r45631
302 of 2469
Author
Andrew Ozz <[email protected]> 2019-07-12 03:24:20 +0000
TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab.
See #45307.
No action taken yet
git: 1f8d744
svn: r45630
303 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-12 00:16:34 +0000
Code Modernisation: Introduce the spread operator in `wpdb::prepare()`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: e0c9623
svn: r45629
304 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-12 00:13:07 +0000
Code Modernisation: Introduce the spread operator in `widgets.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: e6cde16
svn: r45628
305 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-12 00:09:31 +0000
Code Modernisation: Introduce the spread operator in `theme.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.
No action taken yet
git: 6e829a7
svn: r45627
306 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-12 00:04:57 +0000
Code Modernisation: Introduce the spread operator in `walk_page_dropdown_tree()`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 03b7742
svn: r45626
307 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-12 00:04:41 +0000
Customize: Fix text direction for color picker in RTL.
Props vjik for the report.
Fixes #47688. See #23740.
No action taken yet
git: 17ba89b
svn: r45625
308 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-12 00:01:19 +0000
Code Modernisation: Introduce the spread operator in `add_post_type_support()`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.
No action taken yet
git: 6c3ba83
svn: r45624
309 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-11 23:50:37 +0000
Code Modernisation: Introduce the spread operator in `Walker`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 1963a00
svn: r45623
310 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-11 23:47:56 +0000
Code Modernisation: Introduce the spread operator in `WP_User`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 50ec358
svn: r45622
311 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-11 23:45:22 +0000
Code Modernisation: Introduce the spread operator in `capabilities.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 6207043
svn: r45621
312 of 2469
Author
Andrew Ozz <[email protected]> 2019-07-11 18:29:09 +0000
Editor: Make registered editor stylesheets (editor-style.css) available to the front-end.
Props webmandesign, azaozz.
Fixes #34882.
No action taken yet
git: 944595c
svn: r45620
313 of 2469
Author
Andrew Ozz <[email protected]> 2019-07-11 18:17:46 +0000
TinyMCE: fix flickering inline toolbar when showing a tooltip. Take two.
Fixes #44911.
No action taken yet
git: ec2942e
svn: r45619
314 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-11 07:20:40 +0000
Block Editor: Avoid a PHP warning when a theme adds an editor style with an empty filename.
Fixes #45739.
No action taken yet
git: 756e06c
svn: r45618
315 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-11 06:00:39 +0000
Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.
Props tmatsuur, mukesh27.
Fixes #45935.
No action taken yet
git: eba439f
svn: r45617
316 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-09 21:10:11 +0000
Coding Standards: Remove extra whitespace in list tables' `column_cb()` methods.
See #47632.
No action taken yet
git: 6bee576
svn: r45616
317 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-09 21:04:41 +0000
Coding Standards: Remove extra whitespace in `wp-admin/includes/image-edit.php`.
See #47632.
No action taken yet
git: 9ed8e41
svn: r45615
318 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-09 20:56:37 +0000
I18N: Move code out of translatable string in a `_deprecated_argument()` message in `wp_stream_image()`, `wp_save_image_file()`, and `image_edit_apply_changes()`.
Props ramiy.
Fixes #47406.
No action taken yet
git: 89919f6
svn: r45614
319 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-09 20:44:03 +0000
Menus: Remove extra whitespace from URLs in `Walker_Nav_Menu_Edit::start_el()`.
Props alexeyskr, SergeyBiryukov.
Fixes #47666.
No action taken yet
git: 40d9fdf
svn: r45613
320 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-09 15:57:53 +0000
Filesystem API: Check correct variable in `WP_Filesystem_Direct::dirlist()` after [45611].
Props zinigor.
Fixes #47668. See #47632.
No action taken yet
git: acf6cab
svn: r45612
321 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-09 06:28:09 +0000
Coding Standards: Fix instances of `WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase`.
See #46732.
No action taken yet
git: d36eda3
svn: r45611
322 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-09 05:44:42 +0000
Coding Standards: Fix instances of `WordPress.PHP.NoSilencedErrors.Discouraged`.
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.
No action taken yet
git: e56d5d0
svn: r45610
323 of 2469
Author
Andrew Ozz <[email protected]> 2019-07-09 01:09:53 +0000
TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018.
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911.
No action taken yet
git: 9a54b94
svn: r45609
324 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-09 01:08:47 +0000
Coding Standards: Add missing translator comments to the default themes.
All default themes now have translator comments for all strings with placeholders!

See #46732.
No action taken yet
git: dd8fa6d
svn: r45608
325 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-08 03:14:37 +0000
Theme Editor: Hide the recommendation to create a child theme when editing a child theme.
Props mukesh27, davidbaumwald.
Fixes #44889.
No action taken yet
git: c6c7849
svn: r45607
326 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-08 00:55:20 +0000
Coding Standards: Fix the remaining issues in `/tests`.
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.

Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉

See #47632.
No action taken yet
git: 431bc58
svn: r45606
327 of 2469
Author
laurelfulford <[email protected]> 2019-07-07 20:48:03 +0000
Twenty Thirteen: Add styles for the new Group block.
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments. 

Props @kjellr.
Fixes #46778.
No action taken yet
git: b55695b
svn: r45605
328 of 2469
Author
laurelfulford <[email protected]> 2019-07-07 20:10:55 +0000
Twenty Nineteen: Add styles for the new Group block.
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments. 

Props @kjellr, @dianeco.
Fixes #46750.
No action taken yet
git: 272e5bb
svn: r45604
329 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-05 08:03:40 +0000
Coding Standards: Add missing translator comments.
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.
No action taken yet
git: 18ec05e
svn: r45603
330 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-05 05:42:57 +0000
Coding Standards: Fix all `WordPress.DB.PreparedSQLPlaceholders` issues.
See #47632.
No action taken yet
git: 6acb0c6
svn: r45602
331 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-05 05:20:52 +0000
Coding Standards: Fix all `WordPress.WhiteSpace.PrecisionAlignment` issues.
See #47632.
No action taken yet
git: 027c9da
svn: r45601
332 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-05 03:13:31 +0000
Coding Standards: Fix all `WordPress.CodeAnalysis.AssignmentInCondition` issues.
`WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition` can be ignored, as this is allowed in Core.

See #47632.
No action taken yet
git: e6b7205
svn: r45600
333 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-05 02:49:53 +0000
Coding Standards: Upgrade WPCS to 2.1.1.
Noteable changes:
- WPCS now throws warnings when non-strict comparisons are used. There are quite a few of them in Core. 🙃
- WPCS now detects and warns for assignments in loop conditions.

See #47632.
No action taken yet
git: 6b61c34
svn: r45599
334 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-05 01:44:41 +0000
Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
See #47632.
No action taken yet
git: 93be654
svn: r45598
335 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 10:57:03 +0000
Text Changes: Use consistent question wording in database connection error messages.
Props Presskopp.
See #44878.
No action taken yet
git: e083a92
svn: r45597
336 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 09:55:13 +0000
Text Changes: Use consistent question wording for plugin and theme deletion confirmations.
Props johnjamesjacoby, Presskopp.
Fixes #44878.
No action taken yet
git: fdc5010
svn: r45596
337 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 09:22:17 +0000
Twenty Nineteen: Fix markup errors in `twentynineteen_add_ellipses_to_nav()`:
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.

Props afercia, chetan200891, ianbelanger.
Fixes #47067.
No action taken yet
git: 2aeab42
svn: r45595
338 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 09:14:08 +0000
Twenty Nineteen: Adjust markup in `twentynineteen_add_ellipses_to_nav()` for better readability.
See #47067.
No action taken yet
git: 5fea17b
svn: r45594
339 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 00:37:48 +0000
Twenty Nineteen: Update `package.json` with the latest package versions to pass `npm audit`.
Props netweb.
Fixes #47631.
No action taken yet
git: f56c63a
svn: r45593
340 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 00:32:40 +0000
Script Loader: Remove unnecessary `jquery` dependency for `wp-sanitize.js`.
The file is written in plain JavaScript.

Props sstoqnov.
Fixes #47324.
No action taken yet
git: 68a41a5
svn: r45592
341 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-04 00:26:21 +0000
Bundled Themes: Remove extra semicolons from CSS files.
Props shashank3105, ianbelanger.
Fixes #47178.
No action taken yet
git: b2ad702
svn: r45591
342 of 2469
Author
Sergey Biryukov <[email protected]> 2019-07-03 01:13:21 +0000
Query: Make sure `$climits` variable in `WP_Query::get_posts()` is always defined to avoid a PHP notice.
Props juiiee8487, agengineering.
Fixes #47638.
No action taken yet
git: 4503f93
svn: r45590
343 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-02 23:41:16 +0000
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-includes`.
See #47632.
No action taken yet
git: a00c694
svn: r45589
344 of 2469
Author
Gary Pendergast <[email protected]ordpress.org> 2019-07-02 11:21:53 +0000
Formatting: Revert the changes to `wpautop()` in [45585,45587].
See #27350.
No action taken yet
git: fe28df6
svn: r45588
345 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-02 04:43:01 +0000
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `tests`.
See #47632.
No action taken yet
git: 969c17d
svn: r45587
346 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-02 03:28:03 +0000
Formatting: Improve performance of `wpautop()` on large paragraphs.
Following [45585], older versions of PHP could segfault when attempting to autop paragraphs with 10,000+ characters.

Rather than having to negative lookahead for every character in the paragraph (which could run into recursion limits), we can quickly jump ahead to the next tag and start checking from there.

See #27350.
No action taken yet
git: 008630e
svn: r45586
347 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-02 01:44:06 +0000
Docs: Update some function docs and signatures.
- Update the `_wp_specialchars()` docs to match the function signature.
- Update the `human_time_diff()` function signature to match the docs.

Props subrataemfluence.
Fixes #46845.
No action taken yet
git: 8298f9d
svn: r45585
348 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-02 01:30:15 +0000
Clean up stray `<p>` tags added by `wpautop()` inside block level tags.
`autop()` can sometimes get confused and not clean up stray `<p>` or `</p>` tags inside block level elements, which produces sub-optimal HTML. While browsers can generally handle it, there's no need to make things harder for them if we don't have to.

Props pento, ayubi, pbearne, jond, azaozz, 1994rstefan, dionysous, MikeHansenMe, jorbin, miqrogroove, niallkennedy.
Fixes #27350.
No action taken yet
git: b97899a
svn: r45584
349 of 2469
Author
Adam Silverstein <[email protected]> 2019-07-01 20:47:21 +0000
Taxonomy: add a new 'terms_pre_query' filter to short circuit WP_Term_Query 'get_terms' queries.
Add a new `terms_pre_query` filter which returns null by default. Return a non-null value to bypass WordPress's default `get_terms` queries.

Props jarocks, boonebgorges, spacedmonkey.
Fixes #41246.
No action taken yet
git: 9a15497
svn: r45583
350 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 12:50:14 +0000
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-admin`.
See #47632.
No action taken yet
git: 5fe7618
svn: r45582
351 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 08:26:25 +0000
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the base directory.
See #47632.
No action taken yet
git: 99e5c1e
svn: r45581
352 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 08:22:31 +0000
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in the default themes.
See #47632
No action taken yet
git: ef5a9df
svn: r45580
353 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 08:00:12 +0000
Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
See #47632
No action taken yet
git: d2c4198
svn: r45579
354 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 03:46:30 +0000
Multisite: Use `size_format()` in `display_space_usage()`.
Deleted code is the best code.

Fixes #28239.
No action taken yet
git: 78e096f
svn: r45578
355 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 03:28:21 +0000
Formatting: Trim leading whitespace in `esc_url()`.
Props toszcze.
Fixes #36369.
No action taken yet
git: 77f9bf0
svn: r45577
356 of 2469
Author
Gary Pendergast <[email protected]> 2019-07-01 03:18:28 +0000
Formatting: Don't add `<p>` tags inside `<svg>` tags.
Inline `<svg>`s should generally work, as browsers should just ignore `<p>` or `<br/>` tags that shouldn't be inside the `<svg>`. To keep things neat, however, it's better not add them in the first place.

Props jared_smith, nacin, pento.
Fixes #9437.
No action taken yet
git: b87bdbe
svn: r45576
357 of 2469
Author
Sergey Biryukov <[email protected]> 2019-06-29 00:50:55 +0000
Twenty Seventeen: Correct the CSS selectors intended to fix hover colors for MediaElement controls.
This is a follow-up to the previous fix in [45146], which didn't work as expected.

Props ryokuhi.
Fixes #47543. See #40843.
No action taken yet
git: ed1233d
svn: r45575
358 of 2469
Author
Riad Benguella <[email protected]> 2019-06-28 11:33:13 +0000
Build/Test Tools: Fix the hello e2e test assertion.
The previous assertion was always valid because we assumed it returned a single object,
while in reality it was returning an array.

Props hideokamoto.
Fixes #47622.
No action taken yet
git: 77764a5
svn: r45574
359 of 2469
Author
Gary Pendergast <[email protected]> 2019-06-28 07:15:31 +0000
Formatting: Add correct `<p>` tags near `<hr>` tags.
It can be tricky to know when `wpautop()` should add `<p>` tags, but one thing we can be certain about is that they really shouldn't be anywhere near `<hr>` tags.

Now they aren't.

Props solarissmoke, MattyRob, pento.
Fixes #14674.
No action taken yet
git: b9cd66f
svn: r45573
360 of 2469
Author
Gary Pendergast <[email protected]> 2019-06-28 06:43:27 +0000
Formatting: Add support for seconds to `human_time_diff()`.
The web has gotten so much faster since `human_time_diff()` was created, we need to be able to measure time differences with much finer granularity. Now, we can.

Props johnjamesjacoby, pento.
Fixes #35655.
No action taken yet
git: 66d9c7e
svn: r45572
361 of 2469
Author
Andrea Fercia <[email protected]> 2019-06-27 12:32:28 +0000
Accessibility: Make the Media modal an ARIA modal dialog.
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.

This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.

This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.

Additionally:
- moves the modal H1 heading to the beginning of the modal content 
- changes the modal left menu position to make visual and DOM order match 
- improves the `wp.media.view.FocusManager` documentation

Fixes #47145.
No action taken yet
git: f8228d3
svn: r45571
362 of 2469
Author
Riad Benguella <[email protected]> 2019-06-27 12:05:44 +0000
Build/Test Tools: Make the local env scripts executable.
See #45165.
No action taken yet
git: 42a8715
svn: r45570
363 of 2469
Author
Riad Benguella <[email protected]> 2019-06-27 11:26:58 +0000
Build/Test Tools: Add the e2e tests setup.
- Adds a local environment based on docker
 - Adds the e2e tests setup
 - Adds a "Hello World" e2e test to serve as a template

Props gziolo, herregroen, mcsf.
Fixes #45165.
No action taken yet
git: 3202f9f
svn: r45569
364 of 2469
Author
Gary Pendergast <[email protected]> 2019-06-27 02:04:17 +0000
Formatting: Don't convert smilies in ignored tags that have attributes.
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.

Props pento, jikamens.
Fixes #47489.
No action taken yet
git: 4512e94
svn: r45568
365 of 2469
Author
Sergey Biryukov <[email protected]> 2019-06-27 00:47:41 +0000
Users: Pass `$length`, `$special_chars`, and `$extra_special_chars` parameters to the `random_password` filter in `wp_generate_password()`.
Props roytanck.
Fixes #47092.
No action taken yet
git: 115c496
svn: r45567
366 of 2469
Author
Sergey Biryukov <[email protected]> 2019-06-26 18:18:21 +0000
Docs: Correct `@since` for `admin/edit-comments.js`, introduced in [3736].
See #47581.
No action taken yet
git: 5118e5e
svn: r45566
367 of 2469
Author
Sergey Biryukov <[email protected]> 2019-06-26 18:06:32 +0000
REST API: Call `WP_REST_Server::get_compact_response_links()` and `::get_raw_data()` static methods the right way.
Props andizer, TimothyBlynJacobs.
Fixes #47578.
No action taken yet
git: fc10b6b
svn: r45565
368 of 2469
Author
John Blackbourn <[email protected]> 2019-06-25 17:06:57 +0000
Docs: Correct and improve the docs for a few nonce-related functions.
See #47110
No action taken yet
git: ec44c57
svn: r45564
369 of 2469
Author
Andrew Ozz <[email protected]> 2019-06-25 15:02:34 +0000
Editor: Fix undefined `$locked` var in edit-form-blocks.php when the `show_post_locked_dialog` filter is used to disable displaying of the dialog.
Props aprea.
Fixes #47604.
No action taken yet
git: 725c77a
svn: r45563
370 of 2469
Author
Andrea Fercia <[email protected]> 2019-06-25 14:10:29 +0000
Plugins: Fix the plugin details modal layout after [45520].
Props mukesh27, marybaum, audrasjb.
Fixes #47561.
No action taken yet
git: 6ee8a99
svn: r45562
371 of 2469
Author
Peter Wilson <[email protected]> 2019-06-22 13:42:58 +0000
Cron: Fix condition reversed in [45559].
In [45559] a test for not-falsey was reversed to a falsey check.

Props obenland.
Fixes #47589.
No action taken yet
git: 3099359
svn: r45561
372 of 2469
Author
Anton Timmermans <[email protected]> 2019-06-22 13:01:22 +0000
Docs: Improve JSDoc for `media/views/attachment/details.js`.
Props maartenleenders, boblinthorst, dfangstrom.
Fixes #47588.
No action taken yet
git: 183b4b6
svn: r45560
373 of 2469
Author
Peter Wilson <[email protected]> 2019-06-22 11:12:58 +0000
Cron API: Prevent caching of WP Cron requests.
Add `Cache-Control` and `Expires` HTTP headers to prevent caching of requests to WP Cron on systems supporting fastcgi_finish_request(). 

The fastcgi_finish_request() call prevents the setting of further HTTP headers by caching plugins subsequently loaded.

Props kingkero.
Fixes 47396.
No action taken yet
git: e37aff4
svn: r45559
374 of 2469
Author
Peter Wilson <[email protected]> 2019-06-22 11:11:26 +0000
Code is Poetry: CS Fixes required in wp-cron.php.
See #47396, #41057.
No action taken yet
git: a912ef9
svn: r45558
375 of 2469
Author
Anton Timmermans <[email protected]> 2019-06-20 14:44:30 +0000
Docs: Improve JSDoc for `admin/edit-comments.js`.
Props manuelaugustin, diedeexterkate, thulshof, Xyfi, ireneyoast.
Fixes #47581.
No action taken yet
git: 0dc3295
svn: r45557
376 of 2469
Author
Adam Silverstein <[email protected]> 2019-06-20 14:14:59 +0000
Themes: improve search by trimming search string.
Fix an issue where searching installed themes for an empty string resulted in matching all themes.

Props afercia, desrosj, hesyifei, evalarumbe.
Fixes #39041.
No action taken yet
git: e9fc71b
svn: