WordPress commits: wp-trunk branch

git: 3cd121d
svn: r46561
1 of 2871
Author
John Blackbourn <[email protected]> 2019-10-17 18:36:27 +0000
Administration: Revert changes to the admin menu styles for long line lengths.
This reverts [46555], [46453], and [46332].

See #42201
No action taken yet
git: 3e6c0fb
svn: r46560
2 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-16 21:01:22 +0000
Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing.
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.
No action taken yet
git: aa37e6e
svn: r46559
3 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-16 17:47:28 +0000
Script Loader: Partially revert [46550] as it brought in unrelated CSS changes.
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.
No action taken yet
git: 31ae9e0
svn: r46558
4 of 2871
Author
Sergey Biryukov <sergeybi[email protected]> 2019-10-15 21:12:48 +0000
Post WordPress 5.3 RC1 version bump
No action taken yet
git: 52151d5
svn: r46557
5 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-15 20:48:59 +0000
WordPress 5.3 RC1
No action taken yet
git: c0cb230
svn: r46556
6 of 2871
Author
John Blackbourn <[email protected]> 2019-10-15 20:40:05 +0000
Help/About: Let's tell the world about 5.3.
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald

Thanks to everyone who provided feedback for this page for 5.3.

See #47708
No action taken yet
git: 9d2aa0f
svn: r46555
7 of 2871
Author
John Blackbourn <[email protected]> 2019-10-15 19:37:03 +0000
Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed.
Props afercia, amolv, sabernhardt

Fixes #42201, #48294
No action taken yet
git: 943fa44
svn: r46554
8 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-15 19:34:31 +0000
Shortcodes: Revert [46369] for now to allow more time to investigate and prepare for backward compatibility changes.
Also reverts follow-up changes in [46370] and [46465].

See #47863.
No action taken yet
git: d5f11a9
svn: r46553
9 of 2871
Author
Andrew Ozz <[email protected]> 2019-10-15 19:10:53 +0000
Media: Similarly to `wp_get_original_image_path()` add `wp_get_original_image_url()` to always retrieve the URL to the original uploaded image.
Props kraftbj.
Fixes #48302.
No action taken yet
git: 7fdb0e7
svn: r46552
10 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-15 18:51:42 +0000
Build/Test Tools: Move PHP 7.4 to the top of the list for consistency.
See #48232.
No action taken yet
git: 2b3fc32
svn: r46551
11 of 2871
Author
desrosj <[email protected]> 2019-10-15 18:45:02 +0000
Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see https://github.com/WordPress/twentytwenty/compare/7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.
No action taken yet
git: 943320f
svn: r46550
12 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-15 17:21:50 +0000
Accessibility: Script Loader: Remove jQuery as dependency of `admin-bar` after [46440].
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.
No action taken yet
git: 6e133af
svn: r46549
13 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-15 16:45:08 +0000
Accessibility: Media: Improve the Media Modal spinner position after [46418].
Fixes #47138.
No action taken yet
git: 3fb04ab
svn: r46548
14 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-15 16:41:51 +0000
Customize: Ensure that `WP_Customize_Manager::import_theme_starter_content()` properly handles starter content with (nested) arrays as values.
Previously, searching for symbol references to replace with post or attachment IDs in array values resulted in a PHP warning.

Props timph, JarretC, SergeyBiryukov.
Fixes #45484.
No action taken yet
git: 8a8d016
svn: r46547
15 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-15 16:36:42 +0000
Build/Test: Remove PHP 7.4 from allowed failures
PHP7.4 is supported in WordPress 5.3. :elephant: :tada:

Fixes: #48232.
No action taken yet
git: 849e070
svn: r46546
16 of 2871
Author
Jorge Costa <[email protected]> 2019-10-15 16:15:50 +0000
Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.8 release.
Updated packages:
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]

Props gziolo, youknowriad.
Fixes: #48310
No action taken yet
git: 3b2c656
svn: r46544
17 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-15 15:45:39 +0000
REST API: Allow for multiple Vary: Origin headers in GET responses.
Simple fix, we pass `false` as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.
No action taken yet
git: 78d3ff3
svn: r46543
18 of 2871
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2019-10-15 15:35:03 +0000
Block Editor: Remove experimental Social Links blocks
We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release.

Props youknowriad.

Fixes #48263.
No action taken yet
git: b4d3499
svn: r46542
19 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-15 14:40:31 +0000
Build/Test tools use Trunk revision 2170172 of importer
Update Travis configuration to temporarily use trunk for the importer in order for PHP 7.4 tests to pass. When the new version is released, this will be updated to point to that tag.

See: #48231
No action taken yet
git: 5df589d
svn: r46507
20 of 2871
Author
Andrew Ozz <[email protected]> 2019-10-14 20:03:01 +0000
Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging.
Fixes #40439.
No action taken yet
git: 329e042
svn: r46506
21 of 2871
Author
Andrew Ozz <[email protected]> 2019-10-14 19:54:36 +0000
Uploads: Retry to post-process images after HTTP 500 and HTTP 502 errors.
Props mikeschroder, azaozz.
Fixes #47872.
No action taken yet
git: d2da46a
svn: r46489
22 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-14 18:01:53 +0000
Accessibility: Media: Improve the text of the Media Modal actions toggle button displayed in the responsive view.
See #47149.
No action taken yet
git: ab8e929
svn: r46488
23 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-14 17:56:41 +0000
Accessibility: Media: Improve the new Media Modal headings text.
See #47610.
No action taken yet
git: 778bf0c
svn: r46485
24 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 17:13:35 +0000
Administration: Ensure that admin referer nonce is valid.
Fix for a testing regression.

Props desrosj.
Backported in 30c498e
git: 4e2d91d
svn: r46483
25 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 16:23:13 +0000
REST API: Ensure that we don't generate warnings from sending extra headers after headers have been sent.
Fixes issues stemming from [46478].
Backported in 30c498e
git: 2a5c167
svn: r46478
26 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 15:41:05 +0000
REST API: Send a Vary: Origin header on GET requests.
Add this header on all GET requests to prevent cached requests.

Props darthhexx, davidbinda, nickdaugherty, whyisjake.
Backported in 30c498e
git: f53a78f
svn: r46477
27 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 15:38:14 +0000
Administration: Ensure that admin referer nonce is valid.
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.
Backported in 30c498e
git: f06c6bb
svn: r46476
28 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 15:29:25 +0000
Filesystem API: Prevent directory travelersals when creating new folders.
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.
Backported in 30c498e
git: af8afb9
svn: r46475
29 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 15:25:38 +0000
HTTP API: Protect against hex interpretation.
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.
Backported in 30c498e
git: ad6c214
svn: r46474
30 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-14 15:18:49 +0000
Query: Remove the static query property.
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.
Backported in 30c498e
git: 0c75758
svn: r46472
31 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-14 10:50:41 +0000
Formatting: In `wp_validate_redirect()`, normalize the path when validating the location for relative URLs, to account for Windows paths.
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.
No action taken yet
git: a9891c7
svn: r46471
32 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-13 10:00:18 +0000
Docs: Fix typo in a comment in `WP_REST_Settings_Controller::prepare_value()`.
Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.
No action taken yet
git: 8f7174f
svn: r46470
33 of 2871
Author
Peter Wilson <[email protected]> 2019-10-13 02:46:25 +0000
Docs: Correct documentation typo in print_emoji_detection_script().
Props itowhid06.
Fixes #48298. See #47110.
No action taken yet
git: 438de1f
svn: r46469
34 of 2871
Author
Peter Wilson <[email protected]> 2019-10-13 02:40:05 +0000
Docs: Correct comment typo in WP_REST_Terms_Controller::update_item().
Props manikmist09.
Fixes #48295. See #47110.
No action taken yet
git: cda19de
svn: r46468
35 of 2871
Author
John Blackbourn <[email protected]> 2019-10-12 18:03:22 +0000
Docs: Fix and improve inline documentation for the HTTP API.
See #47110
No action taken yet
git: a8259b8
svn: r46467
36 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-12 03:08:56 +0000
Users: Make sure `wp_logout()` clears current user, so that a subsequent call to `is_user_logged_in()` works as expected.
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.
No action taken yet
git: 5729349
svn: r46466
37 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-12 03:00:32 +0000
Tests: Rename tests methods in `tests/pluggable.php` per the handbook's naming convention.
See #47632.
No action taken yet
git: 5e6d8f5
svn: r46465
38 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-12 02:48:26 +0000
Docs: Adjust `@since` note in `shortcode_parse_atts()` for consistency with similar notes.
See #47863.
No action taken yet
git: 7cd21b7
svn: r46464
39 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-12 02:40:43 +0000
I18N: Don't capitalize "Extension" in `update_core()`, for consistency with other strings.
Follow-up to [46455].

See #47699.
No action taken yet
git: e21792c
svn: r46463
40 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-12 02:33:13 +0000
Docs: Add `requires_php` to the list of fields returned by `plugins_api()`.
Props ediamin.
Fixes #48291.
No action taken yet
git: 9a6bce9
svn: r46462
41 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-11 23:52:11 +0000
Formatting: Make sure `wp_sanitize_redirect()` encodes spaces in URLs instead of stripping them out.
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.
No action taken yet
git: dcb037f
svn: r46461
42 of 2871
Author
Anthony Burchell <[email protected]> 2019-10-11 20:41:51 +0000
Media: Adds Edit Image controller to Media Library `select` frame.
This adds the necessary state for `EditImage` views in the `select` frame and listeners for setting that view.

Props fblaser, w3rkjana, afercia, antpb.
See #48028.
No action taken yet
git: 42493b7
svn: r46460
43 of 2871
Author
Anthony Burchell <[email protected]> 2019-10-11 19:20:43 +0000
Administration: Prevents horizontal scroll jumping around while admin menu is open.
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.
No action taken yet
git: 68729ad
svn: r46459
44 of 2871
Author
Mike Schroder <[email protected]> 2019-10-11 07:52:12 +0000
Media: Update fallback previews to support `_wp_make_subsizes()`
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.
No action taken yet
git: 4669376
svn: r46458
45 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-10 22:50:05 +0000
Cron: Prevent sending headers when using ALTERNATE_WP_CRON
ALTERNATE_WP_CRON echos things which causes a "Headers already sent" warning. This adds a check to ensure headers haven't already been sent.

Previously: [45560]

See: #45560. Fixes #48283.
Props dlh.
No action taken yet
git: 7a682e6
svn: r46457
46 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-10 19:05:57 +0000
Themes: Convert core-provided starter content to block content.
Props Clorith.
Fixes #48130.
No action taken yet
git: 70b408c
svn: r46456
47 of 2871
Author
K. Adam White <[email protected]> 2019-10-10 17:16:44 +0000
REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included.
Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.
No action taken yet
git: 1bcd41b
svn: r46455
48 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-09 22:20:37 +0000
Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.
No action taken yet
git: 22d50c4
svn: r46454
49 of 2871
Author
K. Adam White <[email protected]> 2019-10-09 17:34:20 +0000
REST API: Do not addslash when receiving meta arrays of non-string values.
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.

Props TimothyBlynJacobs, augustuswm.
Fixes #48264.
No action taken yet
git: c608c85
svn: r46453
50 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-09 04:56:55 +0000
Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201
No action taken yet
git: 176a3f0
svn: r46452
51 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-09 04:33:34 +0000
Docs: Tweak the `@since` note in `Walker::walk()` and `::paged_walk()` for better readability and consistency with other notes.
See #47678.
No action taken yet
git: 8ec0a21
svn: r46451
52 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-09 04:26:22 +0000
Docs: Add a `@since` note about new parameters with the spread operator added to function signatures.
Props jrf.
See #47678.
No action taken yet
git: d4e9608
svn: r46450
53 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-08 22:17:54 +0000
Bundled Themes: Update/audit NPM dependencies for Twenty Nineteen.
Also, ignore the `node_modules` folder for Twenty Nineteen.

Fixes #48262.
No action taken yet
git: 71aa81f
svn: r46449
54 of 2871
Author
Adam Silverstein <[email protected]> 2019-10-08 20:45:15 +0000
Post WordPress 5.3 Beta 3 version bump.
No action taken yet
git: 1e1ef43
svn: r46448
55 of 2871
Author
Adam Silverstein <[email protected]> 2019-10-08 19:57:09 +0000
WordPress 5.3 Beta 3.
No action taken yet
git: e20a613
svn: r46447
56 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-08 19:50:54 +0000
Bundled Themes: Fix JSHint error in [46445]
Props ianbelanger.
See #48110.
No action taken yet
git: 2aad78b
svn: r46446
57 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-08 19:19:30 +0000
Bundled Themes: Change the `eol-style` property to `native` for Twenty Twenty files.
Props aazaozz, desrosj.
See #48110.
No action taken yet
git: f95a75b
svn: r46445
58 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-08 19:05:53 +0000
Bundled Themes: Update Twenty Twenty.
This brings `trunk`'s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46357], see https://github.com/WordPress/twentytwenty/compare/7157870...7246fd6.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyusly, luminuu, itowhid06, cbravobernal, intimez, glauberglauber, ocean90, amolv, briceduclos, aristath, mukesh27, garrett-eclipse, audrasjb, afercia, dianeco, utsav72640, mahesh901122, tobifjellner.
See #48110.
No action taken yet
git: af634cc
svn: r46444
59 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 19:05:13 +0000
Themes: Properly align Close/Previous/Next icons in theme preview overlay.
Props chetan200891.
Fixes #48248.
No action taken yet
git: a15cc93
svn: r46443
60 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 18:47:18 +0000
Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
Props chetan200891.
Fixes #48250.
No action taken yet
git: 5f23525
svn: r46442
61 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 17:54:45 +0000
Code Modernisation: Introduce the spread operator in `Walker::walk()` and `::paged_walk()`.
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This re-applies [45624] and reverts [45640], with a dev note upcoming for plugin authors to maintain backward compatibility with old versions of WordPress.

Props jrf.
See #47678.
No action taken yet
git: 0a818ec
svn: r46441
62 of 2871
Author
John James Jacoby <[email protected]> 2019-10-08 17:44:42 +0000
Network Admin: Improve Site States in List Table rows.
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.
No action taken yet
git: 3207d9a
svn: r46440
63 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-08 17:18:07 +0000
Accessibility: Script Loader: Add jQuery as dependency of `admin-bar`.
On the front end, themes that don't use jQuery make the admin bar fallback to the non-jQuery implementation. Some important features miss from the non-jQuery `admin-bar.js` part, for example `hoverintent` and, most importantly, the touch events for the mobile menu don't work at all.

Enqueueing jQuery is the simplest option for now. For the future, a complete rewriting of `admin-bar.js` in plain JavaScript is highly recommended.

See #47069.
No action taken yet
git: 357a18d
svn: r46439
64 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 17:17:07 +0000
Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files.
Props jrf.
Fixes #48254.
No action taken yet
git: fb0d0e2
svn: r46438
65 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-08 17:05:53 +0000
Accessibility: Media: Improve the logic to render the ARIA tabs markup after [46363].
Additionally checks for the "menu" and "router" state attributes to better determine when the ARIA tabs pattern markup is appropriate.

See #47149.
No action taken yet
git: 1f6dbef
svn: r46437
66 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 17:02:23 +0000
I18N: Add context for the `Archives` string introduced in [45651] as a file type heading, to disambiguate from other types of archives.
Props alexclassroom.
Fixes #48259.
No action taken yet
git: 4d44978
svn: r46436
67 of 2871
Author
Adam Silverstein <[email protected]> 2019-10-08 16:04:32 +0000
External Libraries: upgrade `mediaelement` to version 4.2.13.
Upgrade `mediaelement` to the latest version. Includes a variety of bug fixes made since the 4.2.6 release; see https://github.com/mediaelement/mediaelement/releases.

Props danieliser, Hareesh Pillai.
Fixes #46681.
No action taken yet
git: e2cf94f
svn: r46435
68 of 2871
Author
K. Adam White <[email protected]> 2019-10-08 13:41:29 +0000
REST API: Ensure rest_controller instantiates the post type's declared REST controller class.
Ensures that the ::get_rest_controller() method will always return an instanceof the expected controller class, or null.
Removes unused private static property $post_type_controllers.

Props dlh, TimothyBlynJacobs.
Fixes #45677.
No action taken yet
git: 040304d
svn: r46434
69 of 2871
Author
K. Adam White <[email protected]> 2019-10-08 04:43:10 +0000
REST API: Permit embedding of the 'self' link relation in the /search endpoint.
Removes a special-case prohibition against embedding 'self' which prevented ?_embed from being used with the /wp/v2/search endpoint.

Props TimothyBlynJacobs, chrisvanpatten, kadamwhite.
Fixes #47684.
No action taken yet
git: e17e5aa
svn: r46433
70 of 2871
Author
K. Adam White <[email protected]> 2019-10-08 04:00:25 +0000
REST API: Ensure users with "moderate_comments" capability may edit comments.
Props meloniq.
Fixes #47024.
No action taken yet
git: 4e716db
svn: r46432
71 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 03:18:02 +0000
Coding Standards: Correct the number of accepted arguments in `add_action()` calls in `wp-includes/default-filters.php` for functions that don't accept any arguments.
Props itowhid06, johnbillion, jrf.
Fixes #48123.
No action taken yet
git: 392cf3e
svn: r46431
72 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 02:55:20 +0000
CSS Coding Standards: Use unitless values for `line-height` in `wp-includes/css/media-views.css`.
Follow-up to [45478].

Props ianbelanger, afercia.
Fixes #46529. See #44643.
No action taken yet
git: 9ec0161
svn: r46430
73 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 02:00:24 +0000
Twenty Fourteen: Replace overly broad float-clearing selectors with more specific ones, to avoid unintentionally targeting elements generated by plugins.
Props ianbelanger, iandunn, karmatosed.
Fixes #35779.
No action taken yet
git: 683309f
svn: r46429
74 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-08 01:52:26 +0000
Twenty Fourteen: Ensure the content after the Read More tag is visible and has the appropriate padding.
Props ianbelanger, sabernhardt, slobodanmanic, Quantumstate, Gwendydd, andraganescu, francina.
Fixes #28967.
No action taken yet
git: f257bdf
svn: r46428
75 of 2871
Author
John Blackbourn <[email protected]> 2019-10-07 22:17:22 +0000
Pings/Trackbacks: Remove a failing test that won't pass as long as `WP_IMPORTING` gets set during tests.
The `_publish_post_hook()` function checks for `WP_IMPORTING` before setting meta fields fir enclosures and pings, which means this test is doomed to fail.

The test can be re-implemented if the `WP_IMPORTING` constant gets moved to a function similar to how `wp_installing()` works for the `WP_INSTALLING` constant.

See #48014
No action taken yet
git: 385983f
svn: r46427
76 of 2871
Author
John Blackbourn <[email protected]> 2019-10-07 21:35:54 +0000
Pings/Trackbacks: Fix processing of posts with pending enclosures.
Introduced in [46175].

Fixes #36824
No action taken yet
git: 16b45f0
svn: r46426
77 of 2871
Author
John Blackbourn <[email protected]> 2019-10-07 20:27:20 +0000
Pings/Trackbacks: Avoid adding multiple `_pingme` and `_encloseme` meta entries to a post when it gets updated prior to pings being done.
Props rebasaurus, whyisjake

Fixes #48014
No action taken yet
git: 5e943fa
svn: r46425
78 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-07 19:55:58 +0000
Accessibility: Improve and modernize user interface controls: Revert the new links focus style.
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].

See #34904, #47153.
No action taken yet
git: 86b0faf
svn: r46424
79 of 2871
Author
John Blackbourn <[email protected]> 2019-10-07 19:06:41 +0000
Docs: Miscellaneous inline docs corrections and improvements.
See #47110
No action taken yet
git: ae8bef6
svn: r46423
80 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-07 18:45:45 +0000
Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class.
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes

See #34904.
No action taken yet
git: 4848b1e
svn: r46422
81 of 2871
Author
Andrew Ozz <[email protected]> 2019-10-07 17:04:49 +0000
REST API: Add support for continuing the post-processing of images after upload. Flow:
1. `POST /wp/v2/media`.
2. If the upload failed (HTTP 500 error), look for a response header with `X-WP-Upload-Attachment-ID` header that contains the newly created attachment ID.
3. `POST /wp/v2/media/{id}/post-process` with `{ "action": "create-image-subsizes" }`. This request may still fail, but it will save its progress.
4. On continued failure, `DELETE /wp/v2/media/{id}` to give up on the upload and instruct the user to resize their image before uploading.

Props TimothyBlynJacobs.
Fixes #47987.
No action taken yet
git: 022119d
svn: r46421
82 of 2871
Author
Andrew Ozz <[email protected]> 2019-10-07 15:28:29 +0000
Upload: Set custom header with the attachment ID for all uploads from `media_handle_upload()`. Let the REST API endpoint set it separately.
Props timothyblynjacobs.
Fixes #48200.
No action taken yet
git: fd7240c
svn: r46420
83 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-07 15:16:44 +0000
Coding Standards: Fix WPCS issues in `wp-includes/ms-deprecated.php`.
Props itowhid06.
Fixes #48237.
No action taken yet
git: c2ffe16
svn: r46419
84 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-07 13:18:19 +0000
Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments.
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent

Props garrett-eclipse, afercia.
See #47477.
No action taken yet
git: 42ef147
svn: r46418
85 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-07 12:41:50 +0000
Accessibility: Media: Improve the search media field labelling.
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.
No action taken yet
git: 5c91f0d
svn: r46417
86 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-07 11:52:32 +0000
Accessibility: Login and Registration: Improve the invalid username and invalid email messages.
- explicitly informs users they can use their email to log in as an alternative to their username and vice-versa
- shows the `Lost your password?` link only when an wrong password has been entered
- uses a more appropriate copy by changing "invalid" to "unknown"
- removes the all caps `ERROR`

Props subrataemfluence, zalak151291, ryokuhi, SergeyBiryukov, audrasjb, joedolson, marybaum, ramiy, markjaquith, chanthaboune, afercia.
Fixes #43037.
No action taken yet
git: 2215a9b
svn: r46416
87 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-06 17:12:23 +0000
External Libraries: Fix PHP 7.4 compatibility issue in the Requests library.
Moves https://github.com/rmccue/Requests/pull/370 into WordPress.

Previous [46258].

See #47746.
No action taken yet
git: a59b9dd
svn: r46415
88 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-06 15:26:42 +0000
Coding Standards: Fix WPCS issues in `WP_Widget_Links` and `WP_Widget_Pages`.
Props itowhid06.
Fixes #48228.
No action taken yet
git: 3a06234
svn: r46414
89 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-06 15:12:42 +0000
Tests: Use a consistent group for nav menu tests.
Fixes #48230.
No action taken yet
git: f6267a0
svn: r46413
90 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-06 15:04:18 +0000
Menus: In `Walker_Nav_Menu`, `Walker_Category`, and `Walker_Page`, properly output link attributes having a legitimate "empty" value, for example an HTML data attribute with a value of zero (0).
Props nevma, AkSDvP, greenshady, SergeyBiryukov.
Fixes #47720.
No action taken yet
git: ed1a535
svn: r46412
91 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-06 06:54:13 +0000
Privacy: Ensure that sending email, and remove data follow the same user experience.
Both personal data request processes should follow the same convention.

Fixes: #43974.
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.
No action taken yet
git: de0efbb
svn: r46411
92 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-06 06:40:36 +0000
Administration: Add a max-width to the Privacy Policy Page dropdown.
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.
No action taken yet
git: e2b7892
svn: r46410
93 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-06 02:21:42 +0000
Docs: Format comments in `wp-admin/includes/plugin.php` as per the documentation standards.
Props dkarfa.
Fixes #48191.
No action taken yet
git: 2c5032e
svn: r46409
94 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-05 21:59:32 +0000
Build/Test: Update Grunt Uglify options
Follow up to [46408]

Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.

See #48203.
No action taken yet
git: 3f9927d
svn: r46408
95 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-05 19:47:04 +0000
Build/Test: Bump devDependencies for WordPress 5.3
This upgrades a number of devDependencies.  Some of these include changes to how the tasks are configured.

Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options

Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json

As with most changes to uglify, this changes every minified JS file.

Fixes #48203.
No action taken yet
git: f635745
svn: r46405
96 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 15:40:31 +0000
Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
Props garrett-eclipse, dkarfa.
Fixes #48188.
No action taken yet
git: e963c18
svn: r46404
97 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-05 14:19:20 +0000
Build/Test tools: Update grunt-contrib-imagemin and run it
Smaller images are good, so is not having npm vulnerabilities.

See #48203.
Fixes #48206.
Props whyisjake, netweb.
No action taken yet
git: 269c8ba
svn: r46403
98 of 2871
Author
Aaron Jorbin <[email protected]> 2019-10-05 13:47:52 +0000
Build/Test Tools: Fork and Update `grunt-replace`
The version of grunt replace that is bundled in core is using an outdated version of lodash that is bringing 2 low, 3 high, and 1 critical issue. This package is currently abandoned. There is a community forked version, but that is also harboring some similar security issues.

This switches to a fork by @whyisjake and causes no change to the build.

See #48203.
Fixes #48217.
Props whyisjake, netweb for testing.
No action taken yet
git: 04293be
svn: r46402
99 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 02:38:14 +0000
Site Health: Improve the wording for `UTF8MB4` test description.
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044.
No action taken yet
git: 21de64f
svn: r46401
100 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 02:31:14 +0000
Customize: Remove duplicate `attr_title` assignment in `api.Menus.MenuItemControl.renderContent()`.
See #47838.
No action taken yet
git: e99e145
svn: r46400
101 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 02:15:13 +0000
Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`.
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.

Props codex-m.
Fixes #46581.
No action taken yet
git: ef942c6
svn: r46399
102 of 2871
Author
SergeyBiryukov <[email protected]> 2019-10-05 02:08:01 +0000
Docs: Correct formatting of the `@return` value description in `_wp_handle_upload()`.
See #47110.
No action taken yet
git: 840a033
svn: r46398
103 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 01:30:00 +0000
Docs: Add missing documentation for the first parameter of the `big_image_size_threshold` filter.
Props dkarfa, desrosj, earnjam.
Fixes #48214.
No action taken yet
git: c3c0007
svn: r46397
104 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:59:50 +0000
Emoji: Revert [46393] pending test failure investigation.
See #46537.
No action taken yet
git: 0200a42
svn: r46396
105 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:55:48 +0000
Comments: Remove a one-time variable in `wp_rel_nofollow()` and `wp_rel_ugc()`.
See #48022.
No action taken yet
git: 56b6b1e
svn: r46395
106 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:53:39 +0000
Themes: In `get_theme_mod()`, only run the `sprintf()` replacement on the default value if there's a string format pattern found in the value.
This prevents standalone percent symbols from being stripped out, e.g. in a default value like `100%`.

Props aristath, kuus, moonomo, westonruter, davetgreen, daviedR, katielgc, noisysocks, SergeyBiryukov.
Fixes #34290.
No action taken yet
git: 1be6c41
svn: r46394
107 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-05 00:39:04 +0000
Docs: Improve documentation for `get_theme_mod()` and `set_theme_mod()`.
See #47110.
No action taken yet
git: c411aad
svn: r46393
108 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-04 23:28:22 +0000
Emoji: Stop emoji replacement from happening inside CodeMirror instances, and clean up some logic in the `MutationObserver`.
Props pento, hirofumi2012, davidbaumwald.
Fixes #46537.
No action taken yet
git: 0e2b212
svn: r46392
109 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-04 23:20:01 +0000
Themes: Bring default values for `get_theme_root()`, `get_theme_root_uri()`, `wp_get_theme()`, and `wp_customize_url()` in line with the documentation.
Reverts [46327].

Fixes #44397.
No action taken yet
git: c2bcdea
svn: r46391
110 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-04 22:18:11 +0000
Docs: Add missing description for `$comment` global.
Props immeet94, mukesh27.
Fixes #46928. See #47110.
No action taken yet
git: 08ff597
svn: r46390
111 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-04 22:08:34 +0000
I18N: Add missing comma in a translator comment.
See #47515.
No action taken yet
git: 84dc68a
svn: r46389
112 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-04 21:58:48 +0000
Customize: Prevent breaking the customizer when site title contains templating syntax.
When the site title is inside an underscore template, syntax defined in `wp.template` like `{{ }}` is treated as special characters and will make Underscore treat it as data to be compiled/rendered.

Props pierlo, donmhico.
Fixes #46863.
No action taken yet
git: 25ba907
svn: r46388
113 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-04 21:19:17 +0000
QUnit: Include script dependencies for wp-a11y script to fix a TypeError.
Also, add missing message argument to Customizer notifications to ensure tests are passing.

Fixes #45066.
No action taken yet
git: a468719
svn: r46387
114 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-04 20:19:11 +0000
I18N: Fix translator comment for a themes list table string with numbered placeholders.
Props garrett-eclipse.
Fixes #47515.
No action taken yet
git: 0b3bc89
svn: r46386
115 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-04 20:11:20 +0000
Docs: Convert 'Block Editor' to lowercase.
Props garrett-eclipse.
Fixes #45634.
No action taken yet
git: c7bd227
svn: r46385
116 of 2871
Author
Dominik Schilling <[email protected]> 2019-10-04 19:57:08 +0000
Networks and Sites: Improve newly added strings for i18n.
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.

Props pedromendonca.
Fixes #48210.
No action taken yet
git: f183dd8
svn: r46384
117 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-04 14:31:05 +0000
Networks and Sites: Fix issues processing additional fields displayed for the Sites list table.
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.

Props pbiron.
Fixes #45954.
No action taken yet
git: 17765e9
svn: r46383
118 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-03 23:11:20 +0000
Docs: Clarify default value for the `$link` parameter in `edit_tag_link()`, `edit_term_link()`, and `edit_bookmark_link()`.
Props atachibana.
Fixes #48109.
No action taken yet
git: 5e0904c
svn: r46382
119 of 2871
Author
Andrew Ozz <[email protected]> 2019-10-03 21:00:10 +0000
Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup.
Props timothyblynjacobs, clorith, azaozz.
Fixes #48200.
No action taken yet
git: 7c1662c
svn: r46381
120 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-03 20:38:08 +0000
Docs: Fix code example for removing internal pointers.
Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj.
Fixes #45529.
No action taken yet
git: 271fc0d
svn: r46380
121 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-03 20:02:28 +0000
Menus: Fix typo in the class attribute for the hidden `title` field in `Walker_Nav_Menu_Checklist`.
Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu.

The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item.

Props yanngarcia, davidbaumwald.
See #47838.
No action taken yet
git: 5a2c04c
svn: r46379
122 of 2871
Author
Joe McGill <[email protected]> 2019-10-03 16:05:14 +0000
Media: Ensure `medialement` scripts are loaded in the footer.
This fixes a regression in [41877] which caused `mediaelement` scripts to load in the header.

Props Themezly.
Fixes #44484.
No action taken yet
git: f13714d
svn: r46378
123 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-03 15:44:36 +0000
General: Patch PHMailer for PHP 7.4 compatibility.
This patches the PHPMailer library in Core to be PHP 7.4 compatible by adding a version check before calling `get_magic_quotes_runtime()`.

Props ayeshrajans, jrf.
See #47783.
No action taken yet
git: 80b4dbf
svn: r46377
124 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-10-03 14:47:17 +0000
Docs: Add missing `@deprecated` tags.
Follow up to [46205-46206,46208].

Props jrf.
See #47699.
No action taken yet
git: 0c66e65
svn: r46376
125 of 2871
Author
Joe McGill <[email protected]> 2019-10-03 14:46:46 +0000
Media: Improve documentation for `add_image_size()`
This improves the description of the `$crop` parameter to clarify behavior.

Props nikolastoqnow, ketuchetan, audrasjb, killua99, pierlo.
Fixes #42463.
No action taken yet
git: 37cdffd
svn: r46375
126 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-03 12:09:31 +0000
Accessibility: Media: Add more headings in the Media Modal.
Headings are the predominant mechanism for screen reader users to find information in a page. They also help all users to better identify the main sections of user interfaces.

- adds three new headings within the media modal 
- improves plural form translation for "item selected" by using `wp.i18n`
- horizontally centers the media modal menu in the responsive view

Props kjellr, karmatosed, melchoyce, afercia.
See #47149.
Fixes #47610.
No action taken yet
git: ee03b05
svn: r46374
127 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-02 23:21:17 +0000
Privacy: Remove unused `$wpdb` global in `WP_Privacy_Requests_Table::prepare_items()`.
Props david.binda.
Fixes #48178.
No action taken yet
git: 65c94d5
svn: r46373
128 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-01 22:04:43 +0000
Accessibility: Media: Allow users to set a proper language for Video subtitles.
For a number of years, subtitles track added to videos were always set to "English" regardless of the actual subtitles language.

By making the track `srclang`, `label`, and `kind` attributes editable, content authors are now able to set a language that matches the actual track content.

Props BjornW, audrasjb, birgire, karmatosed, sabernhardt, afercia.
Fixes #47559.
No action taken yet
git: dc0b9dc
svn: r46372
129 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-01 17:59:18 +0000
Login and Registration: Hide the Edge browser "Reveal password" native button.
Props Clorith.
Fixes #42888.
No action taken yet
git: 5ddfa37
svn: r46371
130 of 2871
Author
Andrea Fercia <[email protected]> 2019-10-01 15:54:39 +0000
Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
- allows the login input fields to better scale with text 
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button 
- adjusts the CSS for the interim login

See #47153.
See #42888.
No action taken yet
git: 02cf7f5
svn: r46370
131 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-01 04:12:15 +0000
Shortcodes: Improve handling from `shortcode_parse_attts()`.
Added missing @ticket for #47863 on `data_shortcode_parse_atts()`

Also cleans up some linter fixes that were missed.

Props garrett-eclipse, whyisjake.
ixes #47863.
No action taken yet
git: 1f5525d
svn: r46369
132 of 2871
Author
Jake Spurlock <[email protected]> 2019-10-01 03:41:58 +0000
Shortcodes: Improve handling from `shortcode_parse_attts()`.
Ensure consistency between `shortcode_parse_attts()` when being used directly.

Props mauteri, birgire, SergeyBiryukov, kadamwhite, whyisjake.
Fixes #47863.
No action taken yet
git: 4b93e1e
svn: r46368
133 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-01 01:18:03 +0000
Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock.
Props david.binda.
Fixes #48179.
No action taken yet
git: 38ea9f4
svn: r46367
134 of 2871
Author
Sergey Biryukov <[email protected]> 2019-10-01 00:45:20 +0000
Docs: Remove obsolete comment in `wpmu_signup_blog_notification()` and `wpmu_signup_user_notification()`.
Props david.binda.
Fixes #48185.
No action taken yet
git: 796f012
svn: r46366
135 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 21:08:00 +0000
Post WordPress 5.3 Beta 2 version bump.
No action taken yet
git: 6de28b0
svn: r46365
136 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 20:50:17 +0000
WordPress 5.3 Beta 2.
No action taken yet
git: 08b757e
svn: r46364
137 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 20:05:51 +0000
Block Editor: Update WordPress packages to include the latest bug fixes.
Updated packages:

@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected] 

Props epiqueras, youknowriad, donmhico, jorgefilipecosta, soean, mcsf, noisysocks, andraganescu, gziolo, talldanwp, iseulde, nrqsnchz, mapk, karmatosed, joen, afercia, kjellr, desrosj.
Fixes #48186.
No action taken yet
git: 6013fa1
svn: r46363
138 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-30 19:36:42 +0000
Accessibility: Media: Use the ARIA tabs pattern for the media modal menus.
The ARIA tabs pattern improves interaction for keyboard and assistive technologies users.
It gives the menu items proper roles, and `aria-selected` allows users of assistive technologies to know which tab is currently selected.

Props audrasjb, afercia, joedolson, karmatosed, melchoyce.
See #47149.
No action taken yet
git: da73b95
svn: r46362
139 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-30 19:19:06 +0000
Media: Fix the media modal "Insert from URL" field height after [46356].
See #47477.
No action taken yet
git: dc07c1f
svn: r46361
140 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 18:51:30 +0000
Site Health: Revert [46323-46325] for further discussion of how the admin email verification should be filtered.
See #48153.
No action taken yet
git: 74f9cf7
svn: r46360
141 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-30 18:04:59 +0000
Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
Props audrasjb, garrett-eclipse.
Fixes #48131.
No action taken yet
git: 4b152de
svn: r46359
142 of 2871
Author
Anthony Burchell <[email protected]> 2019-09-30 17:55:07 +0000
Media: Prevents clipping of text when scaling image edit screen.
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.

Props sabernhardt, audrasjb, afercia.
See #47115.
No action taken yet
git: d653490
svn: r46358
143 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 17:53:53 +0000
Site Health: Improve the message displayed to sites not utilizing HTTPS.
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.

Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118.
No action taken yet
git: f905d80
svn: r46357
144 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 17:40:14 +0000
Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46271], see https://github.com/WordPress/twentytwenty/compare/932b16248...dd7032f

Props anlino, ianbelanger, nielslange, acosmin, netweb, williampatton, adhitya03, phpdocs, acalfieri, itowhid06, littlebigthing, aristath, karmatosed, poena.
See #48110.
No action taken yet
git: f93cd8c
svn: r46356
145 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-30 17:23:06 +0000
Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
Improves cross-browsers rendering and addresses most of the reported edge cases.

See #47477.
No action taken yet
git: 48564fa
svn: r46355
146 of 2871
Author
Anthony Burchell <[email protected]> 2019-09-30 17:11:14 +0000
Media: Revert [46354] preventing bad clipping of text in image details page.
See #47115.
No action taken yet
git: 32b7a5e
svn: r46354
147 of 2871
Author
Anthony Burchell <[email protected]> 2019-09-30 16:33:39 +0000
Media: Prevents clipping of text when scaling image edit screen.
Props sabernhardt, audrasjb, afercia.
See #47115.
No action taken yet
git: ba2d023
svn: r46353
148 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-30 16:27:11 +0000
Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins.
Props pbiron.
See #47873.
No action taken yet
git: e9e1c4c
svn: r46352
149 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 15:57:21 +0000
Built/Test Tools: Ignore the `node_modules` folder in Twenty Twenty.
Ignore the `node_modules` folder in Twenty Twenty in SVN, and when running `grunt build` or `grunt jshint:themes`.

See #48110.
No action taken yet
git: 14d0316
svn: r46351
150 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 15:43:36 +0000
Docs: Correct `WP_Styles_Registry` documentation.
This change updates the file’s docblock to correctly indicate `WordPress`/`Blocks` as the `@package`/`@subpackage`, updates the `_doing_it_wrong()` versions to `5.3.0` instead of the Gutenberg plugin versions, and removes some stray `gutenberg` text domains.

Props david.binda.
Fixes #48181.
No action taken yet
git: 9288beb
svn: r46350
151 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-30 10:52:36 +0000
Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
Props Joen.
See #34904.
No action taken yet
git: 0e26adb
svn: r46349
152 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-30 01:29:10 +0000
Comments: Add `rel="nofollow ugc"` attribute to links in comments.
UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props audrasjb, joostdevalk, dkarfa, SergeyBiryukov.
Fixes #48022.
No action taken yet
git: 1504804
svn: r46348
153 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-30 00:04:46 +0000
Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port.
Props garrett-eclipse, pierlo, afragen.
Fixes #48077.
No action taken yet
git: d6aa801
svn: r46347
154 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-29 22:39:20 +0000
Twenty Nineteen: Remove trailing comma after selector in `sass/site/primary/_posts-and-pages.scss`.
Props itowhid06.
Fixes #48171.
No action taken yet
git: 679b6a0
svn: r46346
155 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-29 22:33:35 +0000
REST API: Combine `array` and `object` cases in `WP_REST_Meta_Fields::get_default_for_type()` to remove duplicated line.
Add missing description for `$type` parameter.

Props itowhid06, dkarfa.
Fixes #48169.
No action taken yet
git: f00bcea
svn: r46345
156 of 2871
Author
Andrea Fercia <aferci[email protected]> 2019-09-29 21:55:51 +0000
Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
Props desrosj, garrett-eclipse, afercia.
See #47498.
No action taken yet
git: ef206a7
svn: r46344
157 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-29 21:52:38 +0000
Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.
No action taken yet
git: 47643f7
svn: r46343
158 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-29 12:21:29 +0000
Coding Standards: Remove inline assignments and extra whitespace in `tests/multisite/network.php`.
Props garrett-eclipse, jrf.
See #48142.
No action taken yet
git: c3dfdf8
svn: r46342
159 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-29 12:18:48 +0000
Docs: Improve comments in `tests/multisite/network.php` per the documentation standards.
Props garrett-eclipse, jrf.
See #48142.
No action taken yet
git: 65ec343
svn: r46341
160 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-29 11:03:14 +0000
Docs: Improve documentation for `::display()` methods in various list tables.
Props itowhid06.
Fixes #47947.
No action taken yet
git: d020b72
svn: r46340
161 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-28 16:44:09 +0000
Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
See #47477.
See #48128.
No action taken yet
git: 8408e42
svn: r46339
162 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-28 16:34:43 +0000
Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.
No action taken yet
git: d47627d
svn: r46338
163 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-28 16:19:49 +0000
Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
Props masummdar, audrasjb, afercia.
Fixes #47318.
No action taken yet
git: 91f5592
svn: r46337
164 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-28 16:14:50 +0000
Accessibility: Improve and modernize user interface controls. Make the select elements background white.
Props adhitya03.
See #47477.
Fixes #48128.
No action taken yet
git: ab8c873
svn: r46336
165 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-27 23:02:29 +0000
Docs: Add documentation for `WP_Comments_List_Table::display()`.
Props itowhid06, dinhtungdu.
Fixes #47929.
No action taken yet
git: 4ffefc2
svn: r46335
166 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-27 14:45:49 +0000
Comments: Avoid PHP notice in `get_comment_reply_link()` for `null` comment.
If there is no global comment, or the input comment is null, return early to prevent warnings.

Fixes #41846
Props birgire, earnjam
No action taken yet
git: 9e59d26
svn: r46334
167 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-26 22:19:14 +0000
Login and Registration: Revert divs and restore paragraphs after [46256].
Fixes #42888.
No action taken yet
git: ea1d3b1
svn: r46333
168 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-26 22:07:05 +0000
Options: `register_uninstall_hook()` causes large amounts of unnecessary option updates.
Prevent extra database read/writes from the the hook.

Props jeichorn, MikeHansenMe, DrewAPicture, Rahe, tha_sun, mikeschroder.
Fixes #31792.
No action taken yet
git: f2e9aa7
svn: r46332
169 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-26 21:50:10 +0000
Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201
No action taken yet
git: 4369b82
svn: r46331
170 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-26 20:37:01 +0000
Media: Restore the original Image Editor columns layout after [46326].
Fixes #47116.
No action taken yet
git: 2ff8e68
svn: r46330
171 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-26 20:30:59 +0000
Menus: Replace http with https in placeholders.
Encourage the use of https with the placeholder text in menus.

Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.
No action taken yet
git: d9e6a5d
svn: r46329
172 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 20:30:35 +0000
Tests: Correct `::assertArrayHasKey()` capitalization in [46252].
Props dkarfa, david.binda.
Fixes #48155.
No action taken yet
git: 6b983b1
svn: r46328
173 of 2871
Author
John Blackbourn <[email protected]> 2019-09-26 20:25:59 +0000
Themes: Add a test to ensure `get_template_part()` does not return a value.
This function must not be modified to return anything due to existing themes which output the return value, for example via `echo get_template_part( ... )`.

See #40969
No action taken yet
git: c61471a
svn: r46327
174 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-26 20:20:51 +0000
Themes: Docblock cleanup for `get_theme_root_uri()`
In the function docblock of `get_theme_root_uri()`, the argument types of `$stylesheet_or_template` and `$theme_root` do not match. Default values of arguments are boolean but in function doc they are stated as strings.

Props subrataemfluence, williampatton, garrett-eclipse.
Fixes #44397.
No action taken yet
git: d6770e5
svn: r46326
175 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-26 17:15:34 +0000
Accessibility: Media: Make the Image Editor buttons text visible.
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.
No action taken yet
git: c177399
svn: r46325
176 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-26 16:31:33 +0000
Docs: Correct typos introduced in [46324]
Props TimothyBlynJacobs.
See #48153.
No action taken yet
git: fbb6d75
svn: r46324
177 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-26 15:44:10 +0000
Site Health: Consolidate documentation for the `admin_email_check_interval` filter.
See #48153.
No action taken yet
git: d8337e1
svn: r46323
178 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-26 15:40:10 +0000
Site Health: Allow the capability required for the site admin email verification screen to be filtered.
Props desrosj, Clorith.
Fixes #48153.
No action taken yet
git: 1c9f3e0
svn: r46322
179 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 13:52:46 +0000
Code Modernisation: Introduce the spread operator in `do_action()`.
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 8c8999d
svn: r46321
180 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-26 13:05:19 +0000
Media: Fix JavaScript TypeError after [45376].
Props desrosj, afercia.
Fixes #48021.
No action taken yet
git: da43c14
svn: r46320
181 of 2871
Author
Gary Pendergast <[email protected]wordpress.org> 2019-09-26 04:57:38 +0000
Build Tools: Pass the current uid/gid to Docker containers.
This prepares for an upcoming change to the Docker images, which improves file permission handling.

See #47767.
No action taken yet
git: d2ec28b
svn: r46319
182 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 02:28:15 +0000
Login and Registration: Standardize on `6 * MONTH_IN_SECONDS` over `180 * DAY_IN_SECONDS` for `admin_email_check_interval` filter.
[45788] changed the first instance, but not the second.

Props tmatsuur.
Fixes #48144.
No action taken yet
git: 4f77abf
svn: r46318
183 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 01:39:19 +0000
REST API: Use delta comparison for floating date test added in [46279] to avoid race conditions.
See #48113.
No action taken yet
git: f68fe85
svn: r46317
184 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 01:33:44 +0000
Coding Standards: Remove inline assignment in `test_wp_delete_term_should_invalidate_cache()`.
See #48142.
No action taken yet
git: be8218e
svn: r46316
185 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 01:23:23 +0000
General: Correct strict comparison in `WP_Links_List_Table::column_categories()` introduced in [46313].
`$cat_id` is a string, `$category` is an integer.

See #48142.
No action taken yet
git: 0257fba
svn: r46315
186 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-26 00:56:36 +0000
Docs: Improve documentation for `_post_states()` and `get_post_states()`.
Add documentation for `_media_states()`.

See #47110.
No action taken yet
git: 628a545
svn: r46314
187 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-26 00:36:20 +0000
General: Further phpcs cleanup.
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.

Props: whyisjake, garrett-eclipse, desrosj
No action taken yet
git: d639bd4
svn: r46313
188 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-25 23:37:31 +0000
General: Further phpcs cleanup.
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.
Props whyisjake, garrett-eclipse.
No action taken yet
git: ad7b57b
svn: r46312
189 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-25 22:52:54 +0000
General: Linter cleanup
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.

Fixes #48142
Props whyisjake
No action taken yet
git: 61f86f6
svn: r46311
190 of 2871
Author
Peter Wilson <[email protected]> 2019-09-25 22:22:40 +0000
Docs: Fix typo in `wp_print_scripts()`' reference to `WP_Scripts::do_item()`.
Fixes #48141.
No action taken yet
git: fd0b230
svn: r46310
191 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-25 22:11:11 +0000
Themes: Fix javascript regression that linter found.
Tests were failing from line length optimizations and double quotes. 

Fixes #37536
No action taken yet
git: 8f43c53
svn: r46309
192 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-25 21:51:00 +0000
Menus: Duplicate Page Entry in View All Pages when generating a Menu
Simplifies the interface in menu creation.

Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks
No action taken yet
git: 6649b36
svn: r46308
193 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-25 21:37:09 +0000
Themes: Improve Twenty Fifteen sticky sidebar logic
The current logic in TwentyFifteen (#30366) for making the sidebar sticky while still allowing to scroll through it when the sidebar height is larger than the viewport height is flawed and massively overcomplicated.
This can be mitigated by removing the admin bar specific logic and leaving most of the heavy lifting up to the browser.

Fixes #37536

Props DvanKooten, lukecavanagh, karmatosed, ianbelanger, davidbaumwald
No action taken yet
git: 2d4521d
svn: r46294
194 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-25 19:54:18 +0000
Build/Test Tools: Remove stray `+` introduced in [45979].
Props david.binda.
Fixes #48127.
No action taken yet
git: 00de1af
svn: r46293
195 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-25 16:38:57 +0000
Accessibility: Implement the new focus styles on the login screen after [46247].
Props @kjellr.
See #47153.
No action taken yet
git: fc33d39
svn: r46292
196 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-25 15:49:41 +0000
Pings/Trackbacks: Use correct variable in a `foreach()` loop in `do_all_pings()`.
Props itowhid06.
Fixes #48094. See #36824.
No action taken yet
git: 2dbc7e0
svn: r46291
197 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-25 14:01:51 +0000
Build/Test Tools: Move Composer script command line directives to the PHPCS ruleset.
Also, move all arguments up to the top of the custom ruleset to make it easier to understand the conditions the ruleset is run under.

Props desrosj, jrf.
See #46152.
No action taken yet
git: 3369608
svn: r46290
198 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-25 13:46:55 +0000
Build/Test Tools: Introduce automated PHP compatibility checking.
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).

The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.

Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152.
No action taken yet
git: bad0295
svn: r46289
199 of 2871
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2019-09-25 08:19:17 +0000
Block Editor: Align the version of React with the one used in Gutenberg plugin
Gutenberg 6.5 works with react and react-dom set to v16.9.0. This change aligns both.

Props youknowriad.
Fixes #48121.
No action taken yet
git: 98067df
svn: r46288
200 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-24 12:53:09 +0000
Docs: Improve consistency in `@since` tags for parameters that were made optional.
See #47110.
No action taken yet
git: f8688bb
svn: r46287
201 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-24 02:55:56 +0000
Script Loader: Add `function_exists()` checks for `is_admin()` and `current_theme_supports()`, to accomodate for using `WP_Dependencies` as a standalone class.
Remove `<![CDATA[` when outputting HTML5 script tags. 

Props azaozz.
Fixes #42804.
No action taken yet
git: 31f33fb
svn: r46286
202 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-24 00:16:30 +0000
Post WordPress 5.3 Beta 1 version bump.
No action taken yet
git: 0192115
svn: r46285
203 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 23:53:09 +0000
WordPress 5.3 Beta 1.
No action taken yet
git: e2882e5
svn: r46284
204 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 23:23:37 +0000
Coding Standards: Fix WPCS issue in [46283].
See #48110.
No action taken yet
git: 197d99a
svn: r46283
205 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 23:16:59 +0000
Twenty Twenty: Rename widget areas to `sidebar-1` and `sidebar-2`.
This ensures that widgets are mapped correctly and is consistent with the previous default themes.

See https://github.com/WordPress/twentytwenty/issues/481.

Reverts [46282].

Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110.
No action taken yet
git: bb41a65
svn: r46282
206 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 22:03:53 +0000
Tests: Correct sidebar names for Twenty Twenty.
See #48110.
No action taken yet
git: 03fdd65
svn: r46281
207 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 21:23:36 +0000
Site Health: Move "The folder ... was detected as being under version control" message from failure to warning.
Props afragen, davidbaumwald.
Fixes #47982.
No action taken yet
git: 4b6a9f9
svn: r46280
208 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 21:17:04 +0000
REST API: Use delta comparison for floating date tests added in [46252] to avoid race conditions.
See #39953.
No action taken yet
git: b7f36f7
svn: r46279
209 of 2871
Author
K. Adam White <[email protected]> 2019-09-23 21:01:16 +0000
Posts, Post Types: Build list of "date floating" post stati dynamically when inserting post.
Completes work begun in #39953 to expose "date floating" status information to frontend clients via the REST API.

Props TimothyBlynJacobs.
Fixes #48113.
No action taken yet
git: 0f1636c
svn: r46278
210 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 20:59:48 +0000
Bundled Themes: Make Twenty Twenty the new default theme.
After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress.

See #48110.
Props desrosj, ocean90.
No action taken yet
git: e256cb1
svn: r46277
211 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 20:53:02 +0000
Bundled Themes: Fix failing tests for Twenty Twenty.
Follow up of [46271].

See #48110.
No action taken yet
git: e4a1254
svn: r46276
212 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 20:51:38 +0000
Site Health: Use `WP_Automatic_Updater::is_disabled()` to check whether automatic updates are disabled.
The previous check for `DISALLOW_FILE_MODS` and `AUTOMATIC_UPDATER_DISABLED` constants didn't always provide accurate results.

Props Clorith, kraftner, afragen.
Fixes #47869.
No action taken yet
git: 1a1d852
svn: r46275
213 of 2871
Author
K. Adam White <[email protected]ess.org> 2019-09-23 20:47:20 +0000
Coding Standards: Fix WPCS issue in [46274].
See #39953.
No action taken yet
git: ac0b7f2
svn: r46274
214 of 2871
Author
K. Adam White <[email protected]> 2019-09-23 20:33:07 +0000
REST API: Mark "pending" status as date_floating.
See: https://github.com/WordPress/gutenberg/issues/13176

Props TimothyBlynJacobs.
Fixes #39953.
No action taken yet
git: 685d4a2
svn: r46273
215 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 20:26:10 +0000
Site Health: Include simple debug data in fatal error protection email.
Introduce `recovery_email_debug_info` filter for the debug information included in the email.

Props Clorith, TimothyBlynJacobs.
Fixes #48090.
No action taken yet
git: 49155e6
svn: r46272
216 of 2871
Author
K. Adam White <[email protected]> 2019-09-23 20:24:59 +0000
REST API: Introduce WP_Post_Type::get_rest_controller() caching method to prevent unnecessary REST controller construction.
Cache REST controller references on their associated post type object to prevent unnecessary controller re-instantiation, which previously caused "rest_prepare_{$post_type}" and "rest_{$post_type}_query" to run twice per request.

Props TimothyBlynJacobs, patrelentlesstechnologycom.
Fixes #45677.
No action taken yet
git: 509647e
svn: r46271
217 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 20:14:50 +0000
Bundled Themes: Import Twenty Twenty, the new default theme for WordPress 5.3.
Welcome to the bundled themes family!

Theme development to this point has taken place on GitHub. See: https://github.com/WordPress/twentytwenty/.

Props anlino, ianbelanger, audrasjb, nielslange, fabiankaegy, mukesh27, poena, joyously, emiluzelac, williampatton, dingo-d, dkarfa, acosmin, rabmalin, kafleg, jeffpaul, hareesh-pillai, burhandodhy, afercia, juanfra, soean, presskopp, justinahinon, jrf, netweb, garyj, pento, flixos90, vbaimas, zebulan, byalextran, mor10, kjellr, allancole, tdh, karmatosed, mapk, matt, andrewtaylor-1, ismailelkorchi, garrett-eclipse, gsayed786, dianeco, celloexpressions, aristath, nadir, cbravobernal, intimez, hometowntrailers, collet, littlebigthing, tobifjellner, kevinkovadia, jarretc.
See #48110.
No action taken yet
git: d88473f
svn: r46270
218 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 20:08:04 +0000
Themes: After [46164], make sure `$type_attr` is always defined in `_custom_background_cb()`.
Props davidbaumwald.
Fixes #48112.
No action taken yet
git: a9fb2f6
svn: r46269
219 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 20:03:15 +0000
Site Health: Introduce `site_status_test_result` filter for the output of a finished Site Health test.
Props Clorith.
Fixes #47864.
No action taken yet
git: 9a105cf
svn: r46268
220 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 19:49:06 +0000
Site Health: Update PHP extension tests to reflect the current state of the Hosting Teams handbook recommendations.
Props Clorith, bronsonquick, jrf, johnbillion, galbaras, mikeschroder, jorbin.
Fixes #47454.
No action taken yet
git: 13be30f
svn: r46267
221 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 19:38:56 +0000
Site Health: Improve wording for PHP update warning.
Props danieltj, garrett-eclipse, marybaum, afragen, chetan200891.
Fixes #47644.
No action taken yet
git: f29fdab
svn: r46266
222 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 19:28:43 +0000
Coding Standards: Fix WPCS issue in [46262].
See #47952.
No action taken yet
git: 06868d4
svn: r46265
223 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 19:24:20 +0000
Privacy: Introduce `wp_privacy_personal_data_email_to` and `wp_privacy_personal_data_email_subject` filters.
Pass email data to the `wp_privacy_personal_data_email_content` filter.

Props garrett-eclipse, thakkarhardik, birgire.
Fixes #46303.
No action taken yet
git: 7ae0a59
svn: r46264
224 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-23 19:12:04 +0000
Privacy: Show a success message for personal data erasure.
Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer.
Fixes #44135.
No action taken yet
git: 027710e
svn: r46263
225 of 2871
Author
John Blackbourn <[email protected]> 2019-09-23 19:09:54 +0000
Taxonomy: Redirect to the correct URL after deleting a taxonomy term attached to a post type other than Post.
Props donmhico, mukesh27

Fixes #47858
No action taken yet
git: f3a268f
svn: r46262
226 of 2871
Author
John Blackbourn <[email protected]> 2019-09-23 18:54:16 +0000
Build/Test tools: Ensure the `create_and_get()` factory method returns the appropriate WP_Error when creating a term fails.
Fixes: #47952
No action taken yet
git: 2b076b7
svn: r46261
227 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 18:33:10 +0000
Coding Standards: Fix a coding standards issue introduced in [46254].
See #37392.
No action taken yet
git: 63bf8c8
svn: r46260
228 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 18:16:14 +0000
External Libraries: Fix PHP 7.4 compatibility issues in the SimplePie library.
See: https://github.com/simplepie/simplepie/commit/38b504969ed08903cb12718e8270263a8c93080e

Props jrf, stevenkword, jorbin, desrosj.
See #47746.
No action taken yet
git: 5863bd3
svn: r46259
229 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 18:11:15 +0000
Fix PHP coding standards after [46251].
No action taken yet
git: 58bd8a4
svn: r46258
230 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 18:11:01 +0000
External Libraries: Fix PHP 7.4 compatibility issues in the Requests library.
See: https://github.com/rmccue/Requests/compare/v1.7.0...3470169

Props jrf, jorbin, desrosj.
See #47746.
No action taken yet
git: c1d89f7
svn: r46257
231 of 2871
Author
Ella van Durpe <[email protected]> 2019-09-23 18:08:41 +0000
r46253: Use implode instead of join, see #47746
No action taken yet
git: 0ff03b3
svn: r46256
232 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 18:05:16 +0000
Login and Registration: Add a "Show password" button on the login page.
The ability for users to see the password they're typing improves usability and accessibility of the login users flow.

- brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages
- improves association of labels and input fields by using explicit association with `for` / `id` attributes
- slightly increases the "Remember me" label font size

Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia.
Fixes #42888.
No action taken yet
git: 03fe23c
svn: r46255
233 of 2871
Author
Ella van Durpe <[email protected]> 2019-09-23 17:59:10 +0000
Revert accidental change to package-lock.json in r46253
No action taken yet
git: 1c69792
svn: r46254
234 of 2871
Author
John James Jacoby <[email protected]> 2019-09-23 17:50:22 +0000
Multisite/Sites: supplemental commit to r46251.
This commit adds the links to the list-table class itself (that were missed in r46251.)

See #37392. Props pbiron, thomaswm.
No action taken yet
git: 83dd94f
svn: r46253
235 of 2871
Author
Ella van Durpe <[email protected]> 2019-09-23 17:46:33 +0000
Editor: Add Nonce Endpoint
This is a follow up to #47843, implementing a PHP endpoint and inline scripts 
after the editor package updates. The action was originally added in
https://github.com/WordPress/gutenberg/pull/16683.

Fixes #48076.
No action taken yet
git: 42e5e4d
svn: r46252
236 of 2871
Author
K. Adam White <[email protected]> 2019-09-23 17:39:36 +0000
REST API: Introduce date_floating property on status endpoint response objects.
Expose a date_floating property on all status objects to permit clients (including the block editor) to make correct decisions about date handling for posts of varying status.

Props mnelson4, earnjam, kadamwhite, jnylen0, nerrad, pento.
See #39953.
No action taken yet
git: f2b03e2
svn: r46251
237 of 2871
Author
John James Jacoby <[email protected]> 2019-09-23 17:34:20 +0000
Multisite/Sites: Add links to filter websites by status.
This commit brings the Network-Admin Sites list page up-to-speed with other similar list-table powered pages, by adding links to filter the results by Site Status.

Includes a single unit test for the newly introduced `wp_count_sites()` multisite function, named to match the `wp_count_` function pattern from other list tables.

Fixes #37392. Props mnelson4, spacedmonkey, pbiron.
No action taken yet
git: aba005b
svn: r46250
238 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 17:29:46 +0000
Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to.
Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable.
In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`.

The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users.

Props adamsilverstein, antpb, anevins.
Fixes #47131.
No action taken yet
git: 27a5302
svn: r46249
239 of 2871
Author
K. Adam White <[email protected]> 2019-09-23 17:24:58 +0000
REST API: Pass "null" as the post date property to reset post to initial "floating" date value.
Props TimothyBlynJacobs, adamsilverstein, jnylen0, mnelson4.
Fixes #44975.
No action taken yet
git: e3db9a1
svn: r46248
240 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 16:50:17 +0000
Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units

Props kjellr, afercia, audrasjb.
Fixes #47498.
No action taken yet
git: e994411
svn: r46247
241 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 16:20:24 +0000
Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls.
Props anevins, melchoyce, audrasjb, kjellr.
Fixes #47153.
No action taken yet
git: 0ff7ebd
svn: r46246
242 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-23 16:07:23 +0000
Docs: Improve documentation for the `supports` argument in `register_post_type()`/`add_post_type_support()`.
Follow up of [46160].

Fixes #40413.
No action taken yet
git: 3363eaa
svn: r46245
243 of 2871
Author
Anthony Burchell <[email protected]> 2019-09-23 16:02:38 +0000
Media: Sets `post_id` optional in `media_sideload_image()` and `media_handle_sideload()`.
Props SergeyBiryukov, donmhico, mikeschroder, sebastian.pisula.
Fixes #43579.
No action taken yet
git: 036973b
svn: r46244
244 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 15:48:32 +0000
Accessibility: Improve and modernize user interface controls for better contrast. Fourth part: Media Views form controls.
Props anevins, audrasjb, nrqsnchzm, kjellr, karmatosed.
Fixes #47150.
No action taken yet
git: 3f58ce5
svn: r46243
245 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 15:26:23 +0000
Accessibility: Improve and modernize user interface controls. Third part: allow buttons and form controls to scale with text.
Props kjellr, abrightclearweb, audrasjb.
Fixes #47477.
No action taken yet
git: 82bded3
svn: r46242
246 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 15:09:59 +0000
Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements.
Introduces better contrast for borders of the following user interface elements:
- Tables
- Screen Options and Help 
- Admin notices
- Welcome panel
- Meta boxes (post boxes)
- Cards
- Health Check accordions and headings
- Theme and Plugin upload forms

Props kjellr, melchoyce, karmatosed, audrasjb.
Fixes #48101.
No action taken yet
git: 94211ae
svn: r46241
247 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 14:42:36 +0000
Accessibility: Improve and modernize user interface controls for better contrast. First part: buttons and links.
- Introduces new styles for the buttons, with better contrast for borders and better focus style.
- Introduces a new focus style for links.
- The new styles improve consistency with the ones used in the new Block Editor (Gutenberg).

Props michaelarestad, truchot, mor10, kellychoffman, adamsoucie, paaljoachim, Joen, kjellr, melchoyce, karmatosed, audrasjb, afercia.
Fixes #34904.
No action taken yet
git: 42b5133
svn: r46240
248 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 12:41:14 +0000
Accessibility: Menus: Improve the menu items "Select All".
- changes "Select All" from a link to a checkbox
- the new checkbox is available only when JavaScript support is on
- semantically and for accessibility, a checkbox is a better user interface control because the available action is clear to all users and the selected state is communicated natively
- it's consistent with the existing pattern for the admin tables

Props birgire, audrasjb, afercia.
Fixes #47048.
No action taken yet
git: 01b18e8
svn: r46239
249 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 12:18:53 +0000
Accessibility: Media: Make screen readers announce the Media search results.
- adds audible messages via `wp.a11y.speak()` to announce the search results 
- removes a `keyup` event that was there only to support old browsers 
- removes `aria-modal="true"` from the media modal dialog as it prevents the ARIA live regions to be perceived by screen readers
- triggers the search only after 2 ASCII characters have been typed

Props anevins, antpb, aduth, loreleiaurora, afercia.
Fixes #47146.
No action taken yet
git: 8fdabdb
svn: r46238
250 of 2871
Author
Mike Schroder <[email protected]> 2019-09-23 10:35:45 +0000
Media: Prevent unnecessary whitespace around PDF Thumbnails.
Stops unintended whitespace from showing around PDF thumbnails
when the PDF creation tool utilized a CropBox.

Props michelweimerskirch, joemcgill.
Fixes #45598.
No action taken yet
git: c9a2fde
svn: r46237
251 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-23 09:59:15 +0000
Media: Fix buttons group layout for Internet Explorer 11 after [45499].
Props sabernhardt, afercia.
See #47122.
Fixes #48087.
No action taken yet
git: 21030b6
svn: r46236
252 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-22 22:31:34 +0000
Accessibility: Make sure the navigation ARIA landmarks used for posts and comments navigation are properly labelled.
The `<nav>` element defines an ARIA landmark by default: landmarks help assistive technology users to perceive the page main sections and jump through them. However, when a landmark is used more than once in a page, it needs to be distinguished from the other ones to let users understand what the landmark is about.

Adds an `aria-label` parameter to the following functions: 

- `_navigation_markup()`
- `get_the_post_navigatio()`
- `get_the_posts_navigation()`
- `get_the_posts_pagination()`
- `get_the_comments_navigation()`
- `get_the_comments_pagination()`

Props sabernhardt, williampatton, SergeyBiryukov, audrasjb.
Fixes #47123.
No action taken yet
git: 123c175
svn: r46235
253 of 2871
Author
Peter Wilson <[email protected]> 2019-09-22 22:16:19 +0000
KSES: Add support for modern layout techniques in `style` attribute.
Adds support for `flex`, `grid` and `column` layout techniques to the list of CSS attributes considered safe for inline CSS. The `\` character and CSS functions, eg `minmax()` are not yet supported.

Extends support of `border` properties to include `border-radius` and individual `background` properties to include all those implicitly supported by the shorthand attribute.

Props mrahmadawais, marybaum, birgire, peterwilsoncc, azaozz.
Fixes #37248.
See #47367.
No action taken yet
git: 975812c
svn: r46234
254 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-22 21:58:06 +0000
Accessibility: Twenty Nineteen: Improve the special pages headings.
Improves information provided by the headings, their alignment and spacing in the following special pages:
- search page with and without search results
- 404 page (no content)
- archive pages

Props ianbelanger, kjellr, nrqsnchz, audrasjb.
Fixes #47140.
No action taken yet
git: 308e86c
svn: r46233
255 of 2871
Author
K. Adam White <[email protected]> 2019-09-22 19:14:03 +0000
REST API: Consistently default URL scheme to "rest", not "json".
The "json" scheme is a holdover from the pre-merge plugin version of the REST API, and was corrected elsewhere in core in [34300]. Only "rest" is officially supported in `set_url_scheme()`.

Props DrewAPicture, rmccue.
Fixes #45169.
No action taken yet
git: 6bd7097
svn: r46232
256 of 2871
Author
John Blackbourn <[email protected]> 2019-09-21 17:40:58 +0000
Docs: Docblock corrections and improvements, mostly related to various `pre_*` filters.
See #47110
No action taken yet
git: 144c5f7
svn: r46231
257 of 2871
Author
Dominik Schilling <[email protected]> 2019-09-21 16:05:13 +0000
Site Health: Don't verify SSL certificate when testing the local site.
The SSL certificate may be self-signed which prevents various tests from returning proper results. Since the Cron API and file editors don't verify the certificate the tests shouldn't either.

Props Clorith, ocean90.
Fixes #47957.
No action taken yet
git: e6ea695
svn: r46230
258 of 2871
Author
Dominik Schilling <[email protected]> 2019-09-21 15:58:38 +0000
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
Props Clorith.
See #47957.
No action taken yet
git: cb076ca
svn: r46229
259 of 2871
Author
ocean90 <[email protected]> 2019-09-21 15:53:02 +0000
I18N: Remove HTML tags from translatable string in `wp-login.php`.
See #46349.
No action taken yet
git: 39fff01
svn: r46228
260 of 2871
Author
Dominik Schilling <[email protected]> 2019-09-21 15:48:56 +0000
Site Health: Replace `wp_get_upload_dir()` with `wp_upload_dir()`.
`wp_get_upload_dir()` returns the theoretical path of the uploads directory. When there was no upload yet the test returns an incorrect result (not writeable) because the directory doesn't exist. Switching to `wp_upload_dir()`, which creates the directory on the fly, ensures a proper test result.

Fixes #47958.
No action taken yet
git: 2d1e8ad
svn: r46227
261 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-21 13:49:04 +0000
Coding Standards: Add missing `break` for the default case in `get_default_comment_status(()`.
Props itowhid06.
Fixes #48095.
No action taken yet
git: d6749c7
svn: r46226
262 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-21 13:47:12 +0000
Docs: Correct type for the `$data` parameter of `WP_Theme::cache_add()`.
Props itowhid06.
Fixes #48096.
No action taken yet
git: 4eb545a
svn: r46225
263 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-21 12:48:29 +0000
Code Modernization: Use the `**` operator instead of the `pow()` function in `wp_convert_bytes_to_hr()` for better performance.
Use the `MB_IN_BYTES` constant instead of the `pow()` function in `WP_Customize_Manager::_validate_header_video()` for better readability.

Props ayeshrajans, jrf.
Fixes #48083.
No action taken yet
git: 4d6ca5b
svn: r46224
264 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-21 10:28:53 +0000
Tests: Correct assertion in `test_wp_validate_boolean()` to make sure the return type is properly tested.
Props jrf.
Fixes #39868.
No action taken yet
git: 1199a99
svn: r46223
265 of 2871
Author
John Blackbourn <[email protected]> 2019-09-21 10:01:05 +0000
Docs: Improve the docs for comment counting related functions.
See #47110, #48093
No action taken yet
git: 0bd3d78
svn: r46222
266 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:43:50 +0000
Tests: Remove a workaround for `str_getcsv()`.
The `str_getcsv()` function was introduced in PHP 5.3.0, so no longer needs a polyfill.

Props jrf.
Fixes #48074.
No action taken yet
git: 5f0fb23
svn: r46221
267 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:39:23 +0000
Tests: Remove a workaround for `get_called_class()`.
The `get_called_class()` function was introduced in PHP 5.3, so no longer needs a workaround.

Mark `WP_UnitTestCase_Base::get_called_class()` as deprecated. Leave it in place for now as plugins or themes using the WP unit test framework might still call this method.

Props jrf.
See #48074.
No action taken yet
git: 4ee97a4
svn: r46220
268 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:33:13 +0000
Code Modernization: Remove workarounds for `spl_object_hash()`.
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so these workarounds are no longer needed.

Props jrf.
See #48074.
No action taken yet
git: 3a49864
svn: r46219
269 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:26:18 +0000
Tests: Remove a test for `rest_preload_api_request()` only relevant for PHP 5.2.
Props dkarfa.
See #48074.
No action taken yet
git: 8e454ba
svn: r46218
270 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:22:38 +0000
Code Modernization: Remove a workaround for `CURLOPT_PROTOCOLS` in `WP_Http_Curl::request()`.
The `CURLOPT_PROTOCOLS` constant was introduced in PHP 5.2.10, so no longer needs a workaround.

Props jrf.
See #48074.
No action taken yet
git: f3a0da9
svn: r46217
271 of 2871
Author
Sergey Biryukov <[email protected]git.wordpress.org> 2019-09-20 22:17:48 +0000
Code Modernization: Remove a workaround for `IMAGETYPE_ICO` in `file_is_displayable_image()`.
The `IMAGETYPE_ICO` constant was introduced in PHP 5.3, so no longer needs a workaround.

Props jrf.
See #48074.
No action taken yet
git: 8991815
svn: r46216
272 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:12:06 +0000
Code Modernization: Remove a workaround for HHVM in `WP_Image_Editor_Imagick::test()`.
Support for HHVM was dropped in 2017 via #40548.

Props jrf.
See #48074.
No action taken yet
git: 9fd60c9
svn: r46215
273 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:06:40 +0000
Docs: Update a comment about `pcre.backtrack_limit` upper limit in `benchmark_pcre_backtracking()`.
See #48074.
No action taken yet
git: 099adc0
svn: r46214
274 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 22:01:36 +0000
Code Modernization: Remove all code using a `version_compare()` with a PHP version older than PHP 5.6.
Props jrf.
Fixes #48074.
No action taken yet
git: 92d70ed
svn: r46213
275 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 21:58:42 +0000
Tests: Replace "blog" reference in a comment about `DISABLE_WP_CRON` usage with "site".
Props davidbaumwald.
Fixes #48089.
No action taken yet
git: 8de9624
svn: r46212
276 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 20:56:49 +0000
Docs: Add missing `$which` parameter descriptions.
Follow up of [46211].

See #45954.
No action taken yet
git: e31bd15
svn: r46211
277 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 20:52:58 +0000
Networks and Sites: Add support for the `extra_tablenav()` method in `WP_MS_Sites_List_Table`.
This method allows additional filters or other UI components to be added to the top and bottom of the `WP_List_Table` between the bulk actions dropdown and search input field.

Fixes #45954.
Props pbiron, desrosj.
No action taken yet
git: 6b65af9
svn: r46210
278 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 20:45:58 +0000
Code Modernization: Remove conditional use of PHP `realpath()`.
The `realpath()` function was introduced in PHP 4.0.0. There's no point in checking if the function exists in PHP 5.6+, in only 2 instances out of 29.

Props jrf.
Fixes #48075.
No action taken yet
git: 6922b15
svn: r46209
279 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 20:29:30 +0000
Privacy: Display group items count in the personal data export file if there's more than one item in the group.
Props birgire, garrett-eclipse, pputzer.
Fixes #46895.
No action taken yet
git: 946cada
svn: r46208
280 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 20:15:51 +0000
Code Modernization: Remove JSON related polyfills.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), JSON extension related polyfills and backwards compatibility code can now be removed.

This change removes the `json_last_error_msg()` and `JsonSerializable` polyfills included in WordPress for full JSON extension support in PHP < 5.6.

Follow up of [46205-46206].

See #47699.
Props jrf, Clorith, pento.
No action taken yet
git: dcd3371
svn: r46207
281 of 2871
Author
Adam Silverstein <[email protected]> 2019-09-20 20:07:53 +0000
Media: make search input full width on mobile. Take two.
Props m1tk00.
Fixes #40130.
No action taken yet
git: f6b8632
svn: r46206
282 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 20:07:28 +0000
Code Modernization: Remove JSON extension workarounds for PHP < 5.6.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), JSON extension related polyfills and backwards compatibility code can now be removed.

This change removes code that supported JSON related functionality on older versions of PHP. This includes (but is not limited to) checks that `json_last_error()` exists, checking and setting the `JSON_UNESCAPED_SLASHES` and `JSON_PRETTY_PRINT` constants if not previously defined, and deprecating the `_wp_json_prepare_data()` function (which was 100% workaround code).

Follow up of [46205].

See #47699.
Props jrf, Clorith, pento.
No action taken yet
git: 080e7a6
svn: r46205
283 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 19:52:38 +0000
Code Modernization: Deprecate the `Services_JSON` and `Services_JSON_Error` classes.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), JSON extension related polyfills and backwards compatibility code can now be removed.

Since there are still some plugins and themes that utilize the `Services_JSON` class, these classes will remain for the time being, but including the `wp-includes/class-json.php` file and creating `Services_JSON` instances will now throw deprecated notices.

See #47699.
Props jrf, Clorith, pento.
No action taken yet
git: 66ef5ec
svn: r46204
284 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-20 19:26:33 +0000
Remove left-over debug code after [46203].
See #46349.
No action taken yet
git: 388e7fe
svn: r46203
285 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-20 18:50:19 +0000
Admin email verification:
- Fix wording of the HTML title.
- Add hidden `(opens in a new tab)` to links that need it.
- Add the `screen-reader-text` CSS class to login.css.
- Add another translator comment.

Props afercia.
See #46349.
No action taken yet
git: 8993932
svn: r46202
286 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-20 18:20:26 +0000
Media/Upload: rotate images on upload according to EXIF Orientation.
Props msaggiorato, wpdavis, markoheijnen, dhuyvetter, msaggiorato, n7studios, triplejumper12, pbiron, mikeschroder, joemcgill, azaozz.

Fixes #14459.
No action taken yet
git: 188fe7e
svn: r46201
287 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 17:43:13 +0000
Docs: Correct `@since` tag for `comments_popup` public query variable removed in [35848].
Props hareesh-pillai.
Fixes #48080.
No action taken yet
git: e269403
svn: r46200
288 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 17:32:23 +0000
Build/Test Tools: Specify PHP 5.6 as the required version of PHP in Composer.
Props ayeshrajans, jrf, netweb.
Fixes #48081.
No action taken yet
git: a4e8fe2
svn: r46199
289 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-20 17:25:38 +0000
Site Health: Use sentence casing consistently in header tags.
Props SergeyBiryukov, ajayghaghretiya1, ronakganatra, mukesh27, Clorith.
Fixes #47298.
No action taken yet
git: 1a6d41b
svn: r46198
290 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 17:05:26 +0000
Docs: Add `@since` tag for the new `$position` argument added to `add_submenu_page()` and related functions in [46197].
See #39776.
No action taken yet
git: 78e8100
svn: r46197
291 of 2871
Author
Adam Silverstein <[email protected]> 2019-09-20 14:59:04 +0000
Menus: add a position argument to `add_submenu_page` and the helper functions that use it.
Add a position argument to the `add_submenu_page` function similar to the one already in `add_menu_page`. When adding sub menus enables setting the position in the sub menu where the item should appear.

In addition, add the position argument to functions that call `add_submenu_page` under the hood: `add_management_page`, `add_options_page`, `add_theme_page`, `add_plugins_page`, `add_users_page`, `add_dashboard_page`, `add_posts_page`, `add_media_page`, `add_links_page`, `add_pages_page` and `add_comments_page`.

Props welcher, birgire, alexvorn2.
Fixes #39776.
No action taken yet
git: 7389596
svn: r46196
292 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-20 13:04:50 +0000
Docs: Clarify that `$show_in_rest` parameter of `register_post_type()` and `register_taxonomy()` should be enabled for the post type or taxonomy to be available in the block editor.
Props ramon-fincken.
Fixes #48084.
No action taken yet
git: f326f7e
svn: r46195
293 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-20 11:40:06 +0000
Accessibility: Bundled Theme: Make the TwentyEleven skip link the first focusable element within the body.
Props poena, williampatton.
Fixes #47891.
No action taken yet
git: a63e490
svn: r46194
294 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-19 22:06:41 +0000
Multisite: Remove the redundant `blog_versions` table.
As part of the Multisite installation process, a `blog_versions` table is created. This table is never read from (except immediately prior to updating it), it's only ever inserted into or updated. It is not used to determine which blogs need to be upgraded.
This table was introduced in 3.0 when the WPMU schema was merged #11644 and it appears the table has never been used in core and is therefore redundant and may as well be removed.

Props johnbillion, nacin, ryan, johnjamesjacoby, whyisjake.

Fixes #19755. See #41685.
No action taken yet
git: c0ad8e7
svn: r46193
295 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-19 21:41:35 +0000
Networks and Sites: Save database version in site meta (Multisite)
Currently there is there a table in multisite called blog_versions. All this table stores is the database version as number and the date updated. With plans to add site meta in #37923 this new table should be used. This has a number of benefits, including functions to CRUD these values in the database. Once this data is in the blogmeta, table, the blog_versions table can be removed all together. If require a SQL view can be used blog_versions from data stored in blogmeta.

Props spacedmonkey, leogermani.

Fixes #41685. See #19755.
No action taken yet
git: dd330ae
svn: r46192
296 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-19 19:21:17 +0000
Login and Registration: Detect JavaScript on the login screen.
This allows the login screen to be targeted with CSS when JavaScript is disabled.

Props Nikschavan.
Fixes #38088.
No action taken yet
git: 0734694
svn: r46191
297 of 2871
Author
K. Adam White <[email protected]> 2019-09-19 15:49:33 +0000
REST API: Revert [45687].
This change may not be needed and further investigation is required before we accept it into a release.

See #46907.
No action taken yet
git: 09e56c0
svn: r46190
298 of 2871
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2019-09-19 15:46:02 +0000
Block Editor: Fixes failing unit tests related to Social Link blocks
Follow-up for #47843 - update the WordPress Packages to the ones used in the Gutenberg 6.5 release.

Props desrosj.

Fixes #47843.
No action taken yet
git: 7178c62
svn: r46189
299 of 2871
Author
Grzegorz (Greg) Ziółkowski <[email protected]> 2019-09-19 15:17:39 +0000
Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.5 release
Updated Packages:

In version 6.2:

@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]1.0
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]

In version 6.4:
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]

In version 6.5:
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]
@wordpress/[email protected]

Props youknowriad desrosj noisysocks pento jorgefilipecosta iseulde

Fixes: #47843
No action taken yet
git: 6eabc83
svn: r46188
300 of 2871
Author
Boone Gorges <[email protected]> 2019-09-19 15:02:20 +0000
Query: Expand the list of operators available to `compare_key` in `WP_Meta_Query`.
`compare_key`, introduced in #42409, previously supported only `=` and `LIKE`
operators. This changeset introduces a number of other operators: `!=`, `IN`,
`NOT IN`, `NOT LIKE`, `RLIKE`, `REGEXP`, `NOT REGEXP`, `EXISTS`, and `NOT EXISTS`
(the latter two aliased to `=` and `!=`, respectively). To support case-sensitive
regular expression key comparisons, the new `type_key` parameter will force
a MySQL `CAST` when 'BINARY' is passed.

Props soulseekah.
Fixes #43346.
No action taken yet
git: 7e69921
svn: r46187
301 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-19 15:00:14 +0000
Build/Test Tools: Improvements to Composer scripts.
Prefixing a script command with `@php ` ensures that the script runs with the same version of PHP that Composer is installed with (and not the system default).

This change also updates the `phpcs` and `phpcbf` commands to use the version of PHPCS installed by Composer.

The `—standard` is no longer explicitly passed to the command. By default, PHPCS will look for `phpcs.xml.dist`, which is the name of the custom standards file currently in Core.

Props dingo_d, jrf.
Fixes #47853.
No action taken yet
git: 84dfea9
svn: r46186
302 of 2871
Author
K. Adam White <[email protected]> 2019-09-19 14:35:47 +0000
REST API: Issue warning if array meta is registered without item schema.
The purpose of meta registration is to assert that the meta key will contain a predictable value conforming to a schema, so the schema is therefore considered to be required.

Props TimothyBlynJacobs, grapplerulrich.
Fixes #43392.
No action taken yet
git: 3514a52
svn: r46185
303 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-19 14:29:30 +0000
PHP 7.4: Fix another instance of array access on a datatype that cannot be accessed as an array.
PHP 7.4 adds a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

Follow up of [45639].

Props desrosj, jrf.
See #47704.
No action taken yet
git: b926baa
svn: r46184
304 of 2871
Author
K. Adam White <[email protected]> 2019-09-19 14:04:51 +0000
REST API: Support dot.nested hierarchical properties in _fields query parameter.
Enable clients to opt-in to receipt of one or more specific sub-properties within a response, and not other sub-properties.
Skip potentially expensive filtering and processing for post resources which were explicitly not requested.

Props kadamwhite, TimothyBlynJacobs, dlh.
Fixes #42094.
No action taken yet
git: 5f1cbd7
svn: r46183
305 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-19 12:01:03 +0000
Bootstrap/Load: Reorganize the initialization flow so that the check for PHP and MySQL requirements could run as early as possible.
This allows us to use PHP 5.6+ syntax in more files, and display a proper error message on older PHP versions, instead of causing a parse error.

Fixes #48059.
No action taken yet
git: a229207
svn: r46182
306 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-19 11:45:15 +0000
Tests: Replace `join()` with `implode()` in `do_enclose()` tests introduced in [46175], and ensure the arguments passed are in the correct order.
The `implode()` function accepts two parameters, `$glue` and `$pieces`. For historical reasons, these parameters have been accepted in any order, though it was recommended that the documented order of `$glue, $pieces` be used. It is also generally considered best practice to use the canonical function rather than an alias.

Starting in PHP 7.4, specifying the parameters in the reverse order will trigger a deprecation notice with the plan to remove this tolerance in PHP 8.0.

Props jrf.
Fixes #36824. See #47746.
No action taken yet
git: e5bee4e
svn: r46181
307 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-19 11:39:01 +0000
Docs: Format multi-line comment in [46180] per the documentation standards.
See #45066.
No action taken yet
git: a871226
svn: r46180
308 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-19 11:14:38 +0000
Tests: Update unit tests to account for the removal of old `wp-a11y` from the loaded scripts in [46179].
Props sstoqnov.
See #45066, #48071.
No action taken yet
git: aeac7fe
svn: r46179
309 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-19 09:54:00 +0000
Script Loader: Remove old `wp-a11y` from the loaded scripts after [46167] and [46169].
Props garrett-eclipse, sstoqnov.
See #45066.
Fixes #48071.
No action taken yet
git: 754056e
svn: r46178
310 of 2871
Author
Boone Gorges <[email protected]> 2019-09-19 02:05:25 +0000
Improve performance of trackback query in `do_all_pings()`.
Previously, the direct SQL query used to identify trackbacks in
`do_all_pings()` performed poorly, due to an unindexed query against the
`to_ping` column. We improve performance in two ways. First, we switch
to using a postmeta flag for posts that require trackbacks to be sent;
queries joining against the postmeta table that check only the `meta_key`
are generally quite fast. Second, we switch to the use of `WP_Query`,
making the query cacheable and filterable using standard methods.

Props dshanske, spacedmonkey, janw.oostendorp, mrmadhat, birgire.
Fixes #36824.
No action taken yet
git: 3419633
svn: r46177
311 of 2871
Author
Boone Gorges <[email protected]> 2019-09-19 01:59:06 +0000
Use `WP_Query` when sending pingbacks.
Props dshanske, spacedmonkey, janw.oostendorp, mrmadhat, birgire.
See #36824.
No action taken yet
git: daa1da9
svn: r46176
312 of 2871
Author
Boone Gorges <[email protected]> 2019-09-19 01:53:03 +0000
PHPCS: Fix coding standards violations in `do_enclose()`.
* Use strict checking when appropriate in `in_array()` checks.
* Improved comment formatting.
* Yoda and strict equality checks where appropriate.

See #36824.
No action taken yet
git: 48e280d
svn: r46175
313 of 2871
Author
Boone Gorges <[email protected]> 2019-09-19 01:48:54 +0000
Improve `do_enclose()` logic on post publish.
Removing the direct SQL query in `do_all_pings()` improves filterability.

As part of this change, the signature of `do_enclose()` is changed so that
a null `$content` parameter can be passed, with the `$content` then inferred
from the `$post` passed in the second parameter. In addition, the second
parameter was modified so that a post ID or a `WP_Post` object can be
provided. These changes make it possible to trigger enclosure checks with
a post ID alone (as in `do_all_pings()`) and also brings the function
signature in line with `do_trackbacks()` and `pingback()`.

Props dshanske, spacedmonkey, janw.oostendorp, mrmadhat, birgire.
See #36824.
No action taken yet
git: 20a1743
svn: r46174
314 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-19 01:25:14 +0000
Uploads: add helper functions for setting, getting, and deleting the temp upload reference used to the attachment_id when retrying to make image sub-sizes.
See #47872.
No action taken yet
git: 684f30f
svn: r46173
315 of 2871
Author
Andrew Ozz <[email protected]> 2019-09-19 00:59:59 +0000
TinyMCE: update to version 4.9.6. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt. Includes fix for the `Permission denied to access property "nodeType"` error.
Fixes #47437.
No action taken yet
git: 3d40bbe
svn: r46172
316 of 2871
Author
Jake Spurlock <whyisja[email protected]> 2019-09-18 23:37:08 +0000
Add SMS to the list of allowed protocols.
This commit expands the list of allowed protocols. It adds the `sms://` which can be used to open meessaging clients for mobile users.

Props rilwis, kraftbj

Fixes #39415
No action taken yet
git: 150b301
svn: r46171
317 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-18 22:41:29 +0000
Script Loader: Move the `current_theme_supports()` check above the `wp_default_(scripts|styles)` action, for consistency.
See #42804.
No action taken yet
git: 88bf910
svn: r46170
318 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-18 22:33:45 +0000
Script Loader: Only check current theme's HTML5 support for scripts and styles on front end.
Avoids a fatal error in the admin if `SCRIPT_DEBUG` is disabled.

Props azaozz.
See #42804.
No action taken yet
git: b8533a1
svn: r46169
319 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-18 22:29:53 +0000
Accesibility: Replace wp-a11y.js with @wordpress/a11y package
Continuation of [46167]. This fixes the tests that ended up broken following the previous commit.

We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also 
used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure 
webpack to load is an external.

Props, garrett-eclipse

Fixes #45066
No action taken yet
git: 9d339b4
svn: r46168
320 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-18 19:32:32 +0000
Media: remove leftover test string change after [45499].
Props imath, audrasjb.
Fixes #48067.
No action taken yet
git: 8029e23
svn: r46167
321 of 2871
Author
Jake Spurlock <[email protected]> 2019-09-18 17:40:35 +0000
Accessibility: Replace wp-a11y.js with @wordpress/a11y package
We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure webpack to load is an external.

Props omarreiss, herregroen, desrosj, ocean90, afercia, sstoqnov
No action taken yet
git: b7df2ea
svn: r46166
322 of 2871
Author
Aaron Jorbin <[email protected]> 2019-09-18 14:53:01 +0000
External Library: Update getid3 to 1.9.18
Follow up to r46112 as getid3 has tagged an official release.

Changes: https://github.com/JamesHeinrich/getID3/compare/00f3fbfd77e583099ca70a3cf0bc092e113d2b20...v1.9.18

Props desrosj, jkitchen.
Fixes #47751 #40883 #43836.
No action taken yet
git: baaaef5
svn: r46165
323 of 2871
Author
SergeyBiryukov <[email protected]> 2019-09-18 14:50:02 +0000
Bundled Themes: Declare HTML5 support for scripts and styles.
Fixes #42804.
No action taken yet
git: 5fdf48c
svn: r46164
324 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-18 14:49:30 +0000
Script Loader: Introduce HTML5 support for scripts and styles.
When a theme declares HTML5 support for script and styles via `add_theme_support( 'html5', array( 'script', 'style' ) )`, the `type="text/javascript"` and `type="text/css"` attributes are omitted.

These attributes are unnecessary in HTML5 and cause warnings in the W3C Markup Validation Service.

Props sasiddiqui, swissspidy, knutsp, SergeyBiryukov.
See #42804.
No action taken yet
git: 0dbd752
svn: r46163
325 of 2871
Author
Andrea Fercia <[email protected]> 2019-09-18 12:24:35 +0000
Accessibility: Add `aria-current` to the Archives, Categories, and Recent Posts widgets output.
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a list of items.

Continues the introduction in core of the `aria-current` attribute after [41359] and following changes.

Props audrasjb, melchoyce.
Fixes #47094.
No action taken yet
git: 4b3eb36
svn: r46162
326 of 2871
Author
John Blackbourn <[email protected]> 2019-09-17 21:02:22 +0000
Docs: Improve docs for upload and `wp_die()` related functions.
See #47110
No action taken yet
git: 45f1fbb
svn: r46161
327 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-17 20:42:57 +0000
Docs: Add missing descriptions for functions in `wp-admin/update-core.php`.
Also, fix the `@since` annotation added in [45480] to include the correct version.

Props SergeyBiryukov, ajayghaghretiya1.
Fixes #47424.
No action taken yet
git: 65ec280
svn: r46160
328 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-17 19:57:18 +0000
Posts, Post Types: Allow support arguments to be specified when registering post types.
The `add_post_type_support()` function accepts an optional third parameter that allows extra arguments to be supplied to configure post type support for a given feature. However, because of how `register_post_type()` and `WP_Post_Type->add_supports()` work, it is currently impossible to pass these additional arguments when initially registering a post type with `register_post_type()`.

This change makes it possible to supply additional arguments for a feature using the `supports` argument of `register_post_type()`.

Props MaximeCulea, seuser, desrosj, johnbillion.
Fixes #40413.
No action taken yet
git: 5e38f82
svn: r46159
329 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-17 18:48:27 +0000
Build/Test Tools: Improve test coverage for `wp_validate_boolean()`.
This change also reworks the test class to use a data provider.

Props pbearne, desrosj
Fixes #39868
No action taken yet
git: 5a200bd
svn: r46158
330 of 2871
Author
Adam Silverstein <[email protected]> 2019-09-17 17:26:38 +0000
Build/Test Tools: fix source map loading in Firefox.
Fix an issue that prevented source maps from loading correctly in Firefox developer tools. Matches a fix introduced in Gutenberg build in PR:17024.

Props pierlo, andraganescu.
Fixes #47870.
No action taken yet
git: 823b0d2
svn: r46157
331 of 2871
Author
Adam Silverstein <[email protected]> 2019-09-17 17:18:32 +0000
External Libraries: Update Backbone.js to 1.4.0.
Upgrade Backbone to the latest stable version. Fix some issues in Media with `listenTo` which changed in this version, see https://backbonejs.org/#changelog.

Props desrosj, priyankkpatel, pierlo.
Fixes #47478.
No action taken yet
git: ed25bc3
svn: r46156
332 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-17 15:42:51 +0000
Docs: Correct accepted values for `search_columns` parameter in `WP_User_Query`.
Props meloniq.
Fixes #48057.
No action taken yet
git: 352665d
svn: r46155
333 of 2871
Author
Jonathan Desrosiers <[email protected]> 2019-09-17 13:39:15 +0000
General: Ensure the arguments passed to `implode()` are in the correct order.
The `implode()` function accepts two. parameters, `$glue` and `$pieces`. For historical reasons, these parameters have been accepted in any order, though it was recommended that the documented order of `$glue, $pieces` be used.

Starting in PHP 7.4, specifying the parameters in the reverse order will trigger a deprecation notice with the plan to remove this tolerance in PHP 8.0.

This change fixes the occurrences of reversed arguments in Core with the exception of those contained in included external libraries. These will be handled separately.

Props jrf, jorbin.
See #47746.
No action taken yet
git: 5928234
svn: r46154
334 of 2871
Author
Sergey Biryukov <sergeybiryuk[email protected]> 2019-09-17 11:13:25 +0000
Date/Time: Introduce `get_post_datetime()` to retrieve post published or modified time as a `DateTimeImmutable` object instance.
Introduce `get_post_timestamp()` to retrieve post published or modified time as a Unix timestamp.

Use `get_post_datetime()` in `get_post_time()` and `get_post_modified_time()` to return correct GMT time if default timezone is changed from UTC.

Props Rarst, johnregan3.
Fixes #25002.
No action taken yet
git: 7cbb1f3
svn: r46153
335 of 2871
Author
John James Jacoby <[email protected]> 2019-09-16 23:33:45 +0000
Network Admin: Allow Sites to have filterable States in List Table rows.
This change introduces a new `site_states()` method to the Sites List Table class (with a new `display_site_states` filter inside of it) following the pattern popularized in other List Table classes before it (Posts, Media, etc...)

Fixes #37684. Props mnelson4, pbiron, jeremyfelt, johnjamesjacoby.
No action taken yet
git: 9218e2c
svn: r46152
336 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-16 19:54:15 +0000
Docs: Improve documentation for `get_bookmarks()`.
Props pbiron.
Fixes #48053.
No action taken yet
git: 444834f
svn: r46151
337 of 2871
Author
Sergey Biryukov <sergey[email protected]> 2019-09-16 17:22:32 +0000
Site Health: Add a link to "Debugging in WordPress" support article to fatal PHP error handler's default message.
Props garrett-eclipse, tobifjellner, dkarfa, hareesh-pillai.
Fixes #47681.
No action taken yet
git: fd31d7f
svn: r46150
338 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-16 16:31:13 +0000
Docs: Improve `@return` value description for `wp_xmlrpc_server::minimum_args()`.
See #47110.
No action taken yet
git: 31fa37f
svn: r46149
339 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-16 14:47:53 +0000
Code Modernisation: Remove redundant PHP 4 code from `do_action()`.
As of PHP 5, objects are always passed by reference, so this has not been needed for quite some time.

Props jrf.
See #47678.
No action taken yet
git: ea35099
svn: r46148
340 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-16 09:57:30 +0000
XML-RPC: Avoid a PHP warning in `wp_xmlrpc_server::minimum_args()` if `$args` is not an array.
Correct the documentation to clarify that array is the only acceptable type for `$args`.

Props bitcomplex, dkarfa.
Fixes #48046.
No action taken yet
git: f360f87
svn: r46147
341 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-16 09:13:01 +0000
Widgets: Introduce `register_sidebar_defaults` filter for default arguments in `register_sidebar()`.
Props patilvikasj, powerbuoy.
Fixes #48033.
No action taken yet
git: 209666d
svn: r46146
342 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 12:03:04 +0000
Code Modernisation: Simplify some logic in `apply_filters()`.
Props jrf.
See #47678.
No action taken yet
git: 802c23e
svn: r46145
343 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:55:42 +0000
Code Modernisation: Replace `call_user_func_array()` in `tests/phpunit/tests/db.php` with dynamic function calls.
Props jrf.
See #47678.
No action taken yet
git: 1ace250
svn: r46144
344 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:53:01 +0000
Code Modernisation: Replace `call_user_func_array()` in various `__call()` methods with dynamic function calls.
The callback in these functions is always checked against a limited list of valid callbacks that can be safely changed to dynamic function calls.

Props jrf.
See #47678.
No action taken yet
git: 1418bd0
svn: r46143
345 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:49:51 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-includes/class-wp-walker.php` with dynamic function calls.
Props jrf.
See #47678.
No action taken yet
git: 927098e
svn: r46142
346 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:47:38 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-cron.php` with a direct function call.
Props jrf.
See #47678.
No action taken yet
git: 0432a9f
svn: r46141
347 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:46:44 +0000
Code Modernisation: Remove redundant call to `func_get_arg()` in `wp-includes/class-wp-rewrite.php`.
Props jrf.
See #47678.
No action taken yet
git: 0521e61
svn: r46140
348 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:45:45 +0000
Code Modernisation: Remove redundant calls to `func_get_arg()` in `wp-includes/class-wp-admin-bar.php`.
Props jrf.
See #47678.
No action taken yet
git: d4d853e
svn: r46139
349 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:44:09 +0000
Code Modernisation: Replace `call_user_func_array()` in combination with an empty array in `wp-includes/class-wp-hook.php` with `call_user_func()`.
Props jrf.
See #47678.
No action taken yet
git: fd05ea0
svn: r46138
350 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:40:08 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/widgets.php` and associated unit tests with a direct function call.
Props jrf.
See #47678.
No action taken yet
git: 751f69b
svn: r46137
351 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:34:23 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/template.php` with a dynamic function call.
Props jrf.
See #47678.
No action taken yet
git: f16a56c
svn: r46136
352 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:33:20 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/ajax-actions.php` with a dynamic function call.
Props jrf.
See #47678.
No action taken yet
git: e17d5ac
svn: r46135
353 of 2871
Author
SergeyBiryukov <[email protected]> 2019-09-15 11:31:02 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-includes/post-template.php` with a dynamic function call.
Props jrf.
See #47678.
No action taken yet
git: 45827d6
svn: r46134
354 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:30:25 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-includes/nav-menu-template.php` with a dynamic function call.
Props jrf.
See #47678.
No action taken yet
git: db2bc9a
svn: r46133
355 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:26:16 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-includes/class-wp-customize-*.php` with direct function calls in combination with the spread operator.
Props jrf.
See #47678.
No action taken yet
git: 416e3d6
svn: r46132
356 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:22:51 +0000
Code Modernisation: Replace `call_user_func_array()` in `wp-includes/capabilities.php` with a direct function call.
Props jrf.
See #47678.
No action taken yet
git: 49de2b7
svn: r46131
357 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:11:14 +0000
Code Modernisation: Introduce the spread operator in `wp-admin/includes/media.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 752c36b
svn: r46130
358 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:10:17 +0000
Code Modernisation: Introduce the spread operator in `wp-admin/includes/dashboard.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 24a586b
svn: r46129
359 of 2871
Author
SergeyBiryukov <[email protected]> 2019-09-15 11:08:02 +0000
Code Modernisation: Introduce the spread operator in `wp-includes/deprecated.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

While these functions are deprecated, they can still get a minor performance boost in case they are being called.

Props jrf.
See #47678.
No action taken yet
git: cb1f496
svn: r46128
360 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:05:31 +0000
Code Modernisation: Introduce the spread operator in `wp-includes/formatting.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 3ae54e8
svn: r46127
361 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 11:03:45 +0000
Code Modernisation: Introduce the spread operator in `tests/phpunit/*`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
No action taken yet
git: 516f528
svn: r46126
362 of 2871
Author
Sergey Biryukov <[email protected]> 2019-09-15 10:44:58 +0000
Code Modernisation: Introduce the spread operator in `wp-includes/functions.php`.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use th